[PATCH 00/11] Remove blank help texts from Kconfig files and add warning

[PATCH 00/11] Remove blank help texts from Kconfig files and add warning

[Ulf Magnusson]

This patchset first removes all blank help texts from Kconfig files for all
arches, and then makes Kconfig print a warning for blank help texts.

All patches can be applied independently, but to avoid warning spam, the blank
help texts ought to be removed before the warning is added.

Ulf Magnusson (11):
  net/sched: kconfig: Remove blank help texts
  video: fbdev: kconfig: Remove blank help text
  mmc: kconfig: Remove blank help text
  Staging: rtl8192u: kconfig: Remove blank help text
  Staging: rtl8192e: kconfig: Remove blank help text
  lib/Kconfig.debug: Remove blank help text
  MIPS: BCM63XX: kconfig: Remove blank help text
  MIPS: kconfig: Remove blank help text
  arm: vt8500: kconfig: Remove blank help text
  nios2: kconfig: Remove blank help text
  kconfig: Warn if help text is blank

 arch/arm/mach-vt8500/Kconfig              | 1 -
 arch/mips/Kconfig                         | 1 -
 arch/mips/bcm63xx/boards/Kconfig          | 1 -
 arch/nios2/Kconfig                        | 1 -
 drivers/mmc/host/Kconfig                  | 1 -
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 drivers/staging/rtl8192u/Kconfig          | 1 -
 drivers/video/fbdev/Kconfig               | 1 -
 lib/Kconfig.debug                         | 1 -
 net/sched/Kconfig                         | 3 ---
 scripts/kconfig/zconf.y                   | 6 ++++++
 11 files changed, 6 insertions(+), 12 deletions(-)

-- 
2.14.1

[PATCH 01/11] net/sched: kconfig: Remove blank help texts

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 net/sched/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index c03d86a7775e..f24a6ae6819a 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -857,17 +857,14 @@ config NET_ACT_TUNNEL_KEY
 config NET_IFE_SKBMARK
         tristate "Support to encoding decoding skb mark on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBPRIO
         tristate "Support to encoding decoding skb prio on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBTCINDEX
         tristate "Support to encoding decoding skb tcindex on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_CLS_IND
 	bool "Incoming device classification"
-- 
2.14.1

[PATCH 02/11] video: fbdev: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/video/fbdev/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6962b4583fd7..11e699f1062b 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1156,7 +1156,6 @@ config FB_I810_I2C
 	bool "Enable DDC Support"
 	depends on FB_I810 && FB_I810_GTF
 	select FB_DDC
-	help
 
 config FB_LE80578
 	tristate "Intel LE80578 (Vermilion) support"
-- 
2.14.1

[PATCH 03/11] mmc: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/mmc/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 67bd3344dd03..24dee8eb5270 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -874,7 +874,6 @@ config MMC_CQHCI
 config MMC_TOSHIBA_PCI
 	tristate "Toshiba Type A SD/MMC Card Interface Driver"
 	depends on PCI
-	help
 
 config MMC_BCM2835
 	tristate "Broadcom BCM2835 SDHOST MMC Controller support"
-- 
2.14.1

[PATCH 04/11] Staging: rtl8192u: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192u/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig
index 3ee9d0d00fb6..97df6507a485 100644
--- a/drivers/staging/rtl8192u/Kconfig
+++ b/drivers/staging/rtl8192u/Kconfig
@@ -5,4 +5,3 @@ config RTL8192U
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select CRYPTO
-	---help---
-- 
2.14.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/11] Staging: rtl8192e: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig b/drivers/staging/rtl8192e/rtl8192e/Kconfig
index 282e293da18f..7ac42a590e21 100644
--- a/drivers/staging/rtl8192e/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/rtl8192e/Kconfig
@@ -6,4 +6,3 @@ config RTL8192E
 	select WEXT_PRIV
 	select CRYPTO
 	select FW_LOADER
-	---help---
-- 
2.14.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/11] lib/Kconfig.debug: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index b66c264d4194..6088408ef26c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -351,7 +351,6 @@ config SECTION_MISMATCH_WARN_ONLY
 #
 config ARCH_WANT_FRAME_POINTERS
 	bool
-	help
 
 config FRAME_POINTER
 	bool "Compile the kernel with frame pointers"
-- 
2.14.1

[PATCH 07/11] MIPS: BCM63XX: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/mips/bcm63xx/boards/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm63xx/boards/Kconfig
index 6ff0a7481081..f60d96610ace 100644
--- a/arch/mips/bcm63xx/boards/Kconfig
+++ b/arch/mips/bcm63xx/boards/Kconfig
@@ -7,6 +7,5 @@ choice
 config BOARD_BCM963XX
        bool "Generic Broadcom 963xx boards"
 	select SSB
-       help
 
 endchoice
-- 
2.14.1

[PATCH 08/11] MIPS: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/mips/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7b28 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2326,7 +2326,6 @@ config MIPS_VPE_LOADER_TOM
 config MIPS_VPE_APSP_API
 	bool "Enable support for AP/SP API (RTLX)"
 	depends on MIPS_VPE_LOADER
-	help
 
 config MIPS_VPE_APSP_API_CMP
 	bool
-- 
2.14.1

[PATCH 09/11] arm: vt8500: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/arm/mach-vt8500/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kconfig
index 1156a585dafc..8841199058ea 100644
--- a/arch/arm/mach-vt8500/Kconfig
+++ b/arch/arm/mach-vt8500/Kconfig
@@ -13,7 +13,6 @@ config ARCH_WM8505
  	depends on ARCH_MULTI_V5
  	select ARCH_VT8500
  	select CPU_ARM926T
- 	help
 
 config ARCH_WM8750
 	bool "WonderMedia WM8750"
-- 
2.14.1

[PATCH 10/11] nios2: kconfig: Remove blank help text

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to remove them, IMO.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/nios2/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 60fae03dac79..3d4ec88f1db1 100644
--- a/arch/nios2/Kconfig
+++ b/arch/nios2/Kconfig
@@ -152,7 +152,6 @@ menu "Advanced setup"
 
 config ADVANCED_OPTIONS
 	bool "Prompt for advanced kernel configuration options"
-	help
 
 comment "Default settings for advanced configuration options are used"
 	depends on !ADVANCED_OPTIONS
-- 
2.14.1

[PATCH 11/11] kconfig: Warn if help text is blank

[Ulf Magnusson]

Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).

Best to flag them, IMO.

Example warning:

	drivers/mmc/host/Kconfig:877: warning: 'MMC_TOSHIBA_PCI' defined with blank help text

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 scripts/kconfig/zconf.y | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y
index 21ce883e5d9e..4be98050b961 100644
--- a/scripts/kconfig/zconf.y
+++ b/scripts/kconfig/zconf.y
@@ -436,6 +436,12 @@ help: help_start T_HELPTEXT
 		zconfprint("warning: '%s' defined with more than one help text -- only the last one will be used",
 			   current_entry->sym->name ?: "<choice>");
 	}
+
+	/* Is the help text empty or all whitespace? */
+	if ($2[strspn($2, " \f\n\r\t\v")] == '\0')
+		zconfprint("warning: '%s' defined with blank help text",
+			   current_entry->sym->name ?: "<choice>");
+
 	current_entry->help = $2;
 };
 
-- 
2.14.1

Re: [PATCH 00/11] Remove blank help texts from Kconfig files and add warning

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> This patchset first removes all blank help texts from Kconfig files for all
> arches, and then makes Kconfig print a warning for blank help texts.
>
> All patches can be applied independently, but to avoid warning spam, the blank
> help texts ought to be removed before the warning is added.
>
> Ulf Magnusson (11):
>   net/sched: kconfig: Remove blank help texts
>   video: fbdev: kconfig: Remove blank help text
>   mmc: kconfig: Remove blank help text
>   Staging: rtl8192u: kconfig: Remove blank help text
>   Staging: rtl8192e: kconfig: Remove blank help text
>   lib/Kconfig.debug: Remove blank help text
>   MIPS: BCM63XX: kconfig: Remove blank help text
>   MIPS: kconfig: Remove blank help text
>   arm: vt8500: kconfig: Remove blank help text
>   nios2: kconfig: Remove blank help text
>   kconfig: Warn if help text is blank


Whole of the series, applied to linux-kbuild/kconfig.  Thanks!



>  arch/arm/mach-vt8500/Kconfig              | 1 -
>  arch/mips/Kconfig                         | 1 -
>  arch/mips/bcm63xx/boards/Kconfig          | 1 -
>  arch/nios2/Kconfig                        | 1 -
>  drivers/mmc/host/Kconfig                  | 1 -
>  drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
>  drivers/staging/rtl8192u/Kconfig          | 1 -
>  drivers/video/fbdev/Kconfig               | 1 -
>  lib/Kconfig.debug                         | 1 -
>  net/sched/Kconfig                         | 3 ---
>  scripts/kconfig/zconf.y                   | 6 ++++++
>  11 files changed, 6 insertions(+), 12 deletions(-)
>
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada

Re: [PATCH 00/11] Remove blank help texts from Kconfig files and add warning

[Randy Dunlap]

On 01/31/2018 07:27 AM, Masahiro Yamada wrote:
> 2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
>> This patchset first removes all blank help texts from Kconfig files for all
>> arches, and then makes Kconfig print a warning for blank help texts.
>>
>> All patches can be applied independently, but to avoid warning spam, the blank
>> help texts ought to be removed before the warning is added.
>>
>> Ulf Magnusson (11):
>>   net/sched: kconfig: Remove blank help texts
>>   video: fbdev: kconfig: Remove blank help text
>>   mmc: kconfig: Remove blank help text
>>   Staging: rtl8192u: kconfig: Remove blank help text
>>   Staging: rtl8192e: kconfig: Remove blank help text
>>   lib/Kconfig.debug: Remove blank help text
>>   MIPS: BCM63XX: kconfig: Remove blank help text
>>   MIPS: kconfig: Remove blank help text
>>   arm: vt8500: kconfig: Remove blank help text
>>   nios2: kconfig: Remove blank help text
>>   kconfig: Warn if help text is blank
> 
> 
> Whole of the series, applied to linux-kbuild/kconfig.  Thanks!
> 

That probably means that I am too late, but anyway:

Acked-by: Randy Dunlap <rdunlap@infradead.org> # series of 11 patches

Thanks.

> 
> 
>>  arch/arm/mach-vt8500/Kconfig              | 1 -
>>  arch/mips/Kconfig                         | 1 -
>>  arch/mips/bcm63xx/boards/Kconfig          | 1 -
>>  arch/nios2/Kconfig                        | 1 -
>>  drivers/mmc/host/Kconfig                  | 1 -
>>  drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
>>  drivers/staging/rtl8192u/Kconfig          | 1 -
>>  drivers/video/fbdev/Kconfig               | 1 -
>>  lib/Kconfig.debug                         | 1 -
>>  net/sched/Kconfig                         | 3 ---
>>  scripts/kconfig/zconf.y                   | 6 ++++++
>>  11 files changed, 6 insertions(+), 12 deletions(-)


-- 
~Randy

Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text

[Bartlomiej Zolnierkiewicz]

Hi,

On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
> 
> Best to remove them, IMO.

How about actually adding some meaningful help texts instead
(as a general rule each user visible option should have valid
help text)?

> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  drivers/video/fbdev/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 6962b4583fd7..11e699f1062b 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1156,7 +1156,6 @@ config FB_I810_I2C
>  	bool "Enable DDC Support"
>  	depends on FB_I810 && FB_I810_GTF
>  	select FB_DDC
> -	help

Please add a missing help text instead (take a look at FB_SAVAGE_I2C
config option to see how a valid help text entry should look like).

In the longer term we should consider removing *_I2C config options
and just make the main config options always enable I2C subsystem
directly if needed/useful (some fbdev drivers are doing it this way
already).

>  config FB_LE80578
>  	tristate "Intel LE80578 (Vermilion) support"

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text

[Ulf Magnusson]

On Thu, Feb 1, 2018 at 4:52 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> Hi,
>
> On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote:
>> Blank help texts are probably either a typo, a Kconfig misunderstanding,
>> or some kind of half-committing to adding a help text (in which case a
>> TODO comment would be clearer, if the help text really can't be added
>> right away).
>>
>> Best to remove them, IMO.
>
> How about actually adding some meaningful help texts instead
> (as a general rule each user visible option should have valid
> help text)?
>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>>  drivers/video/fbdev/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>> index 6962b4583fd7..11e699f1062b 100644
>> --- a/drivers/video/fbdev/Kconfig
>> +++ b/drivers/video/fbdev/Kconfig
>> @@ -1156,7 +1156,6 @@ config FB_I810_I2C
>>       bool "Enable DDC Support"
>>       depends on FB_I810 && FB_I810_GTF
>>       select FB_DDC
>> -     help
>
> Please add a missing help text instead (take a look at FB_SAVAGE_I2C
> config option to see how a valid help text entry should look like).

The FB_I810_I2C option was added in 74f6ae84b23 ("[PATCH] i810fb: Add
i2c/DDC support"). What do you think about adding this bit from the
commit message as the help text?

  Add DDC/I2C support for i810fb.  This will allow the driver to get display
  information, especially for monitors with fickle timings.

I'm not familiar with this code, so I don't want to do too much
guessing myself. :)

>
> In the longer term we should consider removing *_I2C config options
> and just make the main config options always enable I2C subsystem
> directly if needed/useful (some fbdev drivers are doing it this way
> already).
>
>>  config FB_LE80578
>>       tristate "Intel LE80578 (Vermilion) support"
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>

Cheers,
Ulf

Re: [PATCH 00/11] Remove blank help texts from Kconfig files and add warning

[Masahiro Yamada]

2018-02-01 5:46 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> On 01/31/2018 07:27 AM, Masahiro Yamada wrote:
>> 2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
>>> This patchset first removes all blank help texts from Kconfig files for all
>>> arches, and then makes Kconfig print a warning for blank help texts.
>>>
>>> All patches can be applied independently, but to avoid warning spam, the blank
>>> help texts ought to be removed before the warning is added.
>>>
>>> Ulf Magnusson (11):
>>>   net/sched: kconfig: Remove blank help texts
>>>   video: fbdev: kconfig: Remove blank help text
>>>   mmc: kconfig: Remove blank help text
>>>   Staging: rtl8192u: kconfig: Remove blank help text
>>>   Staging: rtl8192e: kconfig: Remove blank help text
>>>   lib/Kconfig.debug: Remove blank help text
>>>   MIPS: BCM63XX: kconfig: Remove blank help text
>>>   MIPS: kconfig: Remove blank help text
>>>   arm: vt8500: kconfig: Remove blank help text
>>>   nios2: kconfig: Remove blank help text
>>>   kconfig: Warn if help text is blank
>>
>>
>> Whole of the series, applied to linux-kbuild/kconfig.  Thanks!
>>
>
> That probably means that I am too late, but anyway:
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # series of 11 patches
>


I will add your Acked-by. Thanks!


-- 
Best Regards
Masahiro Yamada

Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text

[Masahiro Yamada]

2018-02-02 1:56 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> On Thu, Feb 1, 2018 at 4:52 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>> Hi,
>>
>> On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote:
>>> Blank help texts are probably either a typo, a Kconfig misunderstanding,
>>> or some kind of half-committing to adding a help text (in which case a
>>> TODO comment would be clearer, if the help text really can't be added
>>> right away).
>>>
>>> Best to remove them, IMO.

FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series.


-- 
Best Regards
Masahiro Yamada

Re: [PATCH 03/11] mmc: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.

Re: [PATCH 04/11] Staging: rtl8192u: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---

FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/11] Staging: rtl8192e: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.




-- 
Best Regards
Masahiro Yamada
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 06/11] lib/Kconfig.debug: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.

Re: [PATCH 08/11] MIPS: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.



-- 
Best Regards
Masahiro Yamada

Re: [PATCH 10/11] nios2: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.

Re: [PATCH 09/11] arm: vt8500: kconfig: Remove blank help text

[Masahiro Yamada]

2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---


FYI.

I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.

I am planning to send a PR for this series next week.

Re: [PATCH 10/11] nios2: kconfig: Remove blank help text

[Ley Foon Tan]

On Wed, 2018-01-31 at 10:34 +0100, Ulf Magnusson wrote:
> Blank help texts are probably either a typo, a Kconfig
> misunderstanding,
> or some kind of half-committing to adding a help text (in which case
> a
> TODO comment would be clearer, if the help text really can't be added
> right away).
> 
> Best to remove them, IMO.
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  arch/nios2/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
> index 60fae03dac79..3d4ec88f1db1 100644
> --- a/arch/nios2/Kconfig
> +++ b/arch/nios2/Kconfig
> @@ -152,7 +152,6 @@ menu "Advanced setup"
> 
>  config ADVANCED_OPTIONS
>         bool "Prompt for advanced kernel configuration options"
> -       help
> 
>  comment "Default settings for advanced configuration options are
> used"
>         depends on !ADVANCED_OPTIONS
> --
> 2.14.1
> 

Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>

Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text

[Bartlomiej Zolnierkiewicz]

On Thursday, February 01, 2018 05:56:18 PM Ulf Magnusson wrote:
> On Thu, Feb 1, 2018 at 4:52 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Hi,
> >
> > On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote:
> >> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> >> or some kind of half-committing to adding a help text (in which case a
> >> TODO comment would be clearer, if the help text really can't be added
> >> right away).
> >>
> >> Best to remove them, IMO.
> >
> > How about actually adding some meaningful help texts instead
> > (as a general rule each user visible option should have valid
> > help text)?
> >
> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> >> ---
> >>  drivers/video/fbdev/Kconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> >> index 6962b4583fd7..11e699f1062b 100644
> >> --- a/drivers/video/fbdev/Kconfig
> >> +++ b/drivers/video/fbdev/Kconfig
> >> @@ -1156,7 +1156,6 @@ config FB_I810_I2C
> >>       bool "Enable DDC Support"
> >>       depends on FB_I810 && FB_I810_GTF
> >>       select FB_DDC
> >> -     help
> >
> > Please add a missing help text instead (take a look at FB_SAVAGE_I2C
> > config option to see how a valid help text entry should look like).
> 
> The FB_I810_I2C option was added in 74f6ae84b23 ("[PATCH] i810fb: Add
> i2c/DDC support"). What do you think about adding this bit from the
> commit message as the help text?
> 
>   Add DDC/I2C support for i810fb.  This will allow the driver to get display
>   information, especially for monitors with fickle timings.

Seems fine to me, please add:

    If unsure, say Y.

and send it as a proper patch.

> I'm not familiar with this code, so I don't want to do too much
> guessing myself. :)

:)

> > In the longer term we should consider removing *_I2C config options
> > and just make the main config options always enable I2C subsystem
> > directly if needed/useful (some fbdev drivers are doing it this way
> > already).
> >
> >>  config FB_LE80578
> >>       tristate "Intel LE80578 (Vermilion) support"
> >
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >
> 
> Cheers,
> Ulf

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[PATCH] video: fbdev: kconfig: Add help text to FB_I810_I2C

[Ulf Magnusson]

The FB_I810_I2C symbol previously had a blank help text, which was
removed in e9829ac4e5fd ("video: fbdev: kconfig: Remove blank help
text").

Give it a proper help text, derived from commit 74f6ae84b23 ("[PATCH]
i810fb: Add > i2c/DDC support").

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
Note: The removal of the blank help text is already in Linus' tree.

 drivers/video/fbdev/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 11e699f1062b..c691f1489bb7 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1156,6 +1156,11 @@ config FB_I810_I2C
 	bool "Enable DDC Support"
 	depends on FB_I810 && FB_I810_GTF
 	select FB_DDC
+	help
+	  Add DDC/I2C support for i810fb.  This will allow the driver to get
+	  display information, especially for monitors with fickle timings.
+
+	  If unsure, say Y.
 
 config FB_LE80578
 	tristate "Intel LE80578 (Vermilion) support"
-- 
2.14.1

Re: [PATCH 03/11] mmc: kconfig: Remove blank help text

[Ulf Hansson]

On 1 February 2018 at 18:09, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
>> Blank help texts are probably either a typo, a Kconfig misunderstanding,
>> or some kind of half-committing to adding a help text (in which case a
>> TODO comment would be clearer, if the help text really can't be added
>> right away).
>>
>> Best to remove them, IMO.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>
>
> FYI.
>
> I picked up this patch to kbuild
> because I need this to suppress warning messages
> introduced by 11/11.

Okay. Feel free to add my ack.

[...]

Kind regards
Uffe

Re: [PATCH] video: fbdev: kconfig: Add help text to FB_I810_I2C

[Bartlomiej Zolnierkiewicz]

On Tuesday, February 13, 2018 03:02:48 PM Ulf Magnusson wrote:
> The FB_I810_I2C symbol previously had a blank help text, which was
> removed in e9829ac4e5fd ("video: fbdev: kconfig: Remove blank help
> text").
> 
> Give it a proper help text, derived from commit 74f6ae84b23 ("[PATCH]
> i810fb: Add > i2c/DDC support").
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics