From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Matthew Wilcox <willy@infradead.org>
Cc: Daniel Micay <danielmicay@gmail.com>,
Jann Horn <jannh@google.com>,
linux-mm@kvack.org,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
kernel list <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [RFC] Limit mappings to ten per page per process
Date: Wed, 14 Feb 2018 17:05:17 +0300 [thread overview]
Message-ID: <20180214140517.ipgxvskdy7bwl7up@node.shutemov.name> (raw)
In-Reply-To: <20180214135141.GA16215@bombadil.infradead.org>
On Wed, Feb 14, 2018 at 05:51:41AM -0800, Matthew Wilcox wrote:
> On Fri, Feb 09, 2018 at 07:26:09AM +0300, Kirill A. Shutemov wrote:
> > On Thu, Feb 08, 2018 at 01:37:43PM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 08, 2018 at 12:21:00PM -0800, Matthew Wilcox wrote:
> > > > Now that I think about it, though, perhaps the simplest solution is not
> > > > to worry about checking whether _mapcount has saturated, and instead when
> > > > adding a new mmap, check whether this task already has it mapped 10 times.
> > > > If so, refuse the mapping.
> > >
> > > That turns out to be quite easy. Comments on this approach?
> >
> > This *may* break some remap_file_pages() users.
>
> We have some?! ;-)
I can't prove otherwise :)
> I don't understand the use case where they want to map the same page of
> a file multiple times into the same process. I mean, yes, of course,
> they might ask for it, but I don't understand why they would. Do you
> have any insight here?
Some form of data deduplication? Like having repeating chunks stored once
on presistent storage and page cache, but put into memory in
"uncompressed" form.
It's not limited to remap_file_pages(). Plain mmap() can be used for this
too.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-02-14 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 2:11 [RFC] Warn the user when they could overflow mapcount Matthew Wilcox
2018-02-08 2:56 ` Jann Horn
2018-02-08 4:04 ` Matthew Wilcox
2018-02-08 17:58 ` valdis.kletnieks
2018-02-08 18:05 ` Daniel Micay
2018-02-08 18:56 ` Matthew Wilcox
2018-02-08 19:33 ` Daniel Micay
2018-02-08 19:42 ` Matthew Wilcox
2018-02-08 19:48 ` Daniel Micay
2018-02-08 20:21 ` Matthew Wilcox
2018-02-08 21:37 ` [RFC] Limit mappings to ten per page per process Matthew Wilcox
2018-02-09 4:26 ` Kirill A. Shutemov
2018-02-14 13:51 ` Matthew Wilcox
2018-02-14 14:05 ` Kirill A. Shutemov [this message]
2018-02-09 1:47 ` [RFC] Warn the user when they could overflow mapcount Daniel Micay
2018-02-08 3:18 ` Tobin C. Harding
2018-02-08 4:06 ` Matthew Wilcox
2018-03-02 21:26 ` [RFC] Handle mapcount overflows Matthew Wilcox
2018-03-02 22:03 ` Matthew Wilcox
2019-05-01 14:41 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214140517.ipgxvskdy7bwl7up@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=danielmicay@gmail.com \
--cc=jannh@google.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).