* [PATCH] namei: fix hardlink speeling error
@ 2018-02-15 2:28 Richard Guy Briggs
2018-02-15 3:44 ` Matthew Wilcox
2018-02-15 9:57 ` Philipp Hahn
0 siblings, 2 replies; 4+ messages in thread
From: Richard Guy Briggs @ 2018-02-15 2:28 UTC (permalink / raw)
To: LKML, linux-fsdevel; +Cc: viro, Paul Moore, Richard Guy Briggs
Fix handlink to hardlink.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namei.c b/fs/namei.c
index bf1c046b..bbfb21d3 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4258,7 +4258,7 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
/*
* To use null names we require CAP_DAC_READ_SEARCH
* This ensures that not everyone will be able to create
- * handlink using the passed filedescriptor.
+ * hardlink using the passed filedescriptor.
*/
if (flags & AT_EMPTY_PATH) {
if (!capable(CAP_DAC_READ_SEARCH))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] namei: fix hardlink speeling error
2018-02-15 2:28 [PATCH] namei: fix hardlink speeling error Richard Guy Briggs
@ 2018-02-15 3:44 ` Matthew Wilcox
2018-02-15 9:57 ` Philipp Hahn
1 sibling, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2018-02-15 3:44 UTC (permalink / raw)
To: Richard Guy Briggs; +Cc: LKML, linux-fsdevel, viro, Paul Moore
On Wed, Feb 14, 2018 at 09:28:54PM -0500, Richard Guy Briggs wrote:
> * This ensures that not everyone will be able to create
> - * handlink using the passed filedescriptor.
> + * hardlink using the passed filedescriptor.
> */
You're changing this line and you didn't feel the need to fix the
missing space or the missing article?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] namei: fix hardlink speeling error
2018-02-15 2:28 [PATCH] namei: fix hardlink speeling error Richard Guy Briggs
2018-02-15 3:44 ` Matthew Wilcox
@ 2018-02-15 9:57 ` Philipp Hahn
2018-02-15 11:58 ` Richard Guy Briggs
1 sibling, 1 reply; 4+ messages in thread
From: Philipp Hahn @ 2018-02-15 9:57 UTC (permalink / raw)
To: Richard Guy Briggs, LKML, linux-fsdevel; +Cc: viro, Paul Moore
Hello,
Am 15.02.2018 um 03:28 schrieb Richard Guy Briggs:
> Fix handlink to hardlink.
and introduce a new sp*el*ling error in the subject line ;-)
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] namei: fix hardlink speeling error
2018-02-15 9:57 ` Philipp Hahn
@ 2018-02-15 11:58 ` Richard Guy Briggs
0 siblings, 0 replies; 4+ messages in thread
From: Richard Guy Briggs @ 2018-02-15 11:58 UTC (permalink / raw)
To: Philipp Hahn; +Cc: LKML, linux-fsdevel, viro, Paul Moore
On 2018-02-15 10:57, Philipp Hahn wrote:
> Hello,
>
> Am 15.02.2018 um 03:28 schrieb Richard Guy Briggs:
> > Fix handlink to hardlink.
>
> and introduce a new sp*el*ling error in the subject line ;-)
That one was quite intentional for ironic effect. I could have added an
extra "e" for exaggerated effect if you like. :-)
As for filedescriptor, that one I chose to leave alone due to 7 other
instances (out of ~700), while handlink stood alone (out of 126 hardlink
without and 77 with space) and was clearly misspelled in the context of
the source file.
I can file a followup patch to fix all "filedescriptor" in the same
patch if desired, but I'm not so sure that one is warranted.
> Philipp
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-15 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 2:28 [PATCH] namei: fix hardlink speeling error Richard Guy Briggs
2018-02-15 3:44 ` Matthew Wilcox
2018-02-15 9:57 ` Philipp Hahn
2018-02-15 11:58 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).