linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards
@ 2018-02-02 15:51 JackStocker
  2018-02-02 18:19 ` Dmitry Fleytman
  2018-02-04 13:35 ` Kai Heng Feng
  0 siblings, 2 replies; 10+ messages in thread
From: JackStocker @ 2018-02-02 15:51 UTC (permalink / raw)
  Cc: Jack Stocker, Greg Kroah-Hartman, Felipe Balbi, Seth Forshee,
	Kai-Heng Feng, Stefan Bader, Samuel Thibault, Devin Heitmueller,
	Sandeep Singh, Dmitry Fleytman, linux-usb, linux-kernel

From: Jack Stocker <jackstocker.93@gmail.com>

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard 

Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..9eb92dc 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
 
+	/* Corsair K70 RGB */
+	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
 	/* MIDI keyboard WORLDE MINI */
 	{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
 			USB_QUIRK_CONFIG_INTF_STRINGS },
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-02 15:51 [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards JackStocker
@ 2018-02-02 18:19 ` Dmitry Fleytman
  2018-02-04 13:35 ` Kai Heng Feng
  1 sibling, 0 replies; 10+ messages in thread
From: Dmitry Fleytman @ 2018-02-02 18:19 UTC (permalink / raw)
  To: JackStocker
  Cc: Greg Kroah-Hartman, Felipe Balbi, Seth Forshee, Kai-Heng Feng,
	Stefan Bader, Samuel Thibault, Devin Heitmueller, Sandeep Singh,
	dmitry, linux-usb, linux-kernel

> On 2 Feb 2018, at 17:51, JackStocker <jackstocker.93@gmail.com> wrote:
> 
> From: Jack Stocker <jackstocker.93@gmail.com>
> 
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
> 
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard 

Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>

> 
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	/* Corsair Strafe RGB */
> 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
> 
> +	/* Corsair K70 RGB */
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +
> 	/* MIDI keyboard WORLDE MINI */
> 	{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
> 			USB_QUIRK_CONFIG_INTF_STRINGS },
> -- 
> 2.7.4
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-02 15:51 [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards JackStocker
  2018-02-02 18:19 ` Dmitry Fleytman
@ 2018-02-04 13:35 ` Kai Heng Feng
  2018-02-04 16:18   ` [PATCH v2] " JackStocker
  1 sibling, 1 reply; 10+ messages in thread
From: Kai Heng Feng @ 2018-02-04 13:35 UTC (permalink / raw)
  To: JackStocker
  Cc: Greg Kroah-Hartman, Felipe Balbi, Seth Forshee, Stefan Bader,
	Samuel Thibault, Devin Heitmueller, Sandeep Singh,
	Dmitry Fleytman, linux-usb, linux-kernel



> On 2 Feb 2018, at 11:51 PM, JackStocker <jackstocker.93@gmail.com> wrote:
> 
> From: Jack Stocker <jackstocker.93@gmail.com>
> 
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
> 
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard 
> 
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	/* Corsair Strafe RGB */
> 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
> 
> +	/* Corsair K70 RGB */
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +

I think this change should move up, to make the table follows an ascending order.

> 	/* MIDI keyboard WORLDE MINI */
> 	{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
> 			USB_QUIRK_CONFIG_INTF_STRINGS },
> -- 
> 2.7.4
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-04 13:35 ` Kai Heng Feng
@ 2018-02-04 16:18   ` JackStocker
  2018-02-04 16:38     ` Kai Heng Feng
  0 siblings, 1 reply; 10+ messages in thread
From: JackStocker @ 2018-02-04 16:18 UTC (permalink / raw)
  Cc: JackStocker, Greg Kroah-Hartman, Felipe Balbi, Seth Forshee,
	Kai-Heng Feng, Thadeu Lima de Souza Cascardo, Sandeep Singh,
	Devin Heitmueller, Dmitry Fleytman, Samuel Thibault, linux-usb,
	linux-kernel

Do you mean like this?

Signed-off-by: JackStocker <jackstocker.93@gmail.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
+	/* Corsair K70 RGB */
+	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-04 16:18   ` [PATCH v2] " JackStocker
@ 2018-02-04 16:38     ` Kai Heng Feng
  2018-02-04 16:50       ` [PATCH v3] " JackStocker
  0 siblings, 1 reply; 10+ messages in thread
From: Kai Heng Feng @ 2018-02-04 16:38 UTC (permalink / raw)
  To: JackStocker
  Cc: Greg Kroah-Hartman, Felipe Balbi, Seth Forshee,
	Thadeu Lima de Souza Cascardo, Sandeep Singh, Devin Heitmueller,
	Dmitry Fleytman, Samuel Thibault, linux-usb, linux-kernel



> On 5 Feb 2018, at 12:18 AM, JackStocker <jackstocker.93@gmail.com> wrote:
> 
> Do you mean like this?

Yes, with proper commit message.

> 
> Signed-off-by: JackStocker <jackstocker.93@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..0405d68 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
> 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> 
> +	/* Corsair K70 RGB */
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +
> 	/* Corsair Strafe RGB */
> 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
> 
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-04 16:38     ` Kai Heng Feng
@ 2018-02-04 16:50       ` JackStocker
  2018-02-15 17:35         ` Greg Kroah-Hartman
  0 siblings, 1 reply; 10+ messages in thread
From: JackStocker @ 2018-02-04 16:50 UTC (permalink / raw)
  Cc: JackStocker, Greg Kroah-Hartman, Felipe Balbi, Kai-Heng Feng,
	Seth Forshee, Dmitry Fleytman, Devin Heitmueller, Sandeep Singh,
	Samuel Thibault, linux-usb, linux-kernel

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Signed-off-by: JackStocker <jackstocker.93@gmail.com>
---
Changes in v3:
  - Added correct v1 commit message.
Changes in v2:
  - Moved K70 entry above Strafe to preserve ascending order.

 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
+	/* Corsair K70 RGB */
+	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-04 16:50       ` [PATCH v3] " JackStocker
@ 2018-02-15 17:35         ` Greg Kroah-Hartman
  2018-02-15 17:59           ` Jack
  0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2018-02-15 17:35 UTC (permalink / raw)
  To: JackStocker
  Cc: Felipe Balbi, Kai-Heng Feng, Seth Forshee, Dmitry Fleytman,
	Devin Heitmueller, Sandeep Singh, Samuel Thibault, linux-usb,
	linux-kernel

On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
> 
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
> 
> Signed-off-by: JackStocker <jackstocker.93@gmail.com>

I need a "real" name here please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-15 17:35         ` Greg Kroah-Hartman
@ 2018-02-15 17:59           ` Jack
  2018-02-15 18:02             ` Greg Kroah-Hartman
  0 siblings, 1 reply; 10+ messages in thread
From: Jack @ 2018-02-15 17:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Felipe Balbi, Kai-Heng Feng, Seth Forshee, Dmitry Fleytman,
	Devin Heitmueller, Sandeep Singh, Samuel Thibault, linux-usb,
	linux-kernel

On 15/02/18 17:35, Greg Kroah-Hartman wrote:
> On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
>> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
>> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
>> start correctly at boot.
>>
>> Device ids found here:
>> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
>> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
>>
>> Signed-off-by: JackStocker <jackstocker.93@gmail.com>
> I need a "real" name here please.
>
> thanks,
>
> greg k-h
As in 'Jack Stocker' is that correct?

Cheers,
Jack

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-15 17:59           ` Jack
@ 2018-02-15 18:02             ` Greg Kroah-Hartman
  2018-02-15 18:24               ` [PATCH v4] " Jack Stocker
  0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2018-02-15 18:02 UTC (permalink / raw)
  To: Jack
  Cc: Felipe Balbi, Kai-Heng Feng, Seth Forshee, Dmitry Fleytman,
	Devin Heitmueller, Sandeep Singh, Samuel Thibault, linux-usb,
	linux-kernel

On Thu, Feb 15, 2018 at 05:59:34PM +0000, Jack wrote:
> On 15/02/18 17:35, Greg Kroah-Hartman wrote:
> > On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
> > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> > > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> > > start correctly at boot.
> > > 
> > > Device ids found here:
> > > usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> > > usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > > usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
> > > 
> > > Signed-off-by: JackStocker <jackstocker.93@gmail.com>
> > I need a "real" name here please.
> > 
> > thanks,
> > 
> > greg k-h
> As in 'Jack Stocker' is that correct?

If that is how you sign legal documents, yes :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v4] Add delay-init quirk for Corsair K70 RGB keyboards
  2018-02-15 18:02             ` Greg Kroah-Hartman
@ 2018-02-15 18:24               ` Jack Stocker
  0 siblings, 0 replies; 10+ messages in thread
From: Jack Stocker @ 2018-02-15 18:24 UTC (permalink / raw)
  Cc: Jack Stocker, Greg Kroah-Hartman, Seth Forshee, Felipe Balbi,
	Kai-Heng Feng, Dmitry Fleytman, Samuel Thibault,
	Devin Heitmueller, linux-usb, linux-kernel

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
Cc: stable <stable@vger.kernel.org>
---
Changes in v4:
  - Corrected 'real' name.
Changes in v3:
  - Added correct v1 commit message.
Changes in v2:
  - Moved K70 entry above Strafe to preserve ascending order.

 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
+	/* Corsair K70 RGB */
+	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-02-15 18:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 15:51 [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards JackStocker
2018-02-02 18:19 ` Dmitry Fleytman
2018-02-04 13:35 ` Kai Heng Feng
2018-02-04 16:18   ` [PATCH v2] " JackStocker
2018-02-04 16:38     ` Kai Heng Feng
2018-02-04 16:50       ` [PATCH v3] " JackStocker
2018-02-15 17:35         ` Greg Kroah-Hartman
2018-02-15 17:59           ` Jack
2018-02-15 18:02             ` Greg Kroah-Hartman
2018-02-15 18:24               ` [PATCH v4] " Jack Stocker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).