From: Brian Norris <briannorris@chromium.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
linux-acpi@vger.kernel.org, stable@vger.kernel.org,
Leif Liddy <leif.linux@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Daniel Drake <drake@endlessm.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
matadeen@qti.qualcomm.com, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Benson Leung <bleung@chromium.org>
Subject: Re: udev USB autosupend whitelist (was Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version)
Date: Fri, 16 Feb 2018 08:49:25 -0800 [thread overview]
Message-ID: <20180216164924.GA72213@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <0a13d0f3-8e0d-74df-df9c-2bf0622a9fb6@redhat.com>
+ Benson (and there are probably others that know better answers)
Hi,
On Fri, Feb 16, 2018 at 09:26:37AM +0100, Hans de Goede wrote:
> Going a bit off-topic here, so changed the subject.
> I will reply on topic in another mail.
>
> On 16-02-18 03:27, Brian Norris wrote:
> > I use a set of udev rules that manually whitelist devices for
> > autosuspend. You can see it here:
> >
> > https://chromium.googlesource.com/chromiumos/platform2/+/43728a93f6de137006c6b92fbb2a7cc4f353c9bf/power_manager/udev/gen_autosuspend_rules.py#83
> >
> > You'll find at least one Rome chip in there.
>
> Oh, that is a very interesting link for the work I've been doing to
> improve Linux power-consumption in general:
>
> https://fedoraproject.org/wiki/Changes/ImprovedLaptopBatteryLife
>
> I was actually planning on at least doing such a list for WWAN modems,
> for btusb my approach has been to just enable it everywhere
> (except for QCA devices as I got bugreports for those).
>
> Note that I plan to eventually submit this whitelist to the
> udev rules which are part of systemd upstream, so if chromeos
> is using systemd too, this is something to be aware of for you.
Chrome OS does not currently use systemd, but thanks for the heads up.
> Question, is the white-listing of the root and rate-limiting
> hubs really necessary? I thought these have this enabled by default?
This list is old and maintained by several of my team, originating from
quite a ways back (i.e., much older kernels). It's quite possible that
some of it is redundant today.
> Also any caveats here I should be aware of?
That it's only maintained for the express purpose of Chrome{device}s?
There's no guarantee that there aren't platform issues with other
systems, for instance :)
I'm not really aware of any particular caveats otherwise.
Brian
next prev parent reply other threads:[~2018-02-16 16:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180108094416.4789-1-hdegoede@redhat.com>
2018-02-13 2:24 ` [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version Brian Norris
2018-02-13 11:25 ` Hans de Goede
2018-02-16 2:27 ` Brian Norris
2018-02-16 3:23 ` Guenter Roeck
2018-02-16 8:26 ` udev USB autosupend whitelist (was Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version) Hans de Goede
2018-02-16 16:49 ` Brian Norris [this message]
2018-02-19 14:59 ` Hans de Goede
2018-02-16 8:43 ` [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version Marcel Holtmann
2018-02-16 8:56 ` Hans de Goede
2018-02-16 11:45 ` Marcel Holtmann
2018-02-16 12:10 ` Hans de Goede
2018-02-16 17:59 ` Brian Norris
2018-02-19 10:17 ` Hans de Goede
2018-02-23 3:12 ` Brian Norris
2018-02-23 7:14 ` Hans de Goede
2018-02-27 2:29 ` Brian Norris
2018-02-27 14:07 ` Hans de Goede
2018-02-28 10:54 ` Hans de Goede
2018-03-09 0:56 ` Leif Liddy
2018-03-10 2:42 ` Leif Liddy
2018-02-18 8:13 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216164924.GA72213@rodete-desktop-imager.corp.google.com \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=drake@endlessm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=leif.linux@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcel@holtmann.org \
--cc=matadeen@qti.qualcomm.com \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).