linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen
@ 2018-02-21 14:05 Rodrigo Siqueira
  2018-02-21 16:04 ` Daniel Baluta
  0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Siqueira @ 2018-02-21 14:05 UTC (permalink / raw)
  To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler
  Cc: daniel.baluta, linux-iio, kernel-janitors, linux-kernel

This patch fixes the following checkpatch.pl warnings:

drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
align the * on each line
drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
after function/struct/union/enum declarations

Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
 drivers/iio/dummy/iio_dummy_evgen.c  | 20 ++++++++++----------
 drivers/iio/dummy/iio_simple_dummy.c |  3 ++-
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
index efd0005f59b4..16ea547f79f0 100644
--- a/drivers/iio/dummy/iio_dummy_evgen.c
+++ b/drivers/iio/dummy/iio_dummy_evgen.c
@@ -148,16 +148,16 @@ static ssize_t iio_evgen_poke(struct device *dev,
 	return len;
 }
 
-static IIO_DEVICE_ATTR(poke_ev0, S_IWUSR, NULL, &iio_evgen_poke, 0);
-static IIO_DEVICE_ATTR(poke_ev1, S_IWUSR, NULL, &iio_evgen_poke, 1);
-static IIO_DEVICE_ATTR(poke_ev2, S_IWUSR, NULL, &iio_evgen_poke, 2);
-static IIO_DEVICE_ATTR(poke_ev3, S_IWUSR, NULL, &iio_evgen_poke, 3);
-static IIO_DEVICE_ATTR(poke_ev4, S_IWUSR, NULL, &iio_evgen_poke, 4);
-static IIO_DEVICE_ATTR(poke_ev5, S_IWUSR, NULL, &iio_evgen_poke, 5);
-static IIO_DEVICE_ATTR(poke_ev6, S_IWUSR, NULL, &iio_evgen_poke, 6);
-static IIO_DEVICE_ATTR(poke_ev7, S_IWUSR, NULL, &iio_evgen_poke, 7);
-static IIO_DEVICE_ATTR(poke_ev8, S_IWUSR, NULL, &iio_evgen_poke, 8);
-static IIO_DEVICE_ATTR(poke_ev9, S_IWUSR, NULL, &iio_evgen_poke, 9);
+static IIO_DEVICE_ATTR(poke_ev0, 0200, NULL, &iio_evgen_poke, 0);
+static IIO_DEVICE_ATTR(poke_ev1, 0200, NULL, &iio_evgen_poke, 1);
+static IIO_DEVICE_ATTR(poke_ev2, 0200, NULL, &iio_evgen_poke, 2);
+static IIO_DEVICE_ATTR(poke_ev3, 0200, NULL, &iio_evgen_poke, 3);
+static IIO_DEVICE_ATTR(poke_ev4, 0200, NULL, &iio_evgen_poke, 4);
+static IIO_DEVICE_ATTR(poke_ev5, 0200, NULL, &iio_evgen_poke, 5);
+static IIO_DEVICE_ATTR(poke_ev6, 0200, NULL, &iio_evgen_poke, 6);
+static IIO_DEVICE_ATTR(poke_ev7, 0200, NULL, &iio_evgen_poke, 7);
+static IIO_DEVICE_ATTR(poke_ev8, 0200, NULL, &iio_evgen_poke, 8);
+static IIO_DEVICE_ATTR(poke_ev9, 0200, NULL, &iio_evgen_poke, 9);
 
 static struct attribute *iio_evgen_attrs[] = {
 	&iio_dev_attr_poke_ev0.dev_attr.attr,
diff --git a/drivers/iio/dummy/iio_simple_dummy.c b/drivers/iio/dummy/iio_simple_dummy.c
index 62052479c349..fcfc38d4bd93 100644
--- a/drivers/iio/dummy/iio_simple_dummy.c
+++ b/drivers/iio/dummy/iio_simple_dummy.c
@@ -599,7 +599,7 @@ static struct iio_sw_device *iio_dummy_probe(const char *name)
 	 * indio_dev->dev.parent = &client->dev;
 	 */
 
-	 /*
+	/*
 	 * Make the iio_dev struct available to remove function.
 	 * Bus equivalents
 	 * i2c_set_clientdata(client, indio_dev);
@@ -690,6 +690,7 @@ static int iio_dummy_remove(struct iio_sw_device *swd)
 
 	return 0;
 }
+
 /**
  * module_iio_sw_device_driver() -  device driver registration
  *
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen
  2018-02-21 14:05 [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen Rodrigo Siqueira
@ 2018-02-21 16:04 ` Daniel Baluta
  2018-02-21 16:15   ` Rodrigo Siqueira
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2018-02-21 16:04 UTC (permalink / raw)
  To: Rodrigo Siqueira
  Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Daniel Baluta, linux-iio,
	kernel-janitors, Linux Kernel Mailing List

On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
<rodrigosiqueiramelo@gmail.com> wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> align the * on each line
> drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> 'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
> drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
> after function/struct/union/enum declarations

You are trying to fix 3 things in one patch here. Please don't do that.

One patch per change please.

thanks,
Daniel.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen
  2018-02-21 16:04 ` Daniel Baluta
@ 2018-02-21 16:15   ` Rodrigo Siqueira
  0 siblings, 0 replies; 3+ messages in thread
From: Rodrigo Siqueira @ 2018-02-21 16:15 UTC (permalink / raw)
  To: Daniel Baluta
  Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Daniel Baluta, linux-iio,
	kernel-janitors, Linux Kernel Mailing List

On 02/21, Daniel Baluta wrote:
> On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
> <rodrigosiqueiramelo@gmail.com> wrote:
> > This patch fixes the following checkpatch.pl warnings:
> >
> > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> > align the * on each line
> > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
> > drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
> > after function/struct/union/enum declarations
> 
> You are trying to fix 3 things in one patch here. Please don't do that.
> 
> One patch per change please.

Even for a simple comment line fix?
 
> thanks,
> Daniel.

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-21 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 14:05 [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen Rodrigo Siqueira
2018-02-21 16:04 ` Daniel Baluta
2018-02-21 16:15   ` Rodrigo Siqueira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).