* [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210
@ 2018-02-22 19:11 ` Krzysztof Kozlowski
2018-02-22 19:11 ` [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410 Krzysztof Kozlowski
2018-02-23 0:30 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Chanwoo Choi
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-02-22 19:11 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Sylwester Nawrocki,
Marek Szyprowski, Marian Mihailescu, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz
Typo in unit address of PPMU ACP caused DTC warnings:
arch/arm/boot/dts/exynos4412-odroidu3.dtb:
Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae0000 simple-bus unit address format error, expected "106e0000"
PPMU ACP (under 0x10ae0000 address) is present only in Exynos4210 so
move this node to exynos4210.dtsi with fixing the reg address to proper
one.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/exynos4.dtsi | 6 ------
arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 967cd02401c5..909a9f2bf5be 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -821,12 +821,6 @@
status = "disabled";
};
- ppmu_acp: ppmu_acp@10ae0000 {
- compatible = "samsung,exynos-ppmu";
- reg = <0x106e0000 0x2000>;
- status = "disabled";
- };
-
ppmu_rightbus: ppmu_rightbus@112a0000 {
compatible = "samsung,exynos-ppmu";
reg = <0x112a0000 0x2000>;
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 853604d91158..88fb47cef9a8 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -162,6 +162,12 @@
iommus = <&sysmmu_g2d>;
};
+ ppmu_acp: ppmu_acp@10ae0000 {
+ compatible = "samsung,exynos-ppmu";
+ reg = <0x10ae0000 0x2000>;
+ status = "disabled";
+ };
+
ppmu_lcd1: ppmu_lcd1@12240000 {
compatible = "samsung,exynos-ppmu";
reg = <0x12240000 0x2000>;
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410
2018-02-22 19:11 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Krzysztof Kozlowski
@ 2018-02-22 19:11 ` Krzysztof Kozlowski
2018-02-23 0:30 ` Chanwoo Choi
2018-02-23 0:30 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Chanwoo Choi
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-02-22 19:11 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Sylwester Nawrocki,
Marek Szyprowski, Marian Mihailescu, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz
Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is
correct) to get rid of DTC warnings like:
arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg):
Node /soc/amba/pdma@12680000 simple-bus unit address format error, expected "121a0000"
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/exynos5410.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
index 1e6b57d013c4..55509c690328 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi
@@ -196,9 +196,9 @@
interrupt-parent = <&gic>;
ranges;
- pdma0: pdma@12680000 {
+ pdma0: pdma@121a0000 {
compatible = "arm,pl330", "arm,primecell";
- reg = <0x121A0000 0x1000>;
+ reg = <0x121a0000 0x1000>;
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_PDMA0>;
clock-names = "apb_pclk";
@@ -207,9 +207,9 @@
#dma-requests = <32>;
};
- pdma1: pdma@12690000 {
+ pdma1: pdma@121b0000 {
compatible = "arm,pl330", "arm,primecell";
- reg = <0x121B0000 0x1000>;
+ reg = <0x121b0000 0x1000>;
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_PDMA1>;
clock-names = "apb_pclk";
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210
2018-02-22 19:11 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Krzysztof Kozlowski
2018-02-22 19:11 ` [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410 Krzysztof Kozlowski
@ 2018-02-23 0:30 ` Chanwoo Choi
2018-02-26 17:04 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2018-02-23 0:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Sylwester Nawrocki,
Marek Szyprowski, Marian Mihailescu, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote:
> Typo in unit address of PPMU ACP caused DTC warnings:
>
> arch/arm/boot/dts/exynos4412-odroidu3.dtb:
> Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae0000 simple-bus unit address format error, expected "106e0000"
>
> PPMU ACP (under 0x10ae0000 address) is present only in Exynos4210 so
> move this node to exynos4210.dtsi with fixing the reg address to proper
> one.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 6 ------
> arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 967cd02401c5..909a9f2bf5be 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -821,12 +821,6 @@
> status = "disabled";
> };
>
> - ppmu_acp: ppmu_acp@10ae0000 {
> - compatible = "samsung,exynos-ppmu";
> - reg = <0x106e0000 0x2000>;
> - status = "disabled";
> - };
> -
> ppmu_rightbus: ppmu_rightbus@112a0000 {
> compatible = "samsung,exynos-ppmu";
> reg = <0x112a0000 0x2000>;
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> index 853604d91158..88fb47cef9a8 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -162,6 +162,12 @@
> iommus = <&sysmmu_g2d>;
> };
>
> + ppmu_acp: ppmu_acp@10ae0000 {
> + compatible = "samsung,exynos-ppmu";
> + reg = <0x10ae0000 0x2000>;
> + status = "disabled";
> + };
> +
> ppmu_lcd1: ppmu_lcd1@12240000 {
> compatible = "samsung,exynos-ppmu";
> reg = <0x12240000 0x2000>;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410
2018-02-22 19:11 ` [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410 Krzysztof Kozlowski
@ 2018-02-23 0:30 ` Chanwoo Choi
0 siblings, 0 replies; 5+ messages in thread
From: Chanwoo Choi @ 2018-02-23 0:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Sylwester Nawrocki,
Marek Szyprowski, Marian Mihailescu, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote:
> Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is
> correct) to get rid of DTC warnings like:
>
> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg):
> Node /soc/amba/pdma@12680000 simple-bus unit address format error, expected "121a0000"
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos5410.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
> index 1e6b57d013c4..55509c690328 100644
> --- a/arch/arm/boot/dts/exynos5410.dtsi
> +++ b/arch/arm/boot/dts/exynos5410.dtsi
> @@ -196,9 +196,9 @@
> interrupt-parent = <&gic>;
> ranges;
>
> - pdma0: pdma@12680000 {
> + pdma0: pdma@121a0000 {
> compatible = "arm,pl330", "arm,primecell";
> - reg = <0x121A0000 0x1000>;
> + reg = <0x121a0000 0x1000>;
> interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clock CLK_PDMA0>;
> clock-names = "apb_pclk";
> @@ -207,9 +207,9 @@
> #dma-requests = <32>;
> };
>
> - pdma1: pdma@12690000 {
> + pdma1: pdma@121b0000 {
> compatible = "arm,pl330", "arm,primecell";
> - reg = <0x121B0000 0x1000>;
> + reg = <0x121b0000 0x1000>;
> interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clock CLK_PDMA1>;
> clock-names = "apb_pclk";
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210
2018-02-23 0:30 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Chanwoo Choi
@ 2018-02-26 17:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-02-26 17:04 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Kukjin Kim, Sylwester Nawrocki, Marek Szyprowski,
Marian Mihailescu, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Bartlomiej Zolnierkiewicz
On Fri, Feb 23, 2018 at 09:30:06AM +0900, Chanwoo Choi wrote:
> On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote:
> > Typo in unit address of PPMU ACP caused DTC warnings:
> >
> > arch/arm/boot/dts/exynos4412-odroidu3.dtb:
> > Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae0000 simple-bus unit address format error, expected "106e0000"
> >
> > PPMU ACP (under 0x10ae0000 address) is present only in Exynos4210 so
> > move this node to exynos4210.dtsi with fixing the reg address to proper
> > one.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > arch/arm/boot/dts/exynos4.dtsi | 6 ------
> > arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index 967cd02401c5..909a9f2bf5be 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -821,12 +821,6 @@
> > status = "disabled";
> > };
> >
> > - ppmu_acp: ppmu_acp@10ae0000 {
> > - compatible = "samsung,exynos-ppmu";
> > - reg = <0x106e0000 0x2000>;
> > - status = "disabled";
> > - };
> > -
> > ppmu_rightbus: ppmu_rightbus@112a0000 {
> > compatible = "samsung,exynos-ppmu";
> > reg = <0x112a0000 0x2000>;
> > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> > index 853604d91158..88fb47cef9a8 100644
> > --- a/arch/arm/boot/dts/exynos4210.dtsi
> > +++ b/arch/arm/boot/dts/exynos4210.dtsi
> > @@ -162,6 +162,12 @@
> > iommus = <&sysmmu_g2d>;
> > };
> >
> > + ppmu_acp: ppmu_acp@10ae0000 {
> > + compatible = "samsung,exynos-ppmu";
> > + reg = <0x10ae0000 0x2000>;
> > + status = "disabled";
> > + };
> > +
> > ppmu_lcd1: ppmu_lcd1@12240000 {
> > compatible = "samsung,exynos-ppmu";
> > reg = <0x12240000 0x2000>;
> >
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks for reviews!
Applied both.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-26 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180222191146epcas2p1e0fc10e3f8b278f0c3671d32e2d76350@epcas2p1.samsung.com>
2018-02-22 19:11 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Krzysztof Kozlowski
2018-02-22 19:11 ` [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410 Krzysztof Kozlowski
2018-02-23 0:30 ` Chanwoo Choi
2018-02-23 0:30 ` [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210 Chanwoo Choi
2018-02-26 17:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).