From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: arkadis@mellanox.com, jiri@mellanox.com, idosch@mellanox.com,
weiyongjun1@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division
Date: Mon, 26 Feb 2018 11:33:23 -0500 (EST) [thread overview]
Message-ID: <20180226.113323.393948046273779787.davem@davemloft.net> (raw)
In-Reply-To: <20180223131540.1065413-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 23 Feb 2018 14:15:31 +0100
> Calculating the number of entries now uses 64-bit arithmetic that
> causes a link error on 32-bit architectures:
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.o: In function `mlxsw_sp_kvdl_init':
> spectrum_kvdl.c:(.text+0x51c): undefined reference to `__aeabi_uldivmod'
>
> We could probably use a 32-bit division here as before, but since this is
> not in a performance critical path, div_u64() seems cleaner here.
>
> Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
prev parent reply other threads:[~2018-02-26 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 13:15 [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division Arnd Bergmann
2018-02-23 13:15 ` [net-next PATCH 2/2] mlxsw: spectrum_kvdl: avoid uninitialized variable warning Arnd Bergmann
2018-02-25 10:04 ` Arkadi Sharshevsky
2018-02-26 16:33 ` David Miller
2018-02-25 10:04 ` [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division Arkadi Sharshevsky
2018-02-26 16:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226.113323.393948046273779787.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arkadis@mellanox.com \
--cc=arnd@arndb.de \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).