From: Arkadi Sharshevsky <arkadis@mellanox.com>
To: Arnd Bergmann <arnd@arndb.de>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Wei Yongjun <weiyongjun1@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division
Date: Sun, 25 Feb 2018 12:04:10 +0200 [thread overview]
Message-ID: <7de58656-c772-c13b-5a35-b6065adc2128@mellanox.com> (raw)
In-Reply-To: <20180223131540.1065413-1-arnd@arndb.de>
On 02/23/2018 03:15 PM, Arnd Bergmann wrote:
> Calculating the number of entries now uses 64-bit arithmetic that
> causes a link error on 32-bit architectures:
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.o: In function `mlxsw_sp_kvdl_init':
> spectrum_kvdl.c:(.text+0x51c): undefined reference to `__aeabi_uldivmod'
>
> We could probably use a 32-bit division here as before, but since this is
> not in a performance critical path, div_u64() seems cleaner here.
>
> Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> index d27fa57ad3c3..6fd701db90c9 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> @@ -278,7 +278,7 @@ static int mlxsw_sp_kvdl_part_init(struct mlxsw_sp *mlxsw_sp,
> resource_size = info->end_index - info->start_index + 1;
> }
>
> - nr_entries = resource_size / info->alloc_size;
> + nr_entries = div_u64(resource_size, info->alloc_size);
> usage_size = BITS_TO_LONGS(nr_entries) * sizeof(unsigned long);
> part = kzalloc(sizeof(*part) + usage_size, GFP_KERNEL);
> if (!part)
>
Acked-by: Arkadi Sharshevsky <arkadis@mellanox.com>
next prev parent reply other threads:[~2018-02-25 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 13:15 [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division Arnd Bergmann
2018-02-23 13:15 ` [net-next PATCH 2/2] mlxsw: spectrum_kvdl: avoid uninitialized variable warning Arnd Bergmann
2018-02-25 10:04 ` Arkadi Sharshevsky
2018-02-26 16:33 ` David Miller
2018-02-25 10:04 ` Arkadi Sharshevsky [this message]
2018-02-26 16:33 ` [net-next PATCH 1/2] mlxsw: spectrum_kvdl: use div_u64() for 64-bit division David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de58656-c772-c13b-5a35-b6065adc2128@mellanox.com \
--to=arkadis@mellanox.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).