linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR
@ 2018-02-27  1:03 Florian Fainelli
  2018-02-27 15:02 ` Jon Mason
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-02-27  1:03 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Florian Fainelli, Rob Herring, Mark Rutland, Russell King,
	Ray Jui, Scott Branden, Jon Mason,
	maintainer:BROADCOM IPROC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Jon attempted to fix the amount of RAM on the BCM958625HR in commit
c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
but it seems like we tripped over some poorly documented schematics.

The top-level page of the schematics says the board has 2GB, but when
you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
what the bootloader really initializes only 512MB, any attempt to use
more than that results in data aborts. Fix this again back to 512MB.

Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/bcm958625hr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
index 6a44b8021702..f0e2008f7490 100644
--- a/arch/arm/boot/dts/bcm958625hr.dts
+++ b/arch/arm/boot/dts/bcm958625hr.dts
@@ -49,7 +49,7 @@
 
 	memory {
 		device_type = "memory";
-		reg = <0x60000000 0x80000000>;
+		reg = <0x60000000 0x20000000>;
 	};
 
 	gpio-restart {
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR
  2018-02-27  1:03 [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR Florian Fainelli
@ 2018-02-27 15:02 ` Jon Mason
  2018-02-28  0:39   ` Florian Fainelli
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2018-02-27 15:02 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: linux-arm-kernel, Rob Herring, Mark Rutland, Russell King,
	Ray Jui, Scott Branden, Jon Mason,
	maintainer:BROADCOM IPROC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Mon, Feb 26, 2018 at 8:03 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> Jon attempted to fix the amount of RAM on the BCM958625HR in commit
> c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
> but it seems like we tripped over some poorly documented schematics.
>
> The top-level page of the schematics says the board has 2GB, but when
> you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
> what the bootloader really initializes only 512MB, any attempt to use
> more than that results in data aborts. Fix this again back to 512MB.
>
> Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Acked-by: Jon Mason <jon.mason@broadcom.com>

> ---
>  arch/arm/boot/dts/bcm958625hr.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index 6a44b8021702..f0e2008f7490 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -49,7 +49,7 @@
>
>         memory {
>                 device_type = "memory";
> -               reg = <0x60000000 0x80000000>;
> +               reg = <0x60000000 0x20000000>;
>         };
>
>         gpio-restart {
> --
> 2.14.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR
  2018-02-27 15:02 ` Jon Mason
@ 2018-02-28  0:39   ` Florian Fainelli
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-02-28  0:39 UTC (permalink / raw)
  To: Jon Mason, Florian Fainelli
  Cc: linux-arm-kernel, Rob Herring, Mark Rutland, Russell King,
	Ray Jui, Scott Branden, Jon Mason,
	maintainer:BROADCOM IPROC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On 02/27/2018 07:02 AM, Jon Mason wrote:
> On Mon, Feb 26, 2018 at 8:03 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> Jon attempted to fix the amount of RAM on the BCM958625HR in commit
>> c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
>> but it seems like we tripped over some poorly documented schematics.
>>
>> The top-level page of the schematics says the board has 2GB, but when
>> you end-up scrolling to page 6, you see two chips of 4GiB (512MB) but
>> what the bootloader really initializes only 512MB, any attempt to use
>> more than that results in data aborts. Fix this again back to 512MB.
>>
>> Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR board")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Acked-by: Jon Mason <jon.mason@broadcom.com>

Applied to devicetree/fixes
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-28  0:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27  1:03 [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR Florian Fainelli
2018-02-27 15:02 ` Jon Mason
2018-02-28  0:39   ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).