* [PATCH] ARM: davinci: fix the GPIO lookup for omapl138-hawk
@ 2018-02-27 12:14 Bartosz Golaszewski
2018-02-28 6:38 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2018-02-27 12:14 UTC (permalink / raw)
To: Sekhar Nori, Kevin Hilman, Russell King
Cc: linux-arm-kernel, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
mmc can correctly lookup the wp and cp gpios.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
index a3e78074be70..62eb7d668890 100644
--- a/arch/arm/mach-davinci/board-omapl138-hawk.c
+++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
@@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = {
.dev_id = "da830-mmc.0",
.table = {
/* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/
- GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW),
- GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW),
+ GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW),
+ GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW),
},
};
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: davinci: fix the GPIO lookup for omapl138-hawk
2018-02-27 12:14 [PATCH] ARM: davinci: fix the GPIO lookup for omapl138-hawk Bartosz Golaszewski
@ 2018-02-28 6:38 ` Sekhar Nori
2018-03-01 10:34 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Sekhar Nori @ 2018-02-28 6:38 UTC (permalink / raw)
To: Bartosz Golaszewski, Kevin Hilman, Russell King
Cc: linux-arm-kernel, linux-kernel, Bartosz Golaszewski
On Tuesday 27 February 2018 05:44 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
> mmc can correctly lookup the wp and cp gpios.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
> index a3e78074be70..62eb7d668890 100644
> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> @@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = {
> .dev_id = "da830-mmc.0",
> .table = {
> /* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/
> - GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW),
> - GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW),
> + GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW),
> + GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW),
Hmm, shouldn't this just be "davinci_gpio" since we use .id = -1 in
da8xx_gpio_device?
Also:
Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc pins")
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: davinci: fix the GPIO lookup for omapl138-hawk
2018-02-28 6:38 ` Sekhar Nori
@ 2018-03-01 10:34 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2018-03-01 10:34 UTC (permalink / raw)
To: Sekhar Nori
Cc: Kevin Hilman, Russell King, Linux ARM, Linux Kernel Mailing List,
Bartosz Golaszewski
2018-02-28 7:38 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Tuesday 27 February 2018 05:44 PM, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>
>> The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
>> mmc can correctly lookup the wp and cp gpios.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> index a3e78074be70..62eb7d668890 100644
>> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> @@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = {
>> .dev_id = "da830-mmc.0",
>> .table = {
>> /* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/
>> - GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW),
>> - GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW),
>> + GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW),
>> + GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW),
>
> Hmm, shouldn't this just be "davinci_gpio" since we use .id = -1 in
> da8xx_gpio_device?
>
The gpio-davinci driver sets the gpiochip label to davinci_gpio.0 and
gpiolib sets the device name to chip's label.
> Also:
>
> Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc pins")
>
> Thanks,
> Sekhar
Sending v2.
Thanks,
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-01 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 12:14 [PATCH] ARM: davinci: fix the GPIO lookup for omapl138-hawk Bartosz Golaszewski
2018-02-28 6:38 ` Sekhar Nori
2018-03-01 10:34 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).