From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions
Date: Wed, 28 Feb 2018 16:55:59 +0100 [thread overview]
Message-ID: <20180228155559.lqm22dzeiptrwyxe@flea> (raw)
In-Reply-To: <1519822318-3974-1-git-send-email-giulio.benetti@micronovasrl.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
Hi,
On Wed, Feb 28, 2018 at 01:51:58PM +0100, Giulio Benetti wrote:
> sun4i_dclk_round_rate is called before sun4i_tcon_mode_set,
> so it finds dclk_min_div and dclk_max_div set to 0 and fails
> adding crtc.
>
> Move dclk_min_div and dclk_max_div to encoders init functions.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
I sent a similar patch there:
https://lists.freedesktop.org/archives/dri-devel/2018-February/166666.html
I guess eventually, we'll want to remove the usage of the clock
framework entirely, but it's not really the scope of a fix.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 12:51 [PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions Giulio Benetti
2018-02-28 15:55 ` Maxime Ripard [this message]
2018-02-28 16:34 ` Giulio Benetti
2018-02-28 18:22 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228155559.lqm22dzeiptrwyxe@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).