From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions
Date: Wed, 28 Feb 2018 19:22:14 +0100 [thread overview]
Message-ID: <83d1a6d8-0816-9f75-34f6-4b93e84393e4@micronovasrl.com> (raw)
In-Reply-To: <ee7bff10-527a-5481-598b-47e1d7a9eeb6@micronovasrl.com>
Hi,
Il 28/02/2018 17:34, Giulio Benetti ha scritto:
> Hi,
>
> Il 28/02/2018 16:55, Maxime Ripard ha scritto:
>> Hi,
>>
>> On Wed, Feb 28, 2018 at 01:51:58PM +0100, Giulio Benetti wrote:
>>> sun4i_dclk_round_rate is called before sun4i_tcon_mode_set,
>>> so it finds dclk_min_div and dclk_max_div set to 0 and fails
>>> adding crtc.
>>>
>>> Move dclk_min_div and dclk_max_div to encoders init functions.
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>
>> I sent a similar patch there:
>> https://lists.freedesktop.org/archives/dri-devel/2018-February/166666.html
>>
>
> I've missed that.
> And where you put it is better, since it's called every time set_mode is
> called.
>
> On lvds instead I don't see anything about this,
> it should have the same potential problem.
> Also I can't understand why it has been set min=7 and max=7 on lvds.
> With those values I would obtain 77Mhz only.
> And I can't find values on datasheet for minimum and maximum.
Submitted patchset for that.
>
>>
>> I guess eventually, we'll want to remove the usage of the clock
>> framework entirely, but it's not really the scope of a fix.
>
> Where would you handle dclk instead of tcon?
Don't mind.
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
>
> Thanks
>
prev parent reply other threads:[~2018-02-28 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 12:51 [PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions Giulio Benetti
2018-02-28 15:55 ` Maxime Ripard
2018-02-28 16:34 ` Giulio Benetti
2018-02-28 18:22 ` Giulio Benetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1a6d8-0816-9f75-34f6-4b93e84393e4@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).