* [PATCH 1/3] staging: fsl-mc: Cleanup dpbp and dpcon API
2018-03-01 17:47 [PATCH 0/3] staging: fsl-mc: Move DPBP and DPCON out of staging Bogdan Purcareata
@ 2018-03-01 17:47 ` Bogdan Purcareata
2018-03-01 17:47 ` [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging Bogdan Purcareata
2018-03-01 17:47 ` [PATCH 3/3] staging: fsl-mc: Move DPCON " Bogdan Purcareata
2 siblings, 0 replies; 6+ messages in thread
From: Bogdan Purcareata @ 2018-03-01 17:47 UTC (permalink / raw)
To: gregkh, laurentiu.tudor, ruxandra.radulescu
Cc: devel, stuyoder, horia.geanta, roy.pledge, ioana.ciornei,
linux-kernel, nipun.gupta, Bogdan Purcareata, linux-arm-kernel
Some functions and associated structures are not used by current code,
so remove them.
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
---
drivers/staging/fsl-mc/bus/dpbp-cmd.h | 10 ------
drivers/staging/fsl-mc/bus/dpbp.c | 67 -----------------------------------
drivers/staging/fsl-mc/include/dpbp.h | 10 ------
3 files changed, 87 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
index 0b7f5c0..3340021 100644
--- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
+++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
@@ -19,28 +19,18 @@
/* Command IDs */
#define DPBP_CMDID_CLOSE DPBP_CMD(0x800)
#define DPBP_CMDID_OPEN DPBP_CMD(0x804)
-#define DPBP_CMDID_GET_API_VERSION DPBP_CMD(0xa04)
#define DPBP_CMDID_ENABLE DPBP_CMD(0x002)
#define DPBP_CMDID_DISABLE DPBP_CMD(0x003)
#define DPBP_CMDID_GET_ATTR DPBP_CMD(0x004)
#define DPBP_CMDID_RESET DPBP_CMD(0x005)
-#define DPBP_CMDID_IS_ENABLED DPBP_CMD(0x006)
struct dpbp_cmd_open {
__le32 dpbp_id;
};
-struct dpbp_cmd_destroy {
- __le32 object_id;
-};
-
#define DPBP_ENABLE 0x1
-struct dpbp_rsp_is_enabled {
- u8 enabled;
-};
-
struct dpbp_rsp_get_attributes {
/* response word 0 */
__le16 pad;
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c
index c0addaa..85735bb 100644
--- a/drivers/staging/fsl-mc/bus/dpbp.c
+++ b/drivers/staging/fsl-mc/bus/dpbp.c
@@ -126,40 +126,6 @@ int dpbp_disable(struct fsl_mc_io *mc_io,
EXPORT_SYMBOL_GPL(dpbp_disable);
/**
- * dpbp_is_enabled() - Check if the DPBP is enabled.
- * @mc_io: Pointer to MC portal's I/O object
- * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
- * @token: Token of DPBP object
- * @en: Returns '1' if object is enabled; '0' otherwise
- *
- * Return: '0' on Success; Error code otherwise.
- */
-int dpbp_is_enabled(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token,
- int *en)
-{
- struct mc_command cmd = { 0 };
- struct dpbp_rsp_is_enabled *rsp_params;
- int err;
- /* prepare command */
- cmd.header = mc_encode_cmd_header(DPBP_CMDID_IS_ENABLED, cmd_flags,
- token);
-
- /* send command to mc*/
- err = mc_send_command(mc_io, &cmd);
- if (err)
- return err;
-
- /* retrieve response parameters */
- rsp_params = (struct dpbp_rsp_is_enabled *)cmd.params;
- *en = rsp_params->enabled & DPBP_ENABLE;
-
- return 0;
-}
-EXPORT_SYMBOL_GPL(dpbp_is_enabled);
-
-/**
* dpbp_reset() - Reset the DPBP, returns the object to initial state.
* @mc_io: Pointer to MC portal's I/O object
* @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
@@ -218,36 +184,3 @@ int dpbp_get_attributes(struct fsl_mc_io *mc_io,
return 0;
}
EXPORT_SYMBOL_GPL(dpbp_get_attributes);
-
-/**
- * dpbp_get_api_version - Get Data Path Buffer Pool API version
- * @mc_io: Pointer to Mc portal's I/O object
- * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
- * @major_ver: Major version of Buffer Pool API
- * @minor_ver: Minor version of Buffer Pool API
- *
- * Return: '0' on Success; Error code otherwise.
- */
-int dpbp_get_api_version(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 *major_ver,
- u16 *minor_ver)
-{
- struct mc_command cmd = { 0 };
- int err;
-
- /* prepare command */
- cmd.header = mc_encode_cmd_header(DPBP_CMDID_GET_API_VERSION,
- cmd_flags, 0);
-
- /* send command to mc */
- err = mc_send_command(mc_io, &cmd);
- if (err)
- return err;
-
- /* retrieve response parameters */
- mc_cmd_read_api_version(&cmd, major_ver, minor_ver);
-
- return 0;
-}
-EXPORT_SYMBOL_GPL(dpbp_get_api_version);
diff --git a/drivers/staging/fsl-mc/include/dpbp.h b/drivers/staging/fsl-mc/include/dpbp.h
index 4a18096..7b9f7ad 100644
--- a/drivers/staging/fsl-mc/include/dpbp.h
+++ b/drivers/staging/fsl-mc/include/dpbp.h
@@ -30,11 +30,6 @@ int dpbp_disable(struct fsl_mc_io *mc_io,
u32 cmd_flags,
u16 token);
-int dpbp_is_enabled(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token,
- int *en);
-
int dpbp_reset(struct fsl_mc_io *mc_io,
u32 cmd_flags,
u16 token);
@@ -55,9 +50,4 @@ int dpbp_get_attributes(struct fsl_mc_io *mc_io,
u16 token,
struct dpbp_attr *attr);
-int dpbp_get_api_version(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 *major_ver,
- u16 *minor_ver);
-
#endif /* __FSL_DPBP_H */
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
2018-03-01 17:47 [PATCH 0/3] staging: fsl-mc: Move DPBP and DPCON out of staging Bogdan Purcareata
2018-03-01 17:47 ` [PATCH 1/3] staging: fsl-mc: Cleanup dpbp and dpcon API Bogdan Purcareata
@ 2018-03-01 17:47 ` Bogdan Purcareata
2018-03-02 9:17 ` Laurentiu Tudor
2018-03-01 17:47 ` [PATCH 3/3] staging: fsl-mc: Move DPCON " Bogdan Purcareata
2 siblings, 1 reply; 6+ messages in thread
From: Bogdan Purcareata @ 2018-03-01 17:47 UTC (permalink / raw)
To: gregkh, laurentiu.tudor, ruxandra.radulescu
Cc: devel, stuyoder, horia.geanta, roy.pledge, ioana.ciornei,
linux-kernel, nipun.gupta, Bogdan Purcareata, linux-arm-kernel
Move the source files out of staging into their final locations:
- dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
- dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
to the other internally used APIs
- dpbp.h gets merged into include/linux/fsl/mc.h, exposing the public
API
Update references in the dpaa2-eth staging driver.
DPBP stands for Data Path Buffer Pool - you can read more about the
object in Documentation/networking/dpaa2/overview.rst
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
---
drivers/bus/fsl-mc/Makefile | 1 +
drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c | 4 +-
drivers/bus/fsl-mc/fsl-mc-private.h | 39 +++++++++++++++++
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +-
drivers/staging/fsl-mc/bus/Makefile | 3 +-
drivers/staging/fsl-mc/bus/dpbp-cmd.h | 44 -------------------
drivers/staging/fsl-mc/include/dpbp.h | 53 -----------------------
include/linux/fsl/mc.h | 42 ++++++++++++++++++
8 files changed, 86 insertions(+), 102 deletions(-)
rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c (98%)
delete mode 100644 drivers/staging/fsl-mc/bus/dpbp-cmd.h
delete mode 100644 drivers/staging/fsl-mc/include/dpbp.h
diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
index 6a97f2c..da26e52 100644
--- a/drivers/bus/fsl-mc/Makefile
+++ b/drivers/bus/fsl-mc/Makefile
@@ -9,6 +9,7 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
mc-bus-driver-objs := fsl-mc-bus.o \
mc-sys.o \
mc-io.o \
+ dpbp.o \
dprc.o \
dprc-driver.o \
fsl-mc-allocator.o \
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/bus/fsl-mc/dpbp.c
similarity index 98%
rename from drivers/staging/fsl-mc/bus/dpbp.c
rename to drivers/bus/fsl-mc/dpbp.c
index 85735bb..31a360b 100644
--- a/drivers/staging/fsl-mc/bus/dpbp.c
+++ b/drivers/bus/fsl-mc/dpbp.c
@@ -5,9 +5,9 @@
*/
#include <linux/kernel.h>
#include <linux/fsl/mc.h>
-#include "../include/dpbp.h"
+#include "linux/fsl/mc.h"
-#include "dpbp-cmd.h"
+#include "fsl-mc-private.h"
/**
* dpbp_open() - Open a control session for the specified object.
diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl-mc-private.h
index bed990c..4ef8d7e 100644
--- a/drivers/bus/fsl-mc/fsl-mc-private.h
+++ b/drivers/bus/fsl-mc/fsl-mc-private.h
@@ -379,6 +379,45 @@ int dprc_get_container_id(struct fsl_mc_io *mc_io,
u32 cmd_flags,
int *container_id);
+/*
+ * Data Path Buffer Pool (DPBP) API
+ */
+
+/* DPBP Version */
+#define DPBP_VER_MAJOR 3
+#define DPBP_VER_MINOR 2
+
+/* Command versioning */
+#define DPBP_CMD_BASE_VERSION 1
+#define DPBP_CMD_ID_OFFSET 4
+
+#define DPBP_CMD(id) (((id) << DPBP_CMD_ID_OFFSET) | DPBP_CMD_BASE_VERSION)
+
+/* Command IDs */
+#define DPBP_CMDID_CLOSE DPBP_CMD(0x800)
+#define DPBP_CMDID_OPEN DPBP_CMD(0x804)
+
+#define DPBP_CMDID_ENABLE DPBP_CMD(0x002)
+#define DPBP_CMDID_DISABLE DPBP_CMD(0x003)
+#define DPBP_CMDID_GET_ATTR DPBP_CMD(0x004)
+#define DPBP_CMDID_RESET DPBP_CMD(0x005)
+
+struct dpbp_cmd_open {
+ __le32 dpbp_id;
+};
+
+#define DPBP_ENABLE 0x1
+
+struct dpbp_rsp_get_attributes {
+ /* response word 0 */
+ __le16 pad;
+ __le16 bpid;
+ __le32 id;
+ /* response word 1 */
+ __le16 version_major;
+ __le16 version_minor;
+};
+
/**
* Maximum number of total IRQs that can be pre-allocated for an MC bus'
* IRQ pool
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
index e577410..ce864ee 100644
--- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
+++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
@@ -35,10 +35,10 @@
#include <linux/netdevice.h>
#include <linux/if_vlan.h>
+#include <linux/fsl/mc.h>
#include "../../fsl-mc/include/dpaa2-io.h"
#include "../../fsl-mc/include/dpaa2-fd.h"
-#include "../../fsl-mc/include/dpbp.h"
#include "../../fsl-mc/include/dpcon.h"
#include "dpni.h"
#include "dpni-cmd.h"
diff --git a/drivers/staging/fsl-mc/bus/Makefile b/drivers/staging/fsl-mc/bus/Makefile
index b67889e..ea6479f 100644
--- a/drivers/staging/fsl-mc/bus/Makefile
+++ b/drivers/staging/fsl-mc/bus/Makefile
@@ -4,8 +4,7 @@
#
# Copyright (C) 2014 Freescale Semiconductor, Inc.
#
-obj-$(CONFIG_FSL_MC_BUS) += dpbp.o \
- dpcon.o
+obj-$(CONFIG_FSL_MC_BUS) += dpcon.o
# MC DPIO driver
obj-$(CONFIG_FSL_MC_DPIO) += dpio/
diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
deleted file mode 100644
index 3340021..0000000
--- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
+++ /dev/null
@@ -1,44 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
-/*
- * Copyright 2013-2016 Freescale Semiconductor Inc.
- *
- */
-#ifndef _FSL_DPBP_CMD_H
-#define _FSL_DPBP_CMD_H
-
-/* DPBP Version */
-#define DPBP_VER_MAJOR 3
-#define DPBP_VER_MINOR 2
-
-/* Command versioning */
-#define DPBP_CMD_BASE_VERSION 1
-#define DPBP_CMD_ID_OFFSET 4
-
-#define DPBP_CMD(id) (((id) << DPBP_CMD_ID_OFFSET) | DPBP_CMD_BASE_VERSION)
-
-/* Command IDs */
-#define DPBP_CMDID_CLOSE DPBP_CMD(0x800)
-#define DPBP_CMDID_OPEN DPBP_CMD(0x804)
-
-#define DPBP_CMDID_ENABLE DPBP_CMD(0x002)
-#define DPBP_CMDID_DISABLE DPBP_CMD(0x003)
-#define DPBP_CMDID_GET_ATTR DPBP_CMD(0x004)
-#define DPBP_CMDID_RESET DPBP_CMD(0x005)
-
-struct dpbp_cmd_open {
- __le32 dpbp_id;
-};
-
-#define DPBP_ENABLE 0x1
-
-struct dpbp_rsp_get_attributes {
- /* response word 0 */
- __le16 pad;
- __le16 bpid;
- __le32 id;
- /* response word 1 */
- __le16 version_major;
- __le16 version_minor;
-};
-
-#endif /* _FSL_DPBP_CMD_H */
diff --git a/drivers/staging/fsl-mc/include/dpbp.h b/drivers/staging/fsl-mc/include/dpbp.h
deleted file mode 100644
index 7b9f7ad..0000000
--- a/drivers/staging/fsl-mc/include/dpbp.h
+++ /dev/null
@@ -1,53 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
-/*
- * Copyright 2013-2016 Freescale Semiconductor Inc.
- *
- */
-#ifndef __FSL_DPBP_H
-#define __FSL_DPBP_H
-
-/*
- * Data Path Buffer Pool API
- * Contains initialization APIs and runtime control APIs for DPBP
- */
-
-struct fsl_mc_io;
-
-int dpbp_open(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- int dpbp_id,
- u16 *token);
-
-int dpbp_close(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpbp_enable(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpbp_disable(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpbp_reset(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-/**
- * struct dpbp_attr - Structure representing DPBP attributes
- * @id: DPBP object ID
- * @bpid: Hardware buffer pool ID; should be used as an argument in
- * acquire/release operations on buffers
- */
-struct dpbp_attr {
- int id;
- u16 bpid;
-};
-
-int dpbp_get_attributes(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token,
- struct dpbp_attr *attr);
-
-#endif /* __FSL_DPBP_H */
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 765ba41..66118e1 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -451,4 +451,46 @@ static inline bool is_fsl_mc_bus_dprtc(const struct fsl_mc_device *mc_dev)
return mc_dev->dev.type == &fsl_mc_bus_dprtc_type;
}
+/*
+ * Data Path Buffer Pool (DPBP) API
+ * Contains initialization APIs and runtime control APIs for DPBP
+ */
+
+int dpbp_open(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ int dpbp_id,
+ u16 *token);
+
+int dpbp_close(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpbp_enable(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpbp_disable(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpbp_reset(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+/**
+ * struct dpbp_attr - Structure representing DPBP attributes
+ * @id: DPBP object ID
+ * @bpid: Hardware buffer pool ID; should be used as an argument in
+ * acquire/release operations on buffers
+ */
+struct dpbp_attr {
+ int id;
+ u16 bpid;
+};
+
+int dpbp_get_attributes(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token,
+ struct dpbp_attr *attr);
+
#endif /* _FSL_MC_H_ */
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
2018-03-01 17:47 ` [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging Bogdan Purcareata
@ 2018-03-02 9:17 ` Laurentiu Tudor
2018-03-02 9:55 ` Bogdan Purcareata
0 siblings, 1 reply; 6+ messages in thread
From: Laurentiu Tudor @ 2018-03-02 9:17 UTC (permalink / raw)
To: Bogdan Purcareata, gregkh, Ruxandra Ioana Ciocoi Radulescu
Cc: devel, stuyoder, Horia Geantă,
Roy Pledge, Ioana Ciornei, linux-kernel, Nipun Gupta,
linux-arm-kernel
Hi Bogdan,
On 03/01/2018 07:47 PM, Bogdan Purcareata wrote:
> Move the source files out of staging into their final locations:
> - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
> - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
> to the other internally used APIs
> - dpbp.h gets merged into include/linux/fsl/mc.h, exposing the public
> API
>
> Update references in the dpaa2-eth staging driver.
>
> DPBP stands for Data Path Buffer Pool - you can read more about the
> object in Documentation/networking/dpaa2/overview.rst
>
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
> ---
> drivers/bus/fsl-mc/Makefile | 1 +
> drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c | 4 +-
> drivers/bus/fsl-mc/fsl-mc-private.h | 39 +++++++++++++++++
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +-
> drivers/staging/fsl-mc/bus/Makefile | 3 +-
> drivers/staging/fsl-mc/bus/dpbp-cmd.h | 44 -------------------
> drivers/staging/fsl-mc/include/dpbp.h | 53 -----------------------
> include/linux/fsl/mc.h | 42 ++++++++++++++++++
> 8 files changed, 86 insertions(+), 102 deletions(-)
> rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c (98%)
> delete mode 100644 drivers/staging/fsl-mc/bus/dpbp-cmd.h
> delete mode 100644 drivers/staging/fsl-mc/include/dpbp.h
>
> diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> index 6a97f2c..da26e52 100644
> --- a/drivers/bus/fsl-mc/Makefile
> +++ b/drivers/bus/fsl-mc/Makefile
> @@ -9,6 +9,7 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
> mc-bus-driver-objs := fsl-mc-bus.o \
> mc-sys.o \
> mc-io.o \
> + dpbp.o \
> dprc.o \
> dprc-driver.o \
> fsl-mc-allocator.o \
> diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/bus/fsl-mc/dpbp.c
> similarity index 98%
> rename from drivers/staging/fsl-mc/bus/dpbp.c
> rename to drivers/bus/fsl-mc/dpbp.c
> index 85735bb..31a360b 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp.c
> +++ b/drivers/bus/fsl-mc/dpbp.c
> @@ -5,9 +5,9 @@
> */
> #include <linux/kernel.h>
> #include <linux/fsl/mc.h>
> -#include "../include/dpbp.h"
> +#include "linux/fsl/mc.h"
I think we can use <> here, same comment for patch 3/3.
Other than that, the series looks ok to me so for all the patches:
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
Best Regards, Laurentiu
> -#include "dpbp-cmd.h"
> +#include "fsl-mc-private.h"
>
> /**
> * dpbp_open() - Open a control session for the specified object.
> diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl-mc-private.h
> index bed990c..4ef8d7e 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-private.h
> +++ b/drivers/bus/fsl-mc/fsl-mc-private.h
> @@ -379,6 +379,45 @@ int dprc_get_container_id(struct fsl_mc_io *mc_io,
> u32 cmd_flags,
> int *container_id);
>
> +/*
> + * Data Path Buffer Pool (DPBP) API
> + */
> +
> +/* DPBP Version */
> +#define DPBP_VER_MAJOR 3
> +#define DPBP_VER_MINOR 2
> +
> +/* Command versioning */
> +#define DPBP_CMD_BASE_VERSION 1
> +#define DPBP_CMD_ID_OFFSET 4
> +
> +#define DPBP_CMD(id) (((id) << DPBP_CMD_ID_OFFSET) | DPBP_CMD_BASE_VERSION)
> +
> +/* Command IDs */
> +#define DPBP_CMDID_CLOSE DPBP_CMD(0x800)
> +#define DPBP_CMDID_OPEN DPBP_CMD(0x804)
> +
> +#define DPBP_CMDID_ENABLE DPBP_CMD(0x002)
> +#define DPBP_CMDID_DISABLE DPBP_CMD(0x003)
> +#define DPBP_CMDID_GET_ATTR DPBP_CMD(0x004)
> +#define DPBP_CMDID_RESET DPBP_CMD(0x005)
> +
> +struct dpbp_cmd_open {
> + __le32 dpbp_id;
> +};
> +
> +#define DPBP_ENABLE 0x1
> +
> +struct dpbp_rsp_get_attributes {
> + /* response word 0 */
> + __le16 pad;
> + __le16 bpid;
> + __le32 id;
> + /* response word 1 */
> + __le16 version_major;
> + __le16 version_minor;
> +};
> +
> /**
> * Maximum number of total IRQs that can be pre-allocated for an MC bus'
> * IRQ pool
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
> index e577410..ce864ee 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
> @@ -35,10 +35,10 @@
>
> #include <linux/netdevice.h>
> #include <linux/if_vlan.h>
> +#include <linux/fsl/mc.h>
>
> #include "../../fsl-mc/include/dpaa2-io.h"
> #include "../../fsl-mc/include/dpaa2-fd.h"
> -#include "../../fsl-mc/include/dpbp.h"
> #include "../../fsl-mc/include/dpcon.h"
> #include "dpni.h"
> #include "dpni-cmd.h"
> diff --git a/drivers/staging/fsl-mc/bus/Makefile b/drivers/staging/fsl-mc/bus/Makefile
> index b67889e..ea6479f 100644
> --- a/drivers/staging/fsl-mc/bus/Makefile
> +++ b/drivers/staging/fsl-mc/bus/Makefile
> @@ -4,8 +4,7 @@
> #
> # Copyright (C) 2014 Freescale Semiconductor, Inc.
> #
> -obj-$(CONFIG_FSL_MC_BUS) += dpbp.o \
> - dpcon.o
> +obj-$(CONFIG_FSL_MC_BUS) += dpcon.o
>
> # MC DPIO driver
> obj-$(CONFIG_FSL_MC_DPIO) += dpio/
> diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> deleted file mode 100644
> index 3340021..0000000
> --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> -/*
> - * Copyright 2013-2016 Freescale Semiconductor Inc.
> - *
> - */
> -#ifndef _FSL_DPBP_CMD_H
> -#define _FSL_DPBP_CMD_H
> -
> -/* DPBP Version */
> -#define DPBP_VER_MAJOR 3
> -#define DPBP_VER_MINOR 2
> -
> -/* Command versioning */
> -#define DPBP_CMD_BASE_VERSION 1
> -#define DPBP_CMD_ID_OFFSET 4
> -
> -#define DPBP_CMD(id) (((id) << DPBP_CMD_ID_OFFSET) | DPBP_CMD_BASE_VERSION)
> -
> -/* Command IDs */
> -#define DPBP_CMDID_CLOSE DPBP_CMD(0x800)
> -#define DPBP_CMDID_OPEN DPBP_CMD(0x804)
> -
> -#define DPBP_CMDID_ENABLE DPBP_CMD(0x002)
> -#define DPBP_CMDID_DISABLE DPBP_CMD(0x003)
> -#define DPBP_CMDID_GET_ATTR DPBP_CMD(0x004)
> -#define DPBP_CMDID_RESET DPBP_CMD(0x005)
> -
> -struct dpbp_cmd_open {
> - __le32 dpbp_id;
> -};
> -
> -#define DPBP_ENABLE 0x1
> -
> -struct dpbp_rsp_get_attributes {
> - /* response word 0 */
> - __le16 pad;
> - __le16 bpid;
> - __le32 id;
> - /* response word 1 */
> - __le16 version_major;
> - __le16 version_minor;
> -};
> -
> -#endif /* _FSL_DPBP_CMD_H */
> diff --git a/drivers/staging/fsl-mc/include/dpbp.h b/drivers/staging/fsl-mc/include/dpbp.h
> deleted file mode 100644
> index 7b9f7ad..0000000
> --- a/drivers/staging/fsl-mc/include/dpbp.h
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> -/*
> - * Copyright 2013-2016 Freescale Semiconductor Inc.
> - *
> - */
> -#ifndef __FSL_DPBP_H
> -#define __FSL_DPBP_H
> -
> -/*
> - * Data Path Buffer Pool API
> - * Contains initialization APIs and runtime control APIs for DPBP
> - */
> -
> -struct fsl_mc_io;
> -
> -int dpbp_open(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - int dpbp_id,
> - u16 *token);
> -
> -int dpbp_close(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - u16 token);
> -
> -int dpbp_enable(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - u16 token);
> -
> -int dpbp_disable(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - u16 token);
> -
> -int dpbp_reset(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - u16 token);
> -
> -/**
> - * struct dpbp_attr - Structure representing DPBP attributes
> - * @id: DPBP object ID
> - * @bpid: Hardware buffer pool ID; should be used as an argument in
> - * acquire/release operations on buffers
> - */
> -struct dpbp_attr {
> - int id;
> - u16 bpid;
> -};
> -
> -int dpbp_get_attributes(struct fsl_mc_io *mc_io,
> - u32 cmd_flags,
> - u16 token,
> - struct dpbp_attr *attr);
> -
> -#endif /* __FSL_DPBP_H */
> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
> index 765ba41..66118e1 100644
> --- a/include/linux/fsl/mc.h
> +++ b/include/linux/fsl/mc.h
> @@ -451,4 +451,46 @@ static inline bool is_fsl_mc_bus_dprtc(const struct fsl_mc_device *mc_dev)
> return mc_dev->dev.type == &fsl_mc_bus_dprtc_type;
> }
>
> +/*
> + * Data Path Buffer Pool (DPBP) API
> + * Contains initialization APIs and runtime control APIs for DPBP
> + */
> +
> +int dpbp_open(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + int dpbp_id,
> + u16 *token);
> +
> +int dpbp_close(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token);
> +
> +int dpbp_enable(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token);
> +
> +int dpbp_disable(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token);
> +
> +int dpbp_reset(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token);
> +
> +/**
> + * struct dpbp_attr - Structure representing DPBP attributes
> + * @id: DPBP object ID
> + * @bpid: Hardware buffer pool ID; should be used as an argument in
> + * acquire/release operations on buffers
> + */
> +struct dpbp_attr {
> + int id;
> + u16 bpid;
> +};
> +
> +int dpbp_get_attributes(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token,
> + struct dpbp_attr *attr);
> +
> #endif /* _FSL_MC_H_ */
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
2018-03-02 9:17 ` Laurentiu Tudor
@ 2018-03-02 9:55 ` Bogdan Purcareata
0 siblings, 0 replies; 6+ messages in thread
From: Bogdan Purcareata @ 2018-03-02 9:55 UTC (permalink / raw)
To: Laurentiu Tudor, gregkh, Ruxandra Ioana Ciocoi Radulescu
Cc: stuyoder, Ioana Ciornei, Nipun Gupta, Roy Pledge,
Horia Geantă,
devel, linux-kernel, linux-arm-kernel
> -----Original Message-----
> From: Laurentiu Tudor
> Sent: Friday, March 02, 2018 11:18 AM
> To: Bogdan Purcareata <bogdan.purcareata@nxp.com>; gregkh@linuxfoundation.org;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: stuyoder@gmail.com; Ioana Ciornei <ioana.ciornei@nxp.com>; Nipun Gupta
> <nipun.gupta@nxp.com>; Roy Pledge <roy.pledge@nxp.com>; Horia Geantă
> <horia.geanta@nxp.com>; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
>
> Hi Bogdan,
>
> On 03/01/2018 07:47 PM, Bogdan Purcareata wrote:
> > Move the source files out of staging into their final locations:
> > - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
> > - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
> > to the other internally used APIs
> > - dpbp.h gets merged into include/linux/fsl/mc.h, exposing the public
> > API
> >
> > Update references in the dpaa2-eth staging driver.
> >
> > DPBP stands for Data Path Buffer Pool - you can read more about the
> > object in Documentation/networking/dpaa2/overview.rst
> >
> > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
> > ---
> > drivers/bus/fsl-mc/Makefile | 1 +
> > drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c | 4 +-
> > drivers/bus/fsl-mc/fsl-mc-private.h | 39 +++++++++++++++++
> > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +-
> > drivers/staging/fsl-mc/bus/Makefile | 3 +-
> > drivers/staging/fsl-mc/bus/dpbp-cmd.h | 44 -------------------
> > drivers/staging/fsl-mc/include/dpbp.h | 53 --------------------
> ---
> > include/linux/fsl/mc.h | 42 ++++++++++++++++++
> > 8 files changed, 86 insertions(+), 102 deletions(-)
> > rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpbp.c (98%)
> > delete mode 100644 drivers/staging/fsl-mc/bus/dpbp-cmd.h
> > delete mode 100644 drivers/staging/fsl-mc/include/dpbp.h
> >
> > diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> > index 6a97f2c..da26e52 100644
> > --- a/drivers/bus/fsl-mc/Makefile
> > +++ b/drivers/bus/fsl-mc/Makefile
> > @@ -9,6 +9,7 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
> > mc-bus-driver-objs := fsl-mc-bus.o \
> > mc-sys.o \
> > mc-io.o \
> > + dpbp.o \
> > dprc.o \
> > dprc-driver.o \
> > fsl-mc-allocator.o \
> > diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/bus/fsl-mc/dpbp.c
> > similarity index 98%
> > rename from drivers/staging/fsl-mc/bus/dpbp.c
> > rename to drivers/bus/fsl-mc/dpbp.c
> > index 85735bb..31a360b 100644
> > --- a/drivers/staging/fsl-mc/bus/dpbp.c
> > +++ b/drivers/bus/fsl-mc/dpbp.c
> > @@ -5,9 +5,9 @@
> > */
> > #include <linux/kernel.h>
> > #include <linux/fsl/mc.h>
> > -#include "../include/dpbp.h"
> > +#include "linux/fsl/mc.h"
>
> I think we can use <> here, same comment for patch 3/3.
>
> Other than that, the series looks ok to me so for all the patches:
>
> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Thank you!
I will update the patchset - seeing that the cleanup one has already been applied - and will send a v2 shortly.
Best regards,
Bogdan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] staging: fsl-mc: Move DPCON out of staging
2018-03-01 17:47 [PATCH 0/3] staging: fsl-mc: Move DPBP and DPCON out of staging Bogdan Purcareata
2018-03-01 17:47 ` [PATCH 1/3] staging: fsl-mc: Cleanup dpbp and dpcon API Bogdan Purcareata
2018-03-01 17:47 ` [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging Bogdan Purcareata
@ 2018-03-01 17:47 ` Bogdan Purcareata
2 siblings, 0 replies; 6+ messages in thread
From: Bogdan Purcareata @ 2018-03-01 17:47 UTC (permalink / raw)
To: gregkh, laurentiu.tudor, ruxandra.radulescu
Cc: devel, stuyoder, horia.geanta, roy.pledge, ioana.ciornei,
linux-kernel, nipun.gupta, Bogdan Purcareata, linux-arm-kernel
Move the source files out of staging into their final locations:
- dpcon.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
- dpcon-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
to the other internally used APIs
- dpcon.h gets merged into include/linux/fsl/mc.h, exposing the public
API
Update references in the dpaa2-eth staging driver.
DPCON stands for Data Path Concentrator - an interface between DPIO
(Data Path IO) and its users (e.g. dpaa2-eth). You can read more about
DPIO in Documentation/networking/dpaa2/overview.rst
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
---
drivers/bus/fsl-mc/Makefile | 1 +
drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpcon.c | 4 +-
drivers/bus/fsl-mc/fsl-mc-private.h | 48 +++++++++++++
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 -
drivers/staging/fsl-mc/bus/Makefile | 1 -
drivers/staging/fsl-mc/bus/dpcon-cmd.h | 53 ---------------
drivers/staging/fsl-mc/include/dpcon.h | 79 ----------------------
include/linux/fsl/mc.h | 66 ++++++++++++++++++
8 files changed, 117 insertions(+), 136 deletions(-)
rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpcon.c (99%)
delete mode 100644 drivers/staging/fsl-mc/bus/dpcon-cmd.h
delete mode 100644 drivers/staging/fsl-mc/include/dpcon.h
diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
index da26e52..3c518c7 100644
--- a/drivers/bus/fsl-mc/Makefile
+++ b/drivers/bus/fsl-mc/Makefile
@@ -10,6 +10,7 @@ mc-bus-driver-objs := fsl-mc-bus.o \
mc-sys.o \
mc-io.o \
dpbp.o \
+ dpcon.o \
dprc.o \
dprc-driver.o \
fsl-mc-allocator.o \
diff --git a/drivers/staging/fsl-mc/bus/dpcon.c b/drivers/bus/fsl-mc/dpcon.c
similarity index 99%
rename from drivers/staging/fsl-mc/bus/dpcon.c
rename to drivers/bus/fsl-mc/dpcon.c
index 021b425..5d220c9 100644
--- a/drivers/staging/fsl-mc/bus/dpcon.c
+++ b/drivers/bus/fsl-mc/dpcon.c
@@ -5,9 +5,9 @@
*/
#include <linux/kernel.h>
#include <linux/fsl/mc.h>
-#include "../include/dpcon.h"
+#include "linux/fsl/mc.h"
-#include "dpcon-cmd.h"
+#include "fsl-mc-private.h"
/**
* dpcon_open() - Open a control session for the specified object
diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl-mc-private.h
index 4ef8d7e..52c069d 100644
--- a/drivers/bus/fsl-mc/fsl-mc-private.h
+++ b/drivers/bus/fsl-mc/fsl-mc-private.h
@@ -418,6 +418,54 @@ struct dpbp_rsp_get_attributes {
__le16 version_minor;
};
+/*
+ * Data Path Concentrator (DPCON) API
+ */
+
+/* DPCON Version */
+#define DPCON_VER_MAJOR 3
+#define DPCON_VER_MINOR 2
+
+/* Command versioning */
+#define DPCON_CMD_BASE_VERSION 1
+#define DPCON_CMD_ID_OFFSET 4
+
+#define DPCON_CMD(id) (((id) << DPCON_CMD_ID_OFFSET) | DPCON_CMD_BASE_VERSION)
+
+/* Command IDs */
+#define DPCON_CMDID_CLOSE DPCON_CMD(0x800)
+#define DPCON_CMDID_OPEN DPCON_CMD(0x808)
+
+#define DPCON_CMDID_ENABLE DPCON_CMD(0x002)
+#define DPCON_CMDID_DISABLE DPCON_CMD(0x003)
+#define DPCON_CMDID_GET_ATTR DPCON_CMD(0x004)
+#define DPCON_CMDID_RESET DPCON_CMD(0x005)
+
+#define DPCON_CMDID_SET_NOTIFICATION DPCON_CMD(0x100)
+
+struct dpcon_cmd_open {
+ __le32 dpcon_id;
+};
+
+#define DPCON_ENABLE 1
+
+struct dpcon_rsp_get_attr {
+ /* response word 0 */
+ __le32 id;
+ __le16 qbman_ch_id;
+ u8 num_priorities;
+ u8 pad;
+};
+
+struct dpcon_cmd_set_notification {
+ /* cmd word 0 */
+ __le32 dpio_id;
+ u8 priority;
+ u8 pad[3];
+ /* cmd word 1 */
+ __le64 user_ctx;
+};
+
/**
* Maximum number of total IRQs that can be pre-allocated for an MC bus'
* IRQ pool
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
index ce864ee..b8990cf 100644
--- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
+++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
@@ -39,7 +39,6 @@
#include "../../fsl-mc/include/dpaa2-io.h"
#include "../../fsl-mc/include/dpaa2-fd.h"
-#include "../../fsl-mc/include/dpcon.h"
#include "dpni.h"
#include "dpni-cmd.h"
diff --git a/drivers/staging/fsl-mc/bus/Makefile b/drivers/staging/fsl-mc/bus/Makefile
index ea6479f..21d8ebc 100644
--- a/drivers/staging/fsl-mc/bus/Makefile
+++ b/drivers/staging/fsl-mc/bus/Makefile
@@ -4,7 +4,6 @@
#
# Copyright (C) 2014 Freescale Semiconductor, Inc.
#
-obj-$(CONFIG_FSL_MC_BUS) += dpcon.o
# MC DPIO driver
obj-$(CONFIG_FSL_MC_DPIO) += dpio/
diff --git a/drivers/staging/fsl-mc/bus/dpcon-cmd.h b/drivers/staging/fsl-mc/bus/dpcon-cmd.h
deleted file mode 100644
index 27fa098..0000000
--- a/drivers/staging/fsl-mc/bus/dpcon-cmd.h
+++ /dev/null
@@ -1,53 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
-/*
- * Copyright 2013-2016 Freescale Semiconductor Inc.
- *
- */
-#ifndef _FSL_DPCON_CMD_H
-#define _FSL_DPCON_CMD_H
-
-/* DPCON Version */
-#define DPCON_VER_MAJOR 3
-#define DPCON_VER_MINOR 2
-
-/* Command versioning */
-#define DPCON_CMD_BASE_VERSION 1
-#define DPCON_CMD_ID_OFFSET 4
-
-#define DPCON_CMD(id) (((id) << DPCON_CMD_ID_OFFSET) | DPCON_CMD_BASE_VERSION)
-
-/* Command IDs */
-#define DPCON_CMDID_CLOSE DPCON_CMD(0x800)
-#define DPCON_CMDID_OPEN DPCON_CMD(0x808)
-
-#define DPCON_CMDID_ENABLE DPCON_CMD(0x002)
-#define DPCON_CMDID_DISABLE DPCON_CMD(0x003)
-#define DPCON_CMDID_GET_ATTR DPCON_CMD(0x004)
-#define DPCON_CMDID_RESET DPCON_CMD(0x005)
-
-#define DPCON_CMDID_SET_NOTIFICATION DPCON_CMD(0x100)
-
-struct dpcon_cmd_open {
- __le32 dpcon_id;
-};
-
-#define DPCON_ENABLE 1
-
-struct dpcon_rsp_get_attr {
- /* response word 0 */
- __le32 id;
- __le16 qbman_ch_id;
- u8 num_priorities;
- u8 pad;
-};
-
-struct dpcon_cmd_set_notification {
- /* cmd word 0 */
- __le32 dpio_id;
- u8 priority;
- u8 pad[3];
- /* cmd word 1 */
- __le64 user_ctx;
-};
-
-#endif /* _FSL_DPCON_CMD_H */
diff --git a/drivers/staging/fsl-mc/include/dpcon.h b/drivers/staging/fsl-mc/include/dpcon.h
deleted file mode 100644
index 062e90a..0000000
--- a/drivers/staging/fsl-mc/include/dpcon.h
+++ /dev/null
@@ -1,79 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
-/*
- * Copyright 2013-2016 Freescale Semiconductor Inc.
- *
- */
-#ifndef __FSL_DPCON_H
-#define __FSL_DPCON_H
-
-/* Data Path Concentrator API
- * Contains initialization APIs and runtime control APIs for DPCON
- */
-
-struct fsl_mc_io;
-
-/** General DPCON macros */
-
-/**
- * Use it to disable notifications; see dpcon_set_notification()
- */
-#define DPCON_INVALID_DPIO_ID (int)(-1)
-
-int dpcon_open(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- int dpcon_id,
- u16 *token);
-
-int dpcon_close(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpcon_enable(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpcon_disable(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-int dpcon_reset(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token);
-
-/**
- * struct dpcon_attr - Structure representing DPCON attributes
- * @id: DPCON object ID
- * @qbman_ch_id: Channel ID to be used by dequeue operation
- * @num_priorities: Number of priorities for the DPCON channel (1-8)
- */
-struct dpcon_attr {
- int id;
- u16 qbman_ch_id;
- u8 num_priorities;
-};
-
-int dpcon_get_attributes(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token,
- struct dpcon_attr *attr);
-
-/**
- * struct dpcon_notification_cfg - Structure representing notification params
- * @dpio_id: DPIO object ID; must be configured with a notification channel;
- * to disable notifications set it to 'DPCON_INVALID_DPIO_ID';
- * @priority: Priority selection within the DPIO channel; valid values
- * are 0-7, depending on the number of priorities in that channel
- * @user_ctx: User context value provided with each CDAN message
- */
-struct dpcon_notification_cfg {
- int dpio_id;
- u8 priority;
- u64 user_ctx;
-};
-
-int dpcon_set_notification(struct fsl_mc_io *mc_io,
- u32 cmd_flags,
- u16 token,
- struct dpcon_notification_cfg *cfg);
-
-#endif /* __FSL_DPCON_H */
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 66118e1..cfb1fbf 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -493,4 +493,70 @@ int dpbp_get_attributes(struct fsl_mc_io *mc_io,
u16 token,
struct dpbp_attr *attr);
+/* Data Path Concentrator (DPCON) API
+ * Contains initialization APIs and runtime control APIs for DPCON
+ */
+
+/**
+ * Use it to disable notifications; see dpcon_set_notification()
+ */
+#define DPCON_INVALID_DPIO_ID (int)(-1)
+
+int dpcon_open(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ int dpcon_id,
+ u16 *token);
+
+int dpcon_close(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpcon_enable(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpcon_disable(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+int dpcon_reset(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token);
+
+/**
+ * struct dpcon_attr - Structure representing DPCON attributes
+ * @id: DPCON object ID
+ * @qbman_ch_id: Channel ID to be used by dequeue operation
+ * @num_priorities: Number of priorities for the DPCON channel (1-8)
+ */
+struct dpcon_attr {
+ int id;
+ u16 qbman_ch_id;
+ u8 num_priorities;
+};
+
+int dpcon_get_attributes(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token,
+ struct dpcon_attr *attr);
+
+/**
+ * struct dpcon_notification_cfg - Structure representing notification params
+ * @dpio_id: DPIO object ID; must be configured with a notification channel;
+ * to disable notifications set it to 'DPCON_INVALID_DPIO_ID';
+ * @priority: Priority selection within the DPIO channel; valid values
+ * are 0-7, depending on the number of priorities in that channel
+ * @user_ctx: User context value provided with each CDAN message
+ */
+struct dpcon_notification_cfg {
+ int dpio_id;
+ u8 priority;
+ u64 user_ctx;
+};
+
+int dpcon_set_notification(struct fsl_mc_io *mc_io,
+ u32 cmd_flags,
+ u16 token,
+ struct dpcon_notification_cfg *cfg);
+
#endif /* _FSL_MC_H_ */
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread