From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Woojung Huh <Woojung.Huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net 3/4] net: dsa: microchip: Utilize strncpy() for ethtool::get_strings
Date: Thu, 1 Mar 2018 16:25:28 -0800 [thread overview]
Message-ID: <20180302002529.15226-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20180302002529.15226-1-f.fainelli@gmail.com>
Do not use memcpy() which is not safe, but instead use strncpy() which
will make sure that the string is NUL terminated (in the Linux
implementation) if the string is smaller than the length specified. This
fixes KASAN out of bounds warnings while fetching port statistics.
Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/microchip/ksz_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 663b0d5b982b..db7f5c8c1dcb 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -449,8 +449,8 @@ static void ksz_get_strings(struct dsa_switch *ds, int port, uint8_t *buf)
int i;
for (i = 0; i < TOTAL_SWITCH_COUNTER_NUM; i++) {
- memcpy(buf + i * ETH_GSTRING_LEN, mib_names[i].string,
- ETH_GSTRING_LEN);
+ strncpy(buf + i * ETH_GSTRING_LEN, mib_names[i].string,
+ ETH_GSTRING_LEN);
}
}
--
2.14.1
next prev parent reply other threads:[~2018-03-02 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 0:25 [PATCH net 0/4] net: dsa: Use strncpy() for ethtool::get_strings Florian Fainelli
2018-03-02 0:25 ` [PATCH net 1/4] net: dsa: b53: " Florian Fainelli
2018-03-02 0:25 ` [PATCH net 2/4] net: dsa: loop: " Florian Fainelli
2018-03-02 0:25 ` Florian Fainelli [this message]
2018-03-02 10:51 ` [PATCH net 3/4] net: dsa: microchip: Utilize " David Laight
2018-03-02 18:24 ` Florian Fainelli
2018-03-02 0:25 ` [PATCH net 4/4] net: dsa: mv88e6xxx: " Florian Fainelli
2018-03-02 3:08 ` Andrew Lunn
2018-03-02 4:21 ` Florian Fainelli
2018-03-02 4:34 ` [PATCH net 0/4] net: dsa: Use " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302002529.15226-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).