linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Woojung Huh <Woojung.Huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 0/4] net: dsa: Use strncpy() for ethtool::get_strings
Date: Thu, 1 Mar 2018 20:34:12 -0800	[thread overview]
Message-ID: <beeb4115-bdf7-176f-2ffb-24ebb5d02daa@gmail.com> (raw)
In-Reply-To: <20180302002529.15226-1-f.fainelli@gmail.com>

Hi David,

On 03/01/2018 04:25 PM, Florian Fainelli wrote:
> Hi all,
> 
> After turning on KASAN on one of my systems, I started getting lots of out of
> bounds errors while fetching a given port's statistics, and indeed using
> memcpy() is unsafe for copying strings, so let's use strncpy() instead.

Looks like only patch 1 is necessary, but there are more drivers with
the same pattern under drivers/net/phy: marvell.c, micrel.c and
bcm-phy-lib.c, so I will submit a v2 with those fixed.

> 
> Florian Fainelli (4):
>   net: dsa: b53: Use strncpy() for ethtool::get_strings
>   net: dsa: loop: Use strncpy() for ethtool::get_strings
>   net: dsa: microchip: Utilize strncpy() for ethtool::get_strings
>   net: dsa: mv88e6xxx: Utilize strncpy() for ethtool::get_strings
> 
>  drivers/net/dsa/b53/b53_common.c       | 4 ++--
>  drivers/net/dsa/dsa_loop.c             | 4 ++--
>  drivers/net/dsa/microchip/ksz_common.c | 4 ++--
>  drivers/net/dsa/mv88e6xxx/chip.c       | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 

-- 
Florian

      parent reply	other threads:[~2018-03-02  4:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  0:25 [PATCH net 0/4] net: dsa: Use strncpy() for ethtool::get_strings Florian Fainelli
2018-03-02  0:25 ` [PATCH net 1/4] net: dsa: b53: " Florian Fainelli
2018-03-02  0:25 ` [PATCH net 2/4] net: dsa: loop: " Florian Fainelli
2018-03-02  0:25 ` [PATCH net 3/4] net: dsa: microchip: Utilize " Florian Fainelli
2018-03-02 10:51   ` David Laight
2018-03-02 18:24     ` Florian Fainelli
2018-03-02  0:25 ` [PATCH net 4/4] net: dsa: mv88e6xxx: " Florian Fainelli
2018-03-02  3:08   ` Andrew Lunn
2018-03-02  4:21     ` Florian Fainelli
2018-03-02  4:34 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=beeb4115-bdf7-176f-2ffb-24ebb5d02daa@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).