From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH v6 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port
Date: Fri, 2 Mar 2018 11:20:56 +0100 [thread overview]
Message-ID: <20180302102057.8917-12-hdegoede@redhat.com> (raw)
In-Reply-To: <20180302102057.8917-1-hdegoede@redhat.com>
We need to add device-connections for the Type-C mux/switch and usb-role
code to be able to find the PI3USB30532 Type-C cross-switch and the
device/host role-switch integrated in the CHT SoC.
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v4:
-Replace Andy's Acked-by with his Reviewed-by
Changes in v2:
-Add Andy's Acked-by
-Add Heikki's Reviewed-by
---
drivers/platform/x86/intel_cht_int33fe.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
index 380ef7ec094f..a3f8674f14da 100644
--- a/drivers/platform/x86/intel_cht_int33fe.c
+++ b/drivers/platform/x86/intel_cht_int33fe.c
@@ -21,6 +21,7 @@
*/
#include <linux/acpi.h>
+#include <linux/connection.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/module.h>
@@ -33,6 +34,8 @@ struct cht_int33fe_data {
struct i2c_client *max17047;
struct i2c_client *fusb302;
struct i2c_client *pi3usb30532;
+ /* Contain a list-head must be per device */
+ struct devcon connections[3];
};
/*
@@ -172,6 +175,20 @@ static int cht_int33fe_probe(struct i2c_client *client)
return -EPROBE_DEFER; /* Wait for i2c-adapter to load */
}
+ data->connections[0].endpoint[0] = "i2c-fusb302";
+ data->connections[0].endpoint[1] = "i2c-pi3usb30532";
+ data->connections[0].id = "typec-switch";
+ data->connections[1].endpoint[0] = "i2c-fusb302";
+ data->connections[1].endpoint[1] = "i2c-pi3usb30532";
+ data->connections[1].id = "typec-mux";
+ data->connections[2].endpoint[0] = "i2c-fusb302";
+ data->connections[2].endpoint[1] = "intel_xhci_usb_sw-role-switch";
+ data->connections[2].id = "usb-role-switch";
+
+ add_device_connection(&data->connections[0]);
+ add_device_connection(&data->connections[1]);
+ add_device_connection(&data->connections[2]);
+
memset(&board_info, 0, sizeof(board_info));
strlcpy(board_info.type, "typec_fusb302", I2C_NAME_SIZE);
board_info.dev_name = "fusb302";
@@ -201,6 +218,10 @@ static int cht_int33fe_probe(struct i2c_client *client)
if (data->max17047)
i2c_unregister_device(data->max17047);
+ remove_device_connection(&data->connections[2]);
+ remove_device_connection(&data->connections[1]);
+ remove_device_connection(&data->connections[0]);
+
return -EPROBE_DEFER; /* Wait for the i2c-adapter to load */
}
@@ -213,6 +234,10 @@ static int cht_int33fe_remove(struct i2c_client *i2c)
if (data->max17047)
i2c_unregister_device(data->max17047);
+ remove_device_connection(&data->connections[2]);
+ remove_device_connection(&data->connections[1]);
+ remove_device_connection(&data->connections[0]);
+
return 0;
}
--
2.14.3
next prev parent reply other threads:[~2018-03-02 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 10:20 [PATCH v6 00/12] USB Type-C device-connection, mux and switch support Hans de Goede
2018-03-02 10:20 ` [PATCH v6 01/12] drivers: base: Unified device connection lookup Hans de Goede
2018-03-09 17:53 ` Greg Kroah-Hartman
2018-03-11 18:24 ` Hans de Goede
2018-03-12 8:13 ` Heikki Krogerus
2018-03-12 9:19 ` Hans de Goede
2018-03-12 9:24 ` Heikki Krogerus
2018-03-02 10:20 ` [PATCH v6 02/12] usb: typec: Start using ERR_PTR Hans de Goede
2018-03-02 10:20 ` [PATCH v6 03/12] usb: typec: API for controlling USB Type-C Multiplexers Hans de Goede
2018-03-02 10:20 ` [PATCH v6 04/12] usb: common: Small class for USB role switches Hans de Goede
2018-03-02 10:20 ` [PATCH v6 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such Hans de Goede
2018-03-02 10:20 ` [PATCH v6 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions Hans de Goede
2018-03-02 10:20 ` [PATCH v6 07/12] xhci: Add option to get next extended capability in list by passing id = 0 Hans de Goede
2018-03-02 10:20 ` [PATCH v6 08/12] xhci: Add Intel extended cap / otg phy mux handling Hans de Goede
2018-03-02 10:20 ` [PATCH v6 09/12] usb: roles: Add Intel xHCI USB role switch driver Hans de Goede
2018-03-02 10:20 ` [PATCH v6 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch Hans de Goede
2018-03-02 10:20 ` Hans de Goede [this message]
2018-03-02 10:20 ` [PATCH v6 12/12] extcon: axp288: Set USB role where necessary Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302102057.8917-12-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).