From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup
Date: Mon, 12 Mar 2018 10:13:45 +0200 [thread overview]
Message-ID: <20180312081345.GH21904@kuha.fi.intel.com> (raw)
In-Reply-To: <bddcf7ea-e58c-637a-e546-9978fd2cb540@redhat.com>
On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote:
> Hi all,
>
> On 09-03-18 18:53, Greg Kroah-Hartman wrote:
> > On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote:
> > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > >
> > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain
> > > lookup tables for describing connections and provide custom
> > > API for handling them. This introduces a single generic
> > > lookup table and API for the connections.
> > >
> > > The motivation for this commit is centralizing the
> > > connection lookup, but the goal is to ultimately extract the
> > > connection descriptions also from firmware by using the
> > > fwnode_graph_* functions and other mechanisms that are
> > > available.
> > >
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Sorry for the delay, just now reviewing this patch...
> >
> > The content is fine (if not scary for the obvious reason of passing
> > around 'struct device' of different bus types, but ok...), but the api
> > naming is "rough":
>
> Heikki, I think it is best if you answer Greg's remarks. FWIW I'm
> fine with the changes Greg proposes.
Me too.
> I currently have significantly less bandwidth for this due to
> personal circumstances, so if a new version of this patch-set
> is necessary it would be great if you (Heikki) can do a v7.
Sure thing. I'll prepare the v7.
Thanks,
--
heikki
next prev parent reply other threads:[~2018-03-12 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 10:20 [PATCH v6 00/12] USB Type-C device-connection, mux and switch support Hans de Goede
2018-03-02 10:20 ` [PATCH v6 01/12] drivers: base: Unified device connection lookup Hans de Goede
2018-03-09 17:53 ` Greg Kroah-Hartman
2018-03-11 18:24 ` Hans de Goede
2018-03-12 8:13 ` Heikki Krogerus [this message]
2018-03-12 9:19 ` Hans de Goede
2018-03-12 9:24 ` Heikki Krogerus
2018-03-02 10:20 ` [PATCH v6 02/12] usb: typec: Start using ERR_PTR Hans de Goede
2018-03-02 10:20 ` [PATCH v6 03/12] usb: typec: API for controlling USB Type-C Multiplexers Hans de Goede
2018-03-02 10:20 ` [PATCH v6 04/12] usb: common: Small class for USB role switches Hans de Goede
2018-03-02 10:20 ` [PATCH v6 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such Hans de Goede
2018-03-02 10:20 ` [PATCH v6 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions Hans de Goede
2018-03-02 10:20 ` [PATCH v6 07/12] xhci: Add option to get next extended capability in list by passing id = 0 Hans de Goede
2018-03-02 10:20 ` [PATCH v6 08/12] xhci: Add Intel extended cap / otg phy mux handling Hans de Goede
2018-03-02 10:20 ` [PATCH v6 09/12] usb: roles: Add Intel xHCI USB role switch driver Hans de Goede
2018-03-02 10:20 ` [PATCH v6 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch Hans de Goede
2018-03-02 10:20 ` [PATCH v6 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port Hans de Goede
2018-03-02 10:20 ` [PATCH v6 12/12] extcon: axp288: Set USB role where necessary Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312081345.GH21904@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andy@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).