* [PATCH net-next] net: phy: mdio-mux: slience probe defer error
@ 2018-03-06 11:10 Jerome Brunet
2018-03-06 12:48 ` Andrew Lunn
2018-03-07 17:40 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jerome Brunet @ 2018-03-06 11:10 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli
Cc: Jerome Brunet, netdev, linux-kernel, linux-amlogic
If we fail to register the mdio bus due to probe defer, we should not
print an error message. Just be silent in this case.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/net/phy/mdio-mux-mmioreg.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
index 2573ab012f16..70f6115530af 100644
--- a/drivers/net/phy/mdio-mux-mmioreg.c
+++ b/drivers/net/phy/mdio-mux-mmioreg.c
@@ -163,8 +163,9 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev)
mdio_mux_mmioreg_switch_fn,
&s->mux_handle, s, NULL);
if (ret) {
- dev_err(&pdev->dev, "failed to register mdio-mux bus %pOF\n",
- np);
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev,
+ "failed to register mdio-mux bus %pOF\n", np);
return ret;
}
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: mdio-mux: slience probe defer error
2018-03-06 11:10 [PATCH net-next] net: phy: mdio-mux: slience probe defer error Jerome Brunet
@ 2018-03-06 12:48 ` Andrew Lunn
2018-03-07 17:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-03-06 12:48 UTC (permalink / raw)
To: Jerome Brunet; +Cc: Florian Fainelli, netdev, linux-kernel, linux-amlogic
On Tue, Mar 06, 2018 at 12:10:45PM +0100, Jerome Brunet wrote:
> If we fail to register the mdio bus due to probe defer, we should not
> print an error message. Just be silent in this case.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: mdio-mux: slience probe defer error
2018-03-06 11:10 [PATCH net-next] net: phy: mdio-mux: slience probe defer error Jerome Brunet
2018-03-06 12:48 ` Andrew Lunn
@ 2018-03-07 17:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-07 17:40 UTC (permalink / raw)
To: jbrunet; +Cc: andrew, f.fainelli, netdev, linux-kernel, linux-amlogic
From: Jerome Brunet <jbrunet@baylibre.com>
Date: Tue, 6 Mar 2018 12:10:45 +0100
> If we fail to register the mdio bus due to probe defer, we should not
> print an error message. Just be silent in this case.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied, thanks Jerome.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 11:10 [PATCH net-next] net: phy: mdio-mux: slience probe defer error Jerome Brunet
2018-03-06 12:48 ` Andrew Lunn
2018-03-07 17:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).