* [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string
@ 2018-03-12 16:07 Craig Tatlor
2018-03-12 16:45 ` Bjorn Andersson
2018-03-13 16:46 ` [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node Craig Tatlor
0 siblings, 2 replies; 4+ messages in thread
From: Craig Tatlor @ 2018-03-12 16:07 UTC (permalink / raw)
Cc: ctatlor97, Andy Gross, David Brown, Rob Herring, Mark Rutland,
Russell King, linux-arm-msm, linux-soc, devicetree,
linux-arm-kernel, linux-kernel
This was mistakenly pulled from the downstream tree.
Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
index e87f2c99060d..d85311a0422c 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
@@ -491,7 +491,7 @@
pinctrl-0 = <&i2c8_pins>;
synaptics@2c {
- compatible = "syna,rmi-i2c";
+ compatible = "syna,rmi4-i2c";
reg = <0x2c>;
interrupt-parent = <&msmgpio>;
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string
2018-03-12 16:07 [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string Craig Tatlor
@ 2018-03-12 16:45 ` Bjorn Andersson
2018-03-13 16:46 ` [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node Craig Tatlor
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-03-12 16:45 UTC (permalink / raw)
To: Craig Tatlor
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland, Russell King,
linux-arm-msm, linux-soc, devicetree, linux-arm-kernel,
linux-kernel
On Mon 12 Mar 09:07 PDT 2018, Craig Tatlor wrote:
> This was mistakenly pulled from the downstream tree.
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
Thanks Craig,
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> index e87f2c99060d..d85311a0422c 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> @@ -491,7 +491,7 @@
> pinctrl-0 = <&i2c8_pins>;
>
> synaptics@2c {
> - compatible = "syna,rmi-i2c";
> + compatible = "syna,rmi4-i2c";
> reg = <0x2c>;
>
> interrupt-parent = <&msmgpio>;
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node
2018-03-12 16:07 [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string Craig Tatlor
2018-03-12 16:45 ` Bjorn Andersson
@ 2018-03-13 16:46 ` Craig Tatlor
2018-03-15 5:21 ` Andy Gross
1 sibling, 1 reply; 4+ messages in thread
From: Craig Tatlor @ 2018-03-13 16:46 UTC (permalink / raw)
Cc: ctatlor97, Andy Gross, David Brown, Rob Herring, Mark Rutland,
Russell King, linux-arm-msm, linux-soc, devicetree,
linux-arm-kernel, linux-kernel
The compatible string was mistakenly pulled from the downstream tree and the
startup delay property is needed to prevent io errors on initial page select.
Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
index e87f2c99060d..701b396719c7 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
@@ -491,7 +491,7 @@
pinctrl-0 = <&i2c8_pins>;
synaptics@2c {
- compatible = "syna,rmi-i2c";
+ compatible = "syna,rmi4-i2c";
reg = <0x2c>;
interrupt-parent = <&msmgpio>;
@@ -506,6 +506,8 @@
pinctrl-names = "default";
pinctrl-0 = <&ts_int_pin>;
+ syna,startup-delay-ms = <10>;
+
rmi-f01@1 {
reg = <0x1>;
syna,nosleep = <1>;
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node
2018-03-13 16:46 ` [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node Craig Tatlor
@ 2018-03-15 5:21 ` Andy Gross
0 siblings, 0 replies; 4+ messages in thread
From: Andy Gross @ 2018-03-15 5:21 UTC (permalink / raw)
To: Craig Tatlor
Cc: David Brown, Rob Herring, Mark Rutland, Russell King,
linux-arm-msm, linux-soc, devicetree, linux-arm-kernel,
linux-kernel
On Tue, Mar 13, 2018 at 04:46:38PM +0000, Craig Tatlor wrote:
> The compatible string was mistakenly pulled from the downstream tree and the
> startup delay property is needed to prevent io errors on initial page select.
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
Thanks for the patch. I'll add Bjorn's reviewed-by and apply it.
Regards,
Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-15 5:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 16:07 [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string Craig Tatlor
2018-03-12 16:45 ` Bjorn Andersson
2018-03-13 16:46 ` [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node Craig Tatlor
2018-03-15 5:21 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).