From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Harald Geyer <harald@ccbib.org>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Icenowy Zheng <icenowy@aosc.io>,
info@olimex.com
Subject: Re: [PATCH 4/5] arm64: dts: allwinner: a64: Add pwm device
Date: Tue, 13 Mar 2018 09:29:09 +0100 [thread overview]
Message-ID: <20180313082909.236etgyrtkr3o432@flea> (raw)
In-Reply-To: <20180312161050.7647-5-harald@ccbib.org>
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
On Mon, Mar 12, 2018 at 04:10:49PM +0000, Harald Geyer wrote:
> This device is compatible with A13, so no new driver is needed.
>
> Signed-off-by: Harald Geyer <harald@ccbib.org>
> ---
> I saw that Andre Przywara has been working on A64 pwm too and has
> submitted some patches a few days ago. I think his patches are functionally
> equivalent to this one here, but clean up things a bit and thus are
> preferable. See:
>
> https://groups.google.com/forum/#!topic/linux-sunxi/hQFeteP591k
>
> I'm including my patch here mostly to have a consistent series for others
> to test. OTOH you might merge the device tree changes here and pick up
> the cleanup patches from him. Either way should work fine.
>
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 05d5e8def68a..95d52f6aa07f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -364,6 +364,11 @@
> bias-pull-up;
> };
>
> + pwm_pin: pwm_pin {
> + pins = "PD22";
> + function = "pwm";
> + };
> +
> rmii_pins: rmii_pins {
> pins = "PD10", "PD11", "PD13", "PD14", "PD17",
> "PD18", "PD19", "PD20", "PD22", "PD23";
> @@ -629,6 +634,14 @@
> #interrupt-cells = <3>;
> };
>
> + pwm: pwm@1c21400 {
> + compatible = "allwinner,sun5i-a13-pwm";
Just like for the watchdog, you should have an A64 compatible there.
> + reg = <0x01c21400 0x8>;
And you should use the full memory range here.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-13 8:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 16:10 arm64: allwinner: Add support for TERES I laptop Harald Geyer
2018-03-12 16:10 ` [PATCH 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer
2018-03-13 1:35 ` André Przywara
2018-03-13 8:46 ` Harald Geyer
2018-03-13 15:27 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer
2018-03-13 1:39 ` André Przywara
2018-03-13 10:03 ` Harald Geyer
2018-03-12 16:10 ` [PATCH 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer
2018-03-13 8:27 ` Maxime Ripard
2018-03-13 9:18 ` Harald Geyer
2018-03-13 15:35 ` Maxime Ripard
2018-03-13 16:51 ` Harald Geyer
2018-03-14 8:01 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer
2018-03-13 8:29 ` Maxime Ripard [this message]
2018-03-12 16:10 ` [PATCH 5/5] arm64: allwinner: a64: Add support for TERES I laptop Harald Geyer
2018-03-13 8:41 ` Maxime Ripard
2018-03-13 11:07 ` Harald Geyer
2018-03-13 15:41 ` Maxime Ripard
2018-03-15 17:06 ` arm64: allwinner: " afzal mohammed
2018-03-16 6:28 ` afzal mohammed
2018-03-16 9:30 ` Harald Geyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313082909.236etgyrtkr3o432@flea \
--to=maxime.ripard@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=harald@ccbib.org \
--cc=icenowy@aosc.io \
--cc=info@olimex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).