From: Harald Geyer <harald@ccbib.org>
To: "André Przywara" <andre.przywara@arm.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <icenowy@aosc.io>,
info@olimex.com
Subject: Re: [PATCH 2/5] arm64: dts: allwinner: a64: Add watchdog
Date: Tue, 13 Mar 2018 11:03:33 +0100 [thread overview]
Message-ID: <E1evgmL-0000KW-JP@stardust.g4.wien.funkfeuer.at> (raw)
In-Reply-To: <29bb31fc-dd3d-e9c5-c78e-f8e80f7a95fa@arm.com>
Hi,
André Przywara writes:
> On 12/03/18 16:10, Harald Geyer wrote:
> > Add a watchdog node for the A64, automatically enabled on all boards.
> > Tested on Olimex Teres I.
> >
> > Signed-off-by: Harald Geyer <harald@ccbib.org>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index 64e452a758fa..ca1b365bc722 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -665,5 +665,11 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
> > };
> > +
> > + wdt0: watchdog@1c20ca0 {
> > + compatible = "allwinner,sun6i-a31-wdt";
>
> Please use the recommended way, adding a specific compatible first:
>
> compatible = "allwinner,sun50i-a64-wdt",
> "allwinner,sun6i-a31-wdt";
I tried to follow the style most commonly used in the rest of the file,
but I can add the new string to the binding documentation and use it here.
> The rest looks correct.
>
> I am just a bit puzzled what's the use of a watchdog on a laptop?
I guess the same as the watchdog on my x86 PC - debugging/testing software
using watchdogs. ;)
> I
> would expect it being more used in embedded systems? Or is that patch
> here actually independent from the Teres I?
Yes, I could have sent it as independent patch, but I figured merging
is easier if there aren't independent patches touching the same file at
the same time.
I mostly added support for the watchdog because it was listed in the
wiki as untested and it cost me virtually no time to run a few tests while
working on the teres.
Thanks,
Harald
> Cheers,
> Andre.
>
> > + reg = <0x01c20ca0 0x20>;
> > + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > };
> > };
> >
>
--
If you want to support my work:
see http://friends.ccbib.org/harald/supporting/
or donate via CLAM to xASPBtezLNqj4cUe8MT5nZjthRSEjrRQXN
or via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w
next prev parent reply other threads:[~2018-03-13 10:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 16:10 arm64: allwinner: Add support for TERES I laptop Harald Geyer
2018-03-12 16:10 ` [PATCH 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer
2018-03-13 1:35 ` André Przywara
2018-03-13 8:46 ` Harald Geyer
2018-03-13 15:27 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer
2018-03-13 1:39 ` André Przywara
2018-03-13 10:03 ` Harald Geyer [this message]
2018-03-12 16:10 ` [PATCH 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer
2018-03-13 8:27 ` Maxime Ripard
2018-03-13 9:18 ` Harald Geyer
2018-03-13 15:35 ` Maxime Ripard
2018-03-13 16:51 ` Harald Geyer
2018-03-14 8:01 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer
2018-03-13 8:29 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 5/5] arm64: allwinner: a64: Add support for TERES I laptop Harald Geyer
2018-03-13 8:41 ` Maxime Ripard
2018-03-13 11:07 ` Harald Geyer
2018-03-13 15:41 ` Maxime Ripard
2018-03-15 17:06 ` arm64: allwinner: " afzal mohammed
2018-03-16 6:28 ` afzal mohammed
2018-03-16 9:30 ` Harald Geyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1evgmL-0000KW-JP@stardust.g4.wien.funkfeuer.at \
--to=harald@ccbib.org \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=info@olimex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).