From: Scott Bauer <scott.bauer@intel.com>
To: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Cc: Jonathan Derrick <jonathan.derrick@intel.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] block: sed-opal: unify cmd start and finalize
Date: Tue, 13 Mar 2018 09:01:02 -0600 [thread overview]
Message-ID: <20180313150102.g47bzsqyy2ueazqu@sbauer-Z170X-UD5> (raw)
In-Reply-To: <0d64b284cd6e78d61b1c8ef5a49ae13bd4b1dfee.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de>
On Tue, Mar 13, 2018 at 02:08:56PM +0100, Jonas Rabenstein wrote:
> Every step starts with resetting the cmd buffer as well as the comid and
> constructs the appropriate OPAL_CALL command. Consequently, those
> actions may be combined into one generic function.
>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> ---
> block/sed-opal.c | 243 +++++++++++++++----------------------------------------
> 1 file changed, 63 insertions(+), 180 deletions(-)
>
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index a228a13f0a08..22dbea7cf4d1 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -659,6 +659,7 @@ static int cmd_finalize(struct opal_dev *cmd, u32 hsn, u32 tsn)
> struct opal_header *hdr;
> int err = 0;
>
> + add_token_u8(&err, cmd, OPAL_ENDLIST);
> add_token_u8(&err, cmd, OPAL_ENDOFDATA);
> add_token_u8(&err, cmd, OPAL_STARTLIST);
> add_token_u8(&err, cmd, 0);
> @@ -1001,6 +1002,21 @@ static void clear_opal_cmd(struct opal_dev *dev)
> memset(dev->cmd, 0, IO_BUFFER_LENGTH);
> }
>
> +static int start_opal_cmd(struct opal_dev *dev, const u8 *uid, const u8 *method)
> +{
> + int err = 0;
> +
> + clear_opal_cmd(dev);
> + set_comid(dev, dev->comid);
> +
> + add_token_u8(&err, dev, OPAL_CALL);
> + add_token_bytestring(&err, dev, uid, OPAL_UID_LENGTH);
> + add_token_bytestring(&err, dev, method, OPAL_METHOD_LENGTH);
> + add_token_u8(&err, dev, OPAL_STARTLIST);
Can you resend this patch (in a bit I'm revewing the rest) with a comment here and
in cmd_finalize explaining that the start_list here gets terminiated by the new
opal_endlist in cmd_finalize.
I'm not a huge fan of having the start/list and end/list in separate functions
since those are used to specify a parameter list for a opal method. I can get over it
since it cleans the code up, as long as there are comments on both sides reminding me
what they're opening/closing off.
next prev parent reply other threads:[~2018-03-13 15:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 13:08 [PATCH 0/8] block: sed-opal: support write to shadow mbr Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 1/8] block: sed-opal: use correct macro for method length Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 2/8] block: sed-opal: unify space check in add_token_* Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 3/8] block: sed-opal: unify cmd start and finalize Jonas Rabenstein
2018-03-13 15:01 ` Scott Bauer [this message]
2018-03-14 6:26 ` [PATCH v2 " Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 4/8] block: sed-opal: unify error handling of responses Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 5/8] block: sed-opal: print failed function address Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 6/8] block: sed-opal: split generation of bytestring header and content Jonas Rabenstein
2018-03-13 13:09 ` [PATCH 7/8] block: sed-opal: add ioctl for done-mark of shadow mbr Jonas Rabenstein
2018-03-13 13:09 ` [PATCH 8/8] block: sed-opal: ioctl for writing to " Jonas Rabenstein
2018-03-13 15:44 ` Scott Bauer
2018-03-14 6:15 ` [PATCH v2 8.0/8.4] block: sed-opal: check size of " Jonas Rabenstein
2018-03-14 6:15 ` [PATCH v2 8.1/8.4] block: sed-opal: ioctl for writing to " Jonas Rabenstein
2018-03-14 6:15 ` [PATCH v2 8.2/8.4] block: sed-opal: unify retrieval of table columns Jonas Rabenstein
2018-03-14 6:15 ` [PATCH v2 8.3/8.4] block: sed-opal: get metadata about opal-sed tables Jonas Rabenstein
2018-03-14 6:15 ` [PATCH v2 8.4/8.4] block: sed-opal: check size of shadow mbr Jonas Rabenstein
2018-03-14 19:39 ` [PATCH 8/8] block: sed-opal: ioctl for writing to " kbuild test robot
2018-03-13 15:53 ` [PATCH 0/8] block: sed-opal: support write " Scott Bauer
2018-03-19 18:36 ` [PATCH v2 00/11] block: sed-opal " Jonas Rabenstein
2018-03-19 19:53 ` Christoph Hellwig
2018-03-19 19:33 ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 01/11] block: sed-opal: use correct macro for method length Jonas Rabenstein
2018-03-19 19:53 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 02/11] block: sed-opal: unify space check in add_token_* Jonas Rabenstein
2018-03-19 19:54 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 03/11] block: sed-opal: unify cmd start and finalize Jonas Rabenstein
2018-03-19 19:57 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 04/11] block: sed-opal: unify error handling of responses Jonas Rabenstein
2018-03-19 19:58 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 05/11] block: sed-opal: print failed function address Jonas Rabenstein
2018-03-19 19:58 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 06/11] block: sed-opal: split generation of bytestring header and content Jonas Rabenstein
2018-03-19 19:59 ` Christoph Hellwig
2018-03-19 19:41 ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 07/11] block: sed-opal: add ioctl for done-mark of shadow mbr Jonas Rabenstein
2018-03-19 20:00 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 08/11] block: sed-opal: ioctl for writing to " Jonas Rabenstein
2018-03-19 19:52 ` Christoph Hellwig
2018-03-20 9:36 ` Jonas Rabenstein
2018-03-20 22:09 ` Scott Bauer
2018-03-21 1:43 ` Jonas Rabenstein
2018-03-29 17:30 ` Jonas Rabenstein
2018-03-29 17:16 ` Scott Bauer
2018-03-29 18:27 ` catchall
2018-04-05 20:34 ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 09/11] block: sed-opal: unify retrieval of table columns Jonas Rabenstein
2018-03-19 18:36 ` [PATCH v2 10/11] block: sed-opal: get metadata about opal-sed tables Jonas Rabenstein
2018-03-19 20:01 ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 11/11] block: sed-opal: check size of shadow mbr Jonas Rabenstein
2018-03-19 20:01 ` Christoph Hellwig
2018-03-20 10:02 ` Jonas Rabenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313150102.g47bzsqyy2ueazqu@sbauer-Z170X-UD5 \
--to=scott.bauer@intel.com \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).