linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
To: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>,
	Scott Bauer <scott.bauer@intel.com>,
	Jonathan Derrick <jonathan.derrick@intel.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 8/8] block: sed-opal: ioctl for writing to shadow mbr
Date: Tue, 13 Mar 2018 14:09:01 +0100	[thread overview]
Message-ID: <b0b34fc0132312c09629c868d33b74fe5a19854e.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de> (raw)
In-Reply-To: <cover.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de>
In-Reply-To: <cover.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de>

Allow modification of the shadow mbr. If the shadow mbr is not marked as
done, this data will be presented read only as the device content. Only
after marking the shadow mbr as done and unlocking a locking range the
actual content is accessible.

Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
---
 block/sed-opal.c              | 74 +++++++++++++++++++++++++++++++++++++++++++
 include/linux/sed-opal.h      |  1 +
 include/uapi/linux/sed-opal.h |  8 +++++
 3 files changed, 83 insertions(+)

diff --git a/block/sed-opal.c b/block/sed-opal.c
index b201c96d23a3..1ec3734af656 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -1491,6 +1491,52 @@ static int set_mbr_enable_disable(struct opal_dev *dev, void *data)
 	return finalize_and_send(dev, parse_and_check_status);
 }
 
+static int write_shadow_mbr(struct opal_dev *dev, void *data)
+{
+	struct opal_shadow_mbr *shadow = data;
+	size_t off;
+	u64 len;
+	int err = 0;
+	u8 *payload;
+
+	/* FIXME: this is the maximum we can use for IO_BUFFER_LENGTH=2048.
+	 *        Instead of having constant, it would be nice to compute the
+	 *        actual value depending on IO_BUFFER_LENGTH
+	 */
+	len = 1950;
+
+	/* do the actual transmission(s) */
+	for (off = 0 ; off < shadow->size; off += len) {
+		len = min(len, shadow->size - off);
+
+		pr_debug("MBR: write bytes %zu+%llu/%llu\n",
+			 off, len, shadow->size);
+		err = start_opal_cmd(dev, opaluid[OPAL_MBR],
+				     opalmethod[OPAL_SET]);
+		add_token_u8(&err, dev, OPAL_STARTNAME);
+		add_token_u8(&err, dev, OPAL_WHERE);
+		add_token_u64(&err, dev, shadow->offset + off);
+		add_token_u8(&err, dev, OPAL_ENDNAME);
+
+		add_token_u8(&err, dev, OPAL_STARTNAME);
+		add_token_u8(&err, dev, OPAL_VALUES);
+		payload = add_bytestring_header(&err, dev, len);
+		if (!payload)
+			break;
+		if (copy_from_user(payload, shadow->data + off, len))
+			err = -EFAULT;
+
+		add_token_u8(&err, dev, OPAL_ENDNAME);
+		if (err)
+			break;
+
+		err = finalize_and_send(dev, parse_and_check_status);
+		if (err)
+			break;
+	}
+	return err;
+}
+
 static int generic_pw_cmd(u8 *key, size_t key_len, u8 *cpin_uid,
 			  struct opal_dev *dev)
 {
@@ -2036,6 +2082,31 @@ static int opal_mbr_status(struct opal_dev *dev, struct opal_mbr_data *opal_mbr)
 	return ret;
 }
 
+static int opal_write_shadow_mbr(struct opal_dev *dev,
+				 struct opal_shadow_mbr *info)
+{
+	const struct opal_step mbr_steps[] = {
+		{ opal_discovery0, },
+		{ start_admin1LSP_opal_session, &info->key },
+		{ write_shadow_mbr, info },
+		{ end_opal_session, },
+		{ NULL, }
+	};
+	int ret;
+
+	if (info->size == 0)
+		return 0;
+
+	if (!access_ok(VERIFY_READ, info->data, info->size))
+		return -EINVAL;
+
+	mutex_lock(&dev->dev_lock);
+	setup_opal_dev(dev, mbr_steps);
+	ret = next(dev);
+	mutex_unlock(&dev->dev_lock);
+	return ret;
+}
+
 static int opal_save(struct opal_dev *dev, struct opal_lock_unlock *lk_unlk)
 {
 	struct opal_suspend_data *suspend;
@@ -2368,6 +2439,9 @@ int sed_ioctl(struct opal_dev *dev, unsigned int cmd, void __user *arg)
 	case IOC_OPAL_MBR_STATUS:
 		ret = opal_mbr_status(dev, p);
 		break;
+	case IOC_OPAL_WRITE_SHADOW_MBR:
+		ret = opal_write_shadow_mbr(dev, p);
+		break;
 	case IOC_OPAL_ERASE_LR:
 		ret = opal_erase_locking_range(dev, p);
 		break;
diff --git a/include/linux/sed-opal.h b/include/linux/sed-opal.h
index b38dc602cae3..cf08cdc13cbd 100644
--- a/include/linux/sed-opal.h
+++ b/include/linux/sed-opal.h
@@ -47,6 +47,7 @@ static inline bool is_sed_ioctl(unsigned int cmd)
 	case IOC_OPAL_ENABLE_DISABLE_MBR:
 	case IOC_OPAL_ERASE_LR:
 	case IOC_OPAL_SECURE_ERASE_LR:
+	case IOC_OPAL_WRITE_SHADOW_MBR:
 	case IOC_OPAL_MBR_STATUS:
 		return true;
 	}
diff --git a/include/uapi/linux/sed-opal.h b/include/uapi/linux/sed-opal.h
index 0cb9890cdc04..c2669ebff681 100644
--- a/include/uapi/linux/sed-opal.h
+++ b/include/uapi/linux/sed-opal.h
@@ -104,6 +104,13 @@ struct opal_mbr_data {
 	__u8 __align[7];
 };
 
+struct opal_shadow_mbr {
+	struct opal_key key;
+	const __u8 *data;
+	__u64 offset;
+	__u64 size;
+};
+
 #define IOC_OPAL_SAVE		    _IOW('p', 220, struct opal_lock_unlock)
 #define IOC_OPAL_LOCK_UNLOCK	    _IOW('p', 221, struct opal_lock_unlock)
 #define IOC_OPAL_TAKE_OWNERSHIP	    _IOW('p', 222, struct opal_key)
@@ -117,5 +124,6 @@ struct opal_mbr_data {
 #define IOC_OPAL_ERASE_LR           _IOW('p', 230, struct opal_session_info)
 #define IOC_OPAL_SECURE_ERASE_LR    _IOW('p', 231, struct opal_session_info)
 #define IOC_OPAL_MBR_STATUS         _IOW('p', 232, struct opal_mbr_data)
+#define IOC_OPAL_WRITE_SHADOW_MBR   _IOW('p', 233, struct opal_shadow_mbr)
 
 #endif /* _UAPI_SED_OPAL_H */
-- 
2.16.1

  parent reply	other threads:[~2018-03-13 13:10 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 13:08 [PATCH 0/8] block: sed-opal: support write to shadow mbr Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 1/8] block: sed-opal: use correct macro for method length Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 2/8] block: sed-opal: unify space check in add_token_* Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 3/8] block: sed-opal: unify cmd start and finalize Jonas Rabenstein
2018-03-13 15:01   ` Scott Bauer
2018-03-14  6:26   ` [PATCH v2 " Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 4/8] block: sed-opal: unify error handling of responses Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 5/8] block: sed-opal: print failed function address Jonas Rabenstein
2018-03-13 13:08 ` [PATCH 6/8] block: sed-opal: split generation of bytestring header and content Jonas Rabenstein
2018-03-13 13:09 ` [PATCH 7/8] block: sed-opal: add ioctl for done-mark of shadow mbr Jonas Rabenstein
2018-03-13 13:09 ` Jonas Rabenstein [this message]
2018-03-13 15:44   ` [PATCH 8/8] block: sed-opal: ioctl for writing to " Scott Bauer
2018-03-14  6:15   ` [PATCH v2 8.0/8.4] block: sed-opal: check size of " Jonas Rabenstein
2018-03-14  6:15   ` [PATCH v2 8.1/8.4] block: sed-opal: ioctl for writing to " Jonas Rabenstein
2018-03-14  6:15   ` [PATCH v2 8.2/8.4] block: sed-opal: unify retrieval of table columns Jonas Rabenstein
2018-03-14  6:15   ` [PATCH v2 8.3/8.4] block: sed-opal: get metadata about opal-sed tables Jonas Rabenstein
2018-03-14  6:15   ` [PATCH v2 8.4/8.4] block: sed-opal: check size of shadow mbr Jonas Rabenstein
2018-03-14 19:39   ` [PATCH 8/8] block: sed-opal: ioctl for writing to " kbuild test robot
2018-03-13 15:53 ` [PATCH 0/8] block: sed-opal: support write " Scott Bauer
2018-03-19 18:36 ` [PATCH v2 00/11] block: sed-opal " Jonas Rabenstein
2018-03-19 19:53   ` Christoph Hellwig
2018-03-19 19:33     ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 01/11] block: sed-opal: use correct macro for method length Jonas Rabenstein
2018-03-19 19:53   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 02/11] block: sed-opal: unify space check in add_token_* Jonas Rabenstein
2018-03-19 19:54   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 03/11] block: sed-opal: unify cmd start and finalize Jonas Rabenstein
2018-03-19 19:57   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 04/11] block: sed-opal: unify error handling of responses Jonas Rabenstein
2018-03-19 19:58   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 05/11] block: sed-opal: print failed function address Jonas Rabenstein
2018-03-19 19:58   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 06/11] block: sed-opal: split generation of bytestring header and content Jonas Rabenstein
2018-03-19 19:59   ` Christoph Hellwig
2018-03-19 19:41     ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 07/11] block: sed-opal: add ioctl for done-mark of shadow mbr Jonas Rabenstein
2018-03-19 20:00   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 08/11] block: sed-opal: ioctl for writing to " Jonas Rabenstein
2018-03-19 19:52   ` Christoph Hellwig
2018-03-20  9:36     ` Jonas Rabenstein
2018-03-20 22:09       ` Scott Bauer
2018-03-21  1:43         ` Jonas Rabenstein
2018-03-29 17:30           ` Jonas Rabenstein
2018-03-29 17:16             ` Scott Bauer
2018-03-29 18:27               ` catchall
2018-04-05 20:34                 ` Scott Bauer
2018-03-19 18:36 ` [PATCH v2 09/11] block: sed-opal: unify retrieval of table columns Jonas Rabenstein
2018-03-19 18:36 ` [PATCH v2 10/11] block: sed-opal: get metadata about opal-sed tables Jonas Rabenstein
2018-03-19 20:01   ` Christoph Hellwig
2018-03-19 18:36 ` [PATCH v2 11/11] block: sed-opal: check size of shadow mbr Jonas Rabenstein
2018-03-19 20:01   ` Christoph Hellwig
2018-03-20 10:02     ` Jonas Rabenstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0b34fc0132312c09629c868d33b74fe5a19854e.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de \
    --to=jonas.rabenstein@studium.uni-erlangen.de \
    --cc=axboe@kernel.dk \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).