[PATCH] jump_label: Fix sparc64 warning

* [PATCH] jump_label: Fix sparc64 warning
@ 2018-03-14 15:24 Josh Poimboeuf
  2018-03-14 15:40 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
  2018-03-14 16:46 ` [PATCH] " David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2018-03-14 15:24 UTC (permalink / raw)
  To: x86
  Cc: linux-kernel, Ingo Molnar, David S . Miller, Peter Zijlstra,
	Jason Baron, Borislav Petkov

The kbuild test robot reported the following warning on sparc64:

  kernel/jump_label.c: In function '__jump_label_update':
  kernel/jump_label.c:376:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
       WARN_ONCE(1, "can't patch jump_label at %pS", (void *)entry->code);

On sparc64, the jump_label entry->code field is of type u32, but
pointers are 64-bit.  Silence the warning by casting entry->code to an
unsigned long before casting it to a pointer.  This is also what the
sparc jump label code does.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: dc1dd184c2f0 ("jump_label: Warn on failed jump_label patching attempt")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 kernel/jump_label.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/jump_label.c b/kernel/jump_label.c
index 52a0a7af8640..e7214093dcd1 100644
--- a/kernel/jump_label.c
+++ b/kernel/jump_label.c
@@ -373,7 +373,8 @@ static void __jump_label_update(struct static_key *key,
 			if (kernel_text_address(entry->code))
 				arch_jump_label_transform(entry, jump_label_type(entry));
 			else
-				WARN_ONCE(1, "can't patch jump_label at %pS", (void *)entry->code);
+				WARN_ONCE(1, "can't patch jump_label at %pS",
+					  (void *)(unsigned long)entry->code);
 		}
 	}
 }
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread