* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
[not found] <20180306234907.8-AwjmNNh%akpm@linux-foundation.org>
@ 2018-03-14 12:17 ` Michal Hocko
2018-03-14 14:50 ` Andrew Morton
2018-03-14 21:00 ` Stephen Rothwell
0 siblings, 2 replies; 7+ messages in thread
From: Michal Hocko @ 2018-03-14 12:17 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, mm-commits, rdunlap, sfr
On Tue 06-03-18 15:49:07, Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: headers-untangle-kmemleakh-from-mmh-fix
>
> security/keys/big_key.c needs vmalloc.h, per sfr
>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> security/keys/big_key.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -puN security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix security/keys/big_key.c
> --- a/security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix
> +++ a/security/keys/big_key.c
> @@ -18,6 +18,7 @@
> #include <linux/err.h>
> #include <linux/scatterlist.h>
> #include <linux/random.h>
> +#include <linux/vmalloc.h>
> #include <keys/user-type.h>
> #include <keys/big_key-type.h>
> #include <crypto/aead.h>
My build test battery says we need also this one, m32r complains
otherwise for allmodconfig.
>From 5c3f7a041df707417532dd64b1d71fc29b24c0fe Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@suse.com>
Date: Wed, 14 Mar 2018 13:15:49 +0100
Subject: [PATCH] headers-untangle-kmemleakh-from-mmh-fix-fix
m32r allmodconfig complains with
security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(data);
^
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
security/integrity/digsig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
index 6f9e4ce568cd..9bb0a7f2863e 100644
--- a/security/integrity/digsig.c
+++ b/security/integrity/digsig.c
@@ -18,6 +18,7 @@
#include <linux/cred.h>
#include <linux/key-type.h>
#include <linux/digsig.h>
+#include <linux/vmalloc.h>
#include <crypto/public_key.h>
#include <keys/system_keyring.h>
--
2.16.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 12:17 ` + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree Michal Hocko
@ 2018-03-14 14:50 ` Andrew Morton
2018-03-14 14:57 ` Michal Hocko
2018-03-14 21:00 ` Stephen Rothwell
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2018-03-14 14:50 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-kernel, rdunlap, sfr
On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:
> > --- a/security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix
> > +++ a/security/keys/big_key.c
> > @@ -18,6 +18,7 @@
> > #include <linux/err.h>
> > #include <linux/scatterlist.h>
> > #include <linux/random.h>
> > +#include <linux/vmalloc.h>
> > #include <keys/user-type.h>
> > #include <keys/big_key-type.h>
> > #include <crypto/aead.h>
>
> My build test battery says we need also this one, m32r complains
> otherwise for allmodconfig.
>
> >From 5c3f7a041df707417532dd64b1d71fc29b24c0fe Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.com>
> Date: Wed, 14 Mar 2018 13:15:49 +0100
> Subject: [PATCH] headers-untangle-kmemleakh-from-mmh-fix-fix
>
> m32r allmodconfig complains with
> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(data);
> ^
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
> security/integrity/digsig.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 6f9e4ce568cd..9bb0a7f2863e 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -18,6 +18,7 @@
> #include <linux/cred.h>
> #include <linux/key-type.h>
> #include <linux/digsig.h>
> +#include <linux/vmalloc.h>
> #include <crypto/public_key.h>
> #include <keys/system_keyring.h>
hm, current linux-next.patch already has this change. What happened here?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 14:50 ` Andrew Morton
@ 2018-03-14 14:57 ` Michal Hocko
2018-03-14 15:03 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Michal Hocko @ 2018-03-14 14:57 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, rdunlap, sfr
On Wed 14-03-18 07:50:55, Andrew Morton wrote:
> On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> > > --- a/security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix
> > > +++ a/security/keys/big_key.c
> > > @@ -18,6 +18,7 @@
> > > #include <linux/err.h>
> > > #include <linux/scatterlist.h>
> > > #include <linux/random.h>
> > > +#include <linux/vmalloc.h>
> > > #include <keys/user-type.h>
> > > #include <keys/big_key-type.h>
> > > #include <crypto/aead.h>
> >
> > My build test battery says we need also this one, m32r complains
> > otherwise for allmodconfig.
> >
> > >From 5c3f7a041df707417532dd64b1d71fc29b24c0fe Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@suse.com>
> > Date: Wed, 14 Mar 2018 13:15:49 +0100
> > Subject: [PATCH] headers-untangle-kmemleakh-from-mmh-fix-fix
> >
> > m32r allmodconfig complains with
> > security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> > vfree(data);
> > ^
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
> > ---
> > security/integrity/digsig.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> > index 6f9e4ce568cd..9bb0a7f2863e 100644
> > --- a/security/integrity/digsig.c
> > +++ b/security/integrity/digsig.c
> > @@ -18,6 +18,7 @@
> > #include <linux/cred.h>
> > #include <linux/key-type.h>
> > #include <linux/digsig.h>
> > +#include <linux/vmalloc.h>
> > #include <crypto/public_key.h>
> > #include <keys/system_keyring.h>
>
> hm, current linux-next.patch already has this change. What happened here?
OK, I see. This is usuall inter tree mess. It didn't fly through your
tree:
commit 120f3b11ef88fc38ce1d0ff9c9a4b37860ad3140
Author: Randy Dunlap <rdunlap@infradead.org>
Date: Mon Feb 12 17:26:20 2018 -0800
integrity/security: fix digsig.c build error with header file
security/integrity/digsig.c has build errors on some $ARCH due to a
missing header file, so add it.
security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org
Link: http://kisskb.ellerman.id.au/kisskb/head/13396/
Signed-off-by: James Morris <james.morris@microsoft.com>
And that is why I haven't noticed that.
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 14:57 ` Michal Hocko
@ 2018-03-14 15:03 ` Andrew Morton
2018-03-14 15:06 ` Michal Hocko
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2018-03-14 15:03 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-kernel, rdunlap, sfr
On Wed, 14 Mar 2018 15:57:24 +0100 Michal Hocko <mhocko@kernel.org> wrote:
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> > > index 6f9e4ce568cd..9bb0a7f2863e 100644
> > > --- a/security/integrity/digsig.c
> > > +++ b/security/integrity/digsig.c
> > > @@ -18,6 +18,7 @@
> > > #include <linux/cred.h>
> > > #include <linux/key-type.h>
> > > #include <linux/digsig.h>
> > > +#include <linux/vmalloc.h>
> > > #include <crypto/public_key.h>
> > > #include <keys/system_keyring.h>
> >
> > hm, current linux-next.patch already has this change. What happened here?
>
> OK, I see. This is usuall inter tree mess. It didn't fly through your
> tree:
> commit 120f3b11ef88fc38ce1d0ff9c9a4b37860ad3140
> Author: Randy Dunlap <rdunlap@infradead.org>
> Date: Mon Feb 12 17:26:20 2018 -0800
>
> integrity/security: fix digsig.c build error with header file
>
> security/integrity/digsig.c has build errors on some $ARCH due to a
> missing header file, so add it.
>
> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Cc: linux-integrity@vger.kernel.org
> Link: http://kisskb.ellerman.id.au/kisskb/head/13396/
> Signed-off-by: James Morris <james.morris@microsoft.com>
>
> And that is why I haven't noticed that.
I can jiggle things to prevent this, but the
security/integrity/digsig.c fix is actually in mainline now so things
should sort themselves out OK.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 15:03 ` Andrew Morton
@ 2018-03-14 15:06 ` Michal Hocko
0 siblings, 0 replies; 7+ messages in thread
From: Michal Hocko @ 2018-03-14 15:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, rdunlap, sfr
On Wed 14-03-18 08:03:28, Andrew Morton wrote:
> On Wed, 14 Mar 2018 15:57:24 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> > > > index 6f9e4ce568cd..9bb0a7f2863e 100644
> > > > --- a/security/integrity/digsig.c
> > > > +++ b/security/integrity/digsig.c
> > > > @@ -18,6 +18,7 @@
> > > > #include <linux/cred.h>
> > > > #include <linux/key-type.h>
> > > > #include <linux/digsig.h>
> > > > +#include <linux/vmalloc.h>
> > > > #include <crypto/public_key.h>
> > > > #include <keys/system_keyring.h>
> > >
> > > hm, current linux-next.patch already has this change. What happened here?
> >
> > OK, I see. This is usuall inter tree mess. It didn't fly through your
> > tree:
> > commit 120f3b11ef88fc38ce1d0ff9c9a4b37860ad3140
> > Author: Randy Dunlap <rdunlap@infradead.org>
> > Date: Mon Feb 12 17:26:20 2018 -0800
> >
> > integrity/security: fix digsig.c build error with header file
> >
> > security/integrity/digsig.c has build errors on some $ARCH due to a
> > missing header file, so add it.
> >
> > security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >
> > Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> > Cc: linux-integrity@vger.kernel.org
> > Link: http://kisskb.ellerman.id.au/kisskb/head/13396/
> > Signed-off-by: James Morris <james.morris@microsoft.com>
> >
> > And that is why I haven't noticed that.
>
> I can jiggle things to prevent this, but the
> security/integrity/digsig.c fix is actually in mainline now so things
> should sort themselves out OK.
Sure, I have done essentially the same with in my mmotm git tree.
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 12:17 ` + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree Michal Hocko
2018-03-14 14:50 ` Andrew Morton
@ 2018-03-14 21:00 ` Stephen Rothwell
2018-03-15 7:43 ` Michal Hocko
1 sibling, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2018-03-14 21:00 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-kernel, akpm, mm-commits, rdunlap
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Hi Michal,
On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> My build test battery says we need also this one, m32r complains
> otherwise for allmodconfig.
Note that the m32r architecture is being removed (the removal will be
in linux-next today) so you might want to remove it from your testing.
Also cris, metag, mn10300, frv, score, blackfin and tile.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
2018-03-14 21:00 ` Stephen Rothwell
@ 2018-03-15 7:43 ` Michal Hocko
0 siblings, 0 replies; 7+ messages in thread
From: Michal Hocko @ 2018-03-15 7:43 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-kernel, akpm, mm-commits, rdunlap
On Thu 15-03-18 08:00:01, Stephen Rothwell wrote:
> Hi Michal,
>
> On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:
> >
> > My build test battery says we need also this one, m32r complains
> > otherwise for allmodconfig.
>
> Note that the m32r architecture is being removed (the removal will be
> in linux-next today) so you might want to remove it from your testing.
Sure, will happily do
> Also cris, metag, mn10300, frv, score, blackfin and tile.
Those were not in my list due to predominating failures.
Thanks!
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-15 7:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180306234907.8-AwjmNNh%akpm@linux-foundation.org>
2018-03-14 12:17 ` + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree Michal Hocko
2018-03-14 14:50 ` Andrew Morton
2018-03-14 14:57 ` Michal Hocko
2018-03-14 15:03 ` Andrew Morton
2018-03-14 15:06 ` Michal Hocko
2018-03-14 21:00 ` Stephen Rothwell
2018-03-15 7:43 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).