* [PATCH][next] crypto: x86/des3_ede: make array des3_ede_skciphers static
@ 2018-03-05 13:18 Colin King
2018-03-16 15:35 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-03-05 13:18 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin, x86, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The array des3_ede_skciphers is local to the source and does not need
to be in global scope, so make it static.
Cleans up sparse warning:
arch/x86/crypto/des3_ede_glue.c:407:21: warning: symbol
'des3_ede_skciphers' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/crypto/des3_ede_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede_glue.c
index f9c7bdc5be5a..5c610d4ef9fc 100644
--- a/arch/x86/crypto/des3_ede_glue.c
+++ b/arch/x86/crypto/des3_ede_glue.c
@@ -404,7 +404,7 @@ static struct crypto_alg des3_ede_cipher = {
}
};
-struct skcipher_alg des3_ede_skciphers[] = {
+static struct skcipher_alg des3_ede_skciphers[] = {
{
.base.cra_name = "ecb(des3_ede)",
.base.cra_driver_name = "ecb-des3_ede-asm",
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] crypto: x86/des3_ede: make array des3_ede_skciphers static
2018-03-05 13:18 [PATCH][next] crypto: x86/des3_ede: make array des3_ede_skciphers static Colin King
@ 2018-03-16 15:35 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2018-03-16 15:35 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
x86, linux-crypto, kernel-janitors, linux-kernel
On Mon, Mar 05, 2018 at 02:18:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array des3_ede_skciphers is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> arch/x86/crypto/des3_ede_glue.c:407:21: warning: symbol
> 'des3_ede_skciphers' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This patch no longer applies because it's already been merged
from someone else.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-16 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05 13:18 [PATCH][next] crypto: x86/des3_ede: make array des3_ede_skciphers static Colin King
2018-03-16 15:35 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).