* [PATCH 1/4] GPU: drm: Fixed Spacing issue
@ 2018-03-19 0:52 Paul McQuade
2018-03-19 0:52 ` [PATCH 2/4] " Paul McQuade
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Paul McQuade @ 2018-03-19 0:52 UTC (permalink / raw)
To: paulmcquad
Cc: daniel.vetter, gustavo, seanpaul, airlied, dri-devel, linux-kernel
"foo * bar" should be "foo *bar"
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index 1ee84dd802d4..83b3d0801262 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -129,7 +129,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
* type. Adds the map to the map list drm_device::maplist. Adds MTRR's where
* applicable and if supported by the kernel.
*/
-static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
+static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
unsigned int size, enum drm_map_type type,
enum drm_map_flags flags,
struct drm_map_list ** maplist)
@@ -361,7 +361,7 @@ static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
return 0;
}
-int drm_legacy_addmap(struct drm_device * dev, resource_size_t offset,
+int drm_legacy_addmap(struct drm_device *dev, resource_size_t offset,
unsigned int size, enum drm_map_type type,
enum drm_map_flags flags, struct drm_local_map **map_ptr)
{
@@ -637,8 +637,8 @@ int drm_legacy_rmmap_ioctl(struct drm_device *dev, void *data,
*
* Frees any pages and buffers associated with the given entry.
*/
-static void drm_cleanup_buf_error(struct drm_device * dev,
- struct drm_buf_entry * entry)
+static void drm_cleanup_buf_error(struct drm_device *dev,
+ struct drm_buf_entry *entry)
{
int i;
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/4] GPU: drm: Fixed Spacing issue
2018-03-19 0:52 [PATCH 1/4] GPU: drm: Fixed Spacing issue Paul McQuade
@ 2018-03-19 0:52 ` Paul McQuade
2018-03-19 0:52 ` [PATCH 3/4] " Paul McQuade
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Paul McQuade @ 2018-03-19 0:52 UTC (permalink / raw)
To: paulmcquad
Cc: daniel.vetter, gustavo, seanpaul, airlied, dri-devel, linux-kernel
"foo ** bar" should be "foo **bar"
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index 83b3d0801262..9af9efd84ee7 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -132,7 +132,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
unsigned int size, enum drm_map_type type,
enum drm_map_flags flags,
- struct drm_map_list ** maplist)
+ struct drm_map_list **maplist)
{
struct drm_local_map *map;
struct drm_map_list *list;
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/4] GPU: drm: Fixed Spacing issue
2018-03-19 0:52 [PATCH 1/4] GPU: drm: Fixed Spacing issue Paul McQuade
2018-03-19 0:52 ` [PATCH 2/4] " Paul McQuade
@ 2018-03-19 0:52 ` Paul McQuade
2018-03-19 0:52 ` [PATCH 4/4] GPU: drm: Fixed Coding issue Paul McQuade
2018-03-19 13:34 ` [PATCH 1/4] GPU: drm: Fixed Spacing issue Sean Paul
3 siblings, 0 replies; 5+ messages in thread
From: Paul McQuade @ 2018-03-19 0:52 UTC (permalink / raw)
To: paulmcquad
Cc: daniel.vetter, gustavo, seanpaul, airlied, dri-devel, linux-kernel
space prohibited after that open parenthesis '('
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index 9af9efd84ee7..8e345ba16858 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -224,7 +224,7 @@ static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
case _DRM_SHM:
list = drm_find_matching_map(dev, map);
if (list != NULL) {
- if(list->map->size != map->size) {
+ if (list->map->size != map->size) {
DRM_DEBUG("Matching maps of type %d with "
"mismatched sizes, (%ld vs %ld)\n",
map->type, map->size, list->map->size);
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 4/4] GPU: drm: Fixed Coding issue
2018-03-19 0:52 [PATCH 1/4] GPU: drm: Fixed Spacing issue Paul McQuade
2018-03-19 0:52 ` [PATCH 2/4] " Paul McQuade
2018-03-19 0:52 ` [PATCH 3/4] " Paul McQuade
@ 2018-03-19 0:52 ` Paul McQuade
2018-03-19 13:34 ` [PATCH 1/4] GPU: drm: Fixed Spacing issue Sean Paul
3 siblings, 0 replies; 5+ messages in thread
From: Paul McQuade @ 2018-03-19 0:52 UTC (permalink / raw)
To: paulmcquad
Cc: daniel.vetter, gustavo, seanpaul, airlied, dri-devel, linux-kernel
code indent should use tabs where possible
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index 8e345ba16858..ba8cfe65c65b 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -1446,8 +1446,8 @@ int drm_legacy_freebufs(struct drm_device *dev, void *data,
int __drm_legacy_mapbufs(struct drm_device *dev, void *data, int *p,
void __user **v,
int (*f)(void *, int, unsigned long,
- struct drm_buf *),
- struct drm_file *file_priv)
+ struct drm_buf *),
+ struct drm_file *file_priv)
{
struct drm_device_dma *dma = dev->dma;
int retcode = 0;
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] GPU: drm: Fixed Spacing issue
2018-03-19 0:52 [PATCH 1/4] GPU: drm: Fixed Spacing issue Paul McQuade
` (2 preceding siblings ...)
2018-03-19 0:52 ` [PATCH 4/4] GPU: drm: Fixed Coding issue Paul McQuade
@ 2018-03-19 13:34 ` Sean Paul
3 siblings, 0 replies; 5+ messages in thread
From: Sean Paul @ 2018-03-19 13:34 UTC (permalink / raw)
To: Paul McQuade
Cc: daniel.vetter, gustavo, seanpaul, airlied, dri-devel, linux-kernel
On Mon, Mar 19, 2018 at 12:52:22AM +0000, Paul McQuade wrote:
> "foo * bar" should be "foo *bar"
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
Thank you for your patches. I've squashed them all into one, fixed up the commit
message and applied them to drm-misc-next.
Sean
> ---
> drivers/gpu/drm/drm_bufs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> index 1ee84dd802d4..83b3d0801262 100644
> --- a/drivers/gpu/drm/drm_bufs.c
> +++ b/drivers/gpu/drm/drm_bufs.c
> @@ -129,7 +129,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
> * type. Adds the map to the map list drm_device::maplist. Adds MTRR's where
> * applicable and if supported by the kernel.
> */
> -static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
> +static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
> unsigned int size, enum drm_map_type type,
> enum drm_map_flags flags,
> struct drm_map_list ** maplist)
> @@ -361,7 +361,7 @@ static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
> return 0;
> }
>
> -int drm_legacy_addmap(struct drm_device * dev, resource_size_t offset,
> +int drm_legacy_addmap(struct drm_device *dev, resource_size_t offset,
> unsigned int size, enum drm_map_type type,
> enum drm_map_flags flags, struct drm_local_map **map_ptr)
> {
> @@ -637,8 +637,8 @@ int drm_legacy_rmmap_ioctl(struct drm_device *dev, void *data,
> *
> * Frees any pages and buffers associated with the given entry.
> */
> -static void drm_cleanup_buf_error(struct drm_device * dev,
> - struct drm_buf_entry * entry)
> +static void drm_cleanup_buf_error(struct drm_device *dev,
> + struct drm_buf_entry *entry)
> {
> int i;
>
> --
> 2.16.2
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-19 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 0:52 [PATCH 1/4] GPU: drm: Fixed Spacing issue Paul McQuade
2018-03-19 0:52 ` [PATCH 2/4] " Paul McQuade
2018-03-19 0:52 ` [PATCH 3/4] " Paul McQuade
2018-03-19 0:52 ` [PATCH 4/4] GPU: drm: Fixed Coding issue Paul McQuade
2018-03-19 13:34 ` [PATCH 1/4] GPU: drm: Fixed Spacing issue Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).