drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
@ 2018-03-20  4:47 kbuild test robot
  2018-03-20 23:24 ` Darren Hart
  0 siblings, 1 reply; 15+ messages in thread
From: kbuild test robot @ 2018-03-20  4:47 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: kbuild-all, linux-kernel, Darren Hart (VMware)

[-- Attachment #1: Type: text/plain, Size: 2705 bytes --]

Hi Mario,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1b5f3ba415fe4cf8b8b39c8d104ed44cde330658
commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
date:   10 days ago
config: x86_64-randconfig-s1-03201142 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
>> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

vim +99 drivers/platform/x86/dell-smbios-smm.c

549b4930 Mario Limonciello 2017-11-01   84  
549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct calling_interface_buffer *input)
549b4930 Mario Limonciello 2017-11-01   86  {
549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
549b4930 Mario Limonciello 2017-11-01   89  
549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct calling_interface_buffer);
549b4930 Mario Limonciello 2017-11-01   91  	command.magic = SMI_CMD_MAGIC;
549b4930 Mario Limonciello 2017-11-01   92  	command.command_address = da_command_address;
549b4930 Mario Limonciello 2017-11-01   93  	command.command_code = da_command_code;
549b4930 Mario Limonciello 2017-11-01   94  	command.ebx = virt_to_phys(buffer);
549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
549b4930 Mario Limonciello 2017-11-01   96  
549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01  102  	return 0;
549b4930 Mario Limonciello 2017-11-01  103  }
549b4930 Mario Limonciello 2017-11-01  104  

:::::: The code at line 99 was first introduced by commit
:::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls

:::::: TO: Mario Limonciello <mario.limonciello@dell.com>
:::::: CC: Darren Hart (VMware) <dvhart@infradead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33876 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-03-20  4:47 drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request' kbuild test robot
@ 2018-03-20 23:24 ` Darren Hart
  0 siblings, 0 replies; 15+ messages in thread
From: Darren Hart @ 2018-03-20 23:24 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Mario Limonciello, kbuild-all, linux-kernel

On Tue, Mar 20, 2018 at 12:47:24PM +0800, kbuild test robot wrote:
> Hi Mario,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1b5f3ba415fe4cf8b8b39c8d104ed44cde330658
> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together

For completeness:

This is a known warning at this commit, which is addressed in future commits now
merged, specifically:

75073a64a98c platform/x86: dell-smbios: Resolve dependency error on ACPI_WMI
32d7b19bad96 platform/x86: dell-smbios: Resolve dependency error on DCDBAS
329d58b890be platform/x86: Allow for SMBIOS backend defaults

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 15+ messages in thread

* drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
@ 2018-05-12  9:28 kbuild test robot
  2018-05-12 18:32 ` Darren Hart
  0 siblings, 1 reply; 15+ messages in thread
From: kbuild test robot @ 2018-05-12  9:28 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: kbuild-all, linux-kernel, Darren Hart (VMware)

[-- Attachment #1: Type: text/plain, Size: 2697 bytes --]

Hi Mario,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f0ab773f5c96c29a5227234c4b5a820f5591b74d
commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
date:   9 weeks ago
config: x86_64-randconfig-s5-05121617 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
>> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

vim +99 drivers/platform/x86/dell-smbios-smm.c

549b4930 Mario Limonciello 2017-11-01   84  
549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct calling_interface_buffer *input)
549b4930 Mario Limonciello 2017-11-01   86  {
549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
549b4930 Mario Limonciello 2017-11-01   89  
549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct calling_interface_buffer);
549b4930 Mario Limonciello 2017-11-01   91  	command.magic = SMI_CMD_MAGIC;
549b4930 Mario Limonciello 2017-11-01   92  	command.command_address = da_command_address;
549b4930 Mario Limonciello 2017-11-01   93  	command.command_code = da_command_code;
549b4930 Mario Limonciello 2017-11-01   94  	command.ebx = virt_to_phys(buffer);
549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
549b4930 Mario Limonciello 2017-11-01   96  
549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01  102  	return 0;
549b4930 Mario Limonciello 2017-11-01  103  }
549b4930 Mario Limonciello 2017-11-01  104  

:::::: The code at line 99 was first introduced by commit
:::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls

:::::: TO: Mario Limonciello <mario.limonciello@dell.com>
:::::: CC: Darren Hart (VMware) <dvhart@infradead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31711 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-12  9:28 kbuild test robot
@ 2018-05-12 18:32 ` Darren Hart
  2018-05-12 18:51   ` Randy Dunlap
  0 siblings, 1 reply; 15+ messages in thread
From: Darren Hart @ 2018-05-12 18:32 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Mario Limonciello, kbuild-all, linux-kernel

On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote:
> Hi Mario,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   f0ab773f5c96c29a5227234c4b5a820f5591b74d
> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
> date:   9 weeks ago
> config: x86_64-randconfig-s5-05121617 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9

This failure:

$ zcat config.gz | grep DCDBAS
CONFIG_DCDBAS=m            <----------

$ zcat config.gz | grep SMBIOS
CONFIG_DELL_SMBIOS=y       <----------
ddCONFIG_DELL_SMBIOS_WMI=y
CONFIG_DELL_SMBIOS_SMM=y   <----------

Is no longer possible as of:

cc69c88 platform/x86: dell-smbios: Resolve dependency error on DCDBAS

+#
+# If the DELL_SMBIOS_SMM feature is enabled, the DELL_SMBIOS driver
+# becomes dependent on the DCDBAS driver. The "depends" line prevents a
+# configuration where DELL_SMBIOS=y while DCDBAS=m.
+#
 config DELL_SMBIOS
        tristate "Dell SMBIOS driver"
+       depends on DCDBAS || DCDBAS=n

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-12 18:32 ` Darren Hart
@ 2018-05-12 18:51   ` Randy Dunlap
  2018-05-12 19:15     ` Darren Hart
  0 siblings, 1 reply; 15+ messages in thread
From: Randy Dunlap @ 2018-05-12 18:51 UTC (permalink / raw)
  To: Darren Hart, kbuild test robot
  Cc: Mario Limonciello, kbuild-all, linux-kernel

On 05/12/2018 11:32 AM, Darren Hart wrote:
> On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote:
>> Hi Mario,
>>
>> FYI, the error/warning still remains.
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   f0ab773f5c96c29a5227234c4b5a820f5591b74d
>> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
>> date:   9 weeks ago
>> config: x86_64-randconfig-s5-05121617 (attached as .config)
>> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
>> reproduce:
>>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
> 
> This failure:
> 
> $ zcat config.gz | grep DCDBAS
> CONFIG_DCDBAS=m            <----------
> 
> $ zcat config.gz | grep SMBIOS
> CONFIG_DELL_SMBIOS=y       <----------
> ddCONFIG_DELL_SMBIOS_WMI=y
> CONFIG_DELL_SMBIOS_SMM=y   <----------
> 
> Is no longer possible as of:
> 
> cc69c88 platform/x86: dell-smbios: Resolve dependency error on DCDBAS
> 
> +#
> +# If the DELL_SMBIOS_SMM feature is enabled, the DELL_SMBIOS driver
> +# becomes dependent on the DCDBAS driver. The "depends" line prevents a
> +# configuration where DELL_SMBIOS=y while DCDBAS=m.
> +#
>  config DELL_SMBIOS
>         tristate "Dell SMBIOS driver"
> +       depends on DCDBAS || DCDBAS=n
> 

and but yet, in linux-4.17-rc4, with this posted config file (after
using:  yes '' |make oldconfig), we can see:

WARNING: unmet direct dependencies detected for DELL_SMBIOS
  Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] && (DCDBAS [=m] || DCDBAS [=m]=n) && (ACPI_WMI [=y] || ACPI_WMI [=y]=n)
  Selected by [y]:
  - DELL_WMI [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI_WMI [=y] && DMI [=y] && INPUT [=y] && (ACPI_VIDEO [=y] || ACPI_VIDEO [=y]=n)

CONFIG_DELL_SMBIOS=y
CONFIG_DELL_SMBIOS_WMI=y
CONFIG_DELL_SMBIOS_SMM=y
# CONFIG_DELL_LAPTOP is not set
CONFIG_DELL_WMI=y
CONFIG_DELL_WMI_DESCRIPTOR=y
CONFIG_ACPI_WMI=y
CONFIG_DELL_RBU=y
CONFIG_DCDBAS=m


I'll stare at it some (more), but no promises.

-- 
~Randy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-12 18:51   ` Randy Dunlap
@ 2018-05-12 19:15     ` Darren Hart
  2018-05-12 20:04       ` Randy Dunlap
  0 siblings, 1 reply; 15+ messages in thread
From: Darren Hart @ 2018-05-12 19:15 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: kbuild test robot, Mario Limonciello, kbuild-all, linux-kernel

On Sat, May 12, 2018 at 11:51:02AM -0700, Randy Dunlap wrote:
> On 05/12/2018 11:32 AM, Darren Hart wrote:
> > On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote:
> >> Hi Mario,
> >>
> >> FYI, the error/warning still remains.
> >>
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >> head:   f0ab773f5c96c29a5227234c4b5a820f5591b74d
> >> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
> >> date:   9 weeks ago
> >> config: x86_64-randconfig-s5-05121617 (attached as .config)
> >> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> >> reproduce:
> >>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
> > 
> > This failure:
> > 
> > $ zcat config.gz | grep DCDBAS
> > CONFIG_DCDBAS=m            <----------
> > 
> > $ zcat config.gz | grep SMBIOS
> > CONFIG_DELL_SMBIOS=y       <----------
> > ddCONFIG_DELL_SMBIOS_WMI=y
> > CONFIG_DELL_SMBIOS_SMM=y   <----------
> > 
> > Is no longer possible as of:
> > 
> > cc69c88 platform/x86: dell-smbios: Resolve dependency error on DCDBAS
> > 
> > +#
> > +# If the DELL_SMBIOS_SMM feature is enabled, the DELL_SMBIOS driver
> > +# becomes dependent on the DCDBAS driver. The "depends" line prevents a
> > +# configuration where DELL_SMBIOS=y while DCDBAS=m.
> > +#
> >  config DELL_SMBIOS
> >         tristate "Dell SMBIOS driver"
> > +       depends on DCDBAS || DCDBAS=n
> > 
> 
> and but yet, in linux-4.17-rc4, with this posted config file (after
> using:  yes '' |make oldconfig), we can see:
> 
> WARNING: unmet direct dependencies detected for DELL_SMBIOS
>   Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] && (DCDBAS [=m] || DCDBAS [=m]=n) && (ACPI_WMI [=y] || ACPI_WMI [=y]=n)
>   Selected by [y]:
>   - DELL_WMI [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI_WMI [=y] && DMI [=y] && INPUT [=y] && (ACPI_VIDEO [=y] || ACPI_VIDEO [=y]=n)
> 
> CONFIG_DELL_SMBIOS=y
> CONFIG_DELL_SMBIOS_WMI=y
> CONFIG_DELL_SMBIOS_SMM=y
> # CONFIG_DELL_LAPTOP is not set
> CONFIG_DELL_WMI=y

Ugh. It must be this straggler then:

config DELL_WMI
	...
	select DELL_SMBIOS

which will set DELL_SMBIOS to y and ignore the dependencies.

The only other DELL related select in the Kconfig is DELL_WMI_DESCRIPTOR which
doesn't have a prompt, but does depend on ACPI_WMI. It is only selected from
configs which already depend on ACPI_WMI.

So the immediate fix appears to be:


>From bf88bc78d5bb1f03a1b99b110b71af8443692df0 Mon Sep 17 00:00:00 2001
Message-Id: <bf88bc78d5bb1f03a1b99b110b71af8443692df0.1526152324.git.dvhart@infradead.org>
From: Darren Hart <dvhart@infradead.org>
Date: Sat, 12 May 2018 12:10:07 -0700
Subject: [PATCH] platform/x86: DELL_WMI use depends on instead of select for
 DELL_SMBIOS

If DELL_WMI "select"s DELL_SMBIOS, the DELL_SMBIOS dependencies are
ignored and it is still possible to end up with unmet direct
dependencies.

Change the select to a depends on.

Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index bc309c5..566644b 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -168,8 +168,8 @@ config DELL_WMI
 	depends on DMI
 	depends on INPUT
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
+	depends on DELL_SMBIOS
 	select DELL_WMI_DESCRIPTOR
-	select DELL_SMBIOS
 	select INPUT_SPARSEKMAP
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Dell laptops.
-- 
2.9.3


-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-12 19:15     ` Darren Hart
@ 2018-05-12 20:04       ` Randy Dunlap
  0 siblings, 0 replies; 15+ messages in thread
From: Randy Dunlap @ 2018-05-12 20:04 UTC (permalink / raw)
  To: Darren Hart
  Cc: kbuild test robot, Mario Limonciello, kbuild-all, linux-kernel

On 05/12/2018 12:15 PM, Darren Hart wrote:
> On Sat, May 12, 2018 at 11:51:02AM -0700, Randy Dunlap wrote:
>> On 05/12/2018 11:32 AM, Darren Hart wrote:
>>> On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote:
>>>> Hi Mario,
>>>>
>>>> FYI, the error/warning still remains.
>>>>
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>>> head:   f0ab773f5c96c29a5227234c4b5a820f5591b74d
>>>> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
>>>> date:   9 weeks ago
>>>> config: x86_64-randconfig-s5-05121617 (attached as .config)
>>>> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
>>>> reproduce:
>>>>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
>>>
>>> This failure:
>>>
>>> $ zcat config.gz | grep DCDBAS
>>> CONFIG_DCDBAS=m            <----------
>>>
>>> $ zcat config.gz | grep SMBIOS
>>> CONFIG_DELL_SMBIOS=y       <----------
>>> ddCONFIG_DELL_SMBIOS_WMI=y
>>> CONFIG_DELL_SMBIOS_SMM=y   <----------
>>>
>>> Is no longer possible as of:
>>>
>>> cc69c88 platform/x86: dell-smbios: Resolve dependency error on DCDBAS
>>>
>>> +#
>>> +# If the DELL_SMBIOS_SMM feature is enabled, the DELL_SMBIOS driver
>>> +# becomes dependent on the DCDBAS driver. The "depends" line prevents a
>>> +# configuration where DELL_SMBIOS=y while DCDBAS=m.
>>> +#
>>>  config DELL_SMBIOS
>>>         tristate "Dell SMBIOS driver"
>>> +       depends on DCDBAS || DCDBAS=n
>>>
>>
>> and but yet, in linux-4.17-rc4, with this posted config file (after
>> using:  yes '' |make oldconfig), we can see:
>>
>> WARNING: unmet direct dependencies detected for DELL_SMBIOS
>>   Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] && (DCDBAS [=m] || DCDBAS [=m]=n) && (ACPI_WMI [=y] || ACPI_WMI [=y]=n)
>>   Selected by [y]:
>>   - DELL_WMI [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI_WMI [=y] && DMI [=y] && INPUT [=y] && (ACPI_VIDEO [=y] || ACPI_VIDEO [=y]=n)
>>
>> CONFIG_DELL_SMBIOS=y
>> CONFIG_DELL_SMBIOS_WMI=y
>> CONFIG_DELL_SMBIOS_SMM=y
>> # CONFIG_DELL_LAPTOP is not set
>> CONFIG_DELL_WMI=y
> 
> Ugh. It must be this straggler then:
> 
> config DELL_WMI
> 	...
> 	select DELL_SMBIOS
> 
> which will set DELL_SMBIOS to y and ignore the dependencies.
> 
> The only other DELL related select in the Kconfig is DELL_WMI_DESCRIPTOR which
> doesn't have a prompt, but does depend on ACPI_WMI. It is only selected from
> configs which already depend on ACPI_WMI.
> 
> So the immediate fix appears to be:
> 
> 
> From bf88bc78d5bb1f03a1b99b110b71af8443692df0 Mon Sep 17 00:00:00 2001
> Message-Id: <bf88bc78d5bb1f03a1b99b110b71af8443692df0.1526152324.git.dvhart@infradead.org>
> From: Darren Hart <dvhart@infradead.org>
> Date: Sat, 12 May 2018 12:10:07 -0700
> Subject: [PATCH] platform/x86: DELL_WMI use depends on instead of select for
>  DELL_SMBIOS
> 
> If DELL_WMI "select"s DELL_SMBIOS, the DELL_SMBIOS dependencies are
> ignored and it is still possible to end up with unmet direct
> dependencies.
> 
> Change the select to a depends on.
> 
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>

I was looking nearby...

Yes, this fixes the build error and the kconfig unmet dependencies.

Tested-by: Randy Dunlap <rdunlap@infradead.org>


> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index bc309c5..566644b 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -168,8 +168,8 @@ config DELL_WMI
>  	depends on DMI
>  	depends on INPUT
>  	depends on ACPI_VIDEO || ACPI_VIDEO = n
> +	depends on DELL_SMBIOS
>  	select DELL_WMI_DESCRIPTOR
> -	select DELL_SMBIOS
>  	select INPUT_SPARSEKMAP
>  	---help---
>  	  Say Y here if you want to support WMI-based hotkeys on Dell laptops.
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
@ 2018-05-04 18:24 kbuild test robot
  2018-05-04 18:27 ` Mario.Limonciello
  0 siblings, 1 reply; 15+ messages in thread
From: kbuild test robot @ 2018-05-04 18:24 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: kbuild-all, linux-kernel, Darren Hart (VMware)

[-- Attachment #1: Type: text/plain, Size: 2705 bytes --]

Hi Mario,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   625e2001e99e82ea3eb5b0370a428a4328b9166b
commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
date:   8 weeks ago
config: x86_64-randconfig-s1-05050043 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
>> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

vim +99 drivers/platform/x86/dell-smbios-smm.c

549b4930 Mario Limonciello 2017-11-01   84  
549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct calling_interface_buffer *input)
549b4930 Mario Limonciello 2017-11-01   86  {
549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
549b4930 Mario Limonciello 2017-11-01   89  
549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct calling_interface_buffer);
549b4930 Mario Limonciello 2017-11-01   91  	command.magic = SMI_CMD_MAGIC;
549b4930 Mario Limonciello 2017-11-01   92  	command.command_address = da_command_address;
549b4930 Mario Limonciello 2017-11-01   93  	command.command_code = da_command_code;
549b4930 Mario Limonciello 2017-11-01   94  	command.ebx = virt_to_phys(buffer);
549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
549b4930 Mario Limonciello 2017-11-01   96  
549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01  102  	return 0;
549b4930 Mario Limonciello 2017-11-01  103  }
549b4930 Mario Limonciello 2017-11-01  104  

:::::: The code at line 99 was first introduced by commit
:::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls

:::::: TO: Mario Limonciello <mario.limonciello@dell.com>
:::::: CC: Darren Hart (VMware) <dvhart@infradead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27304 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-04 18:24 kbuild test robot
@ 2018-05-04 18:27 ` Mario.Limonciello
  2018-05-04 20:08   ` dvhart
                     ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Mario.Limonciello @ 2018-05-04 18:27 UTC (permalink / raw)
  To: lkp; +Cc: kbuild-all, linux-kernel, dvhart

Darren,

Is this with that fix of mine merged?  

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: Friday, May 4, 2018 1:24 PM
> To: Limonciello, Mario
> Cc: kbuild-all@01.org; linux-kernel@vger.kernel.org; Darren Hart (VMware)
> Subject: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> `dcdbas_smi_request'
> 
> Hi Mario,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   625e2001e99e82ea3eb5b0370a428a4328b9166b
> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-
> smbios: Link all dell-smbios-* modules together
> date:   8 weeks ago
> config: x86_64-randconfig-s1-05050043 (attached as .config)
> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
> reproduce:
>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
> >> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> `dcdbas_smi_request'
> 
> vim +99 drivers/platform/x86/dell-smbios-smm.c
> 
> 549b4930 Mario Limonciello 2017-11-01   84
> 549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct
> calling_interface_buffer *input)
> 549b4930 Mario Limonciello 2017-11-01   86  {
> 549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
> 549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
> 549b4930 Mario Limonciello 2017-11-01   89
> 549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct
> calling_interface_buffer);
> 549b4930 Mario Limonciello 2017-11-01   91  	command.magic =
> SMI_CMD_MAGIC;
> 549b4930 Mario Limonciello 2017-11-01   92  	command.command_address =
> da_command_address;
> 549b4930 Mario Limonciello 2017-11-01   93  	command.command_code =
> da_command_code;
> 549b4930 Mario Limonciello 2017-11-01   94  	command.ebx =
> virt_to_phys(buffer);
> 549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
> 549b4930 Mario Limonciello 2017-11-01   96
> 549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
> 549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
> 549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
> 549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
> 549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
> 549b4930 Mario Limonciello 2017-11-01  102  	return 0;
> 549b4930 Mario Limonciello 2017-11-01  103  }
> 549b4930 Mario Limonciello 2017-11-01  104
> 
> :::::: The code at line 99 was first introduced by commit
> :::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios:
> Introduce dispatcher for SMM calls
> 
> :::::: TO: Mario Limonciello <mario.limonciello@dell.com>
> :::::: CC: Darren Hart (VMware) <dvhart@infradead.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-04 18:27 ` Mario.Limonciello
@ 2018-05-04 20:08   ` dvhart
  2018-05-04 20:15   ` Darren Hart
  2018-05-06 22:29   ` Darren Hart
  2 siblings, 0 replies; 15+ messages in thread
From: dvhart @ 2018-05-04 20:08 UTC (permalink / raw)
  To: Mario.Limonciello, lkp; +Cc: kbuild-all, linux-kernel

No, your fix is in next, but needs to go to Linus via the fixes branch. I have 2 to send on to him. I am traveling and was planning to do it this weekend.

On May 4, 2018 8:27:00 PM GMT+02:00, Mario.Limonciello@dell.com wrote:
>Darren,
>
>Is this with that fix of mine merged?  
>
>> -----Original Message-----
>> From: kbuild test robot [mailto:lkp@intel.com]
>> Sent: Friday, May 4, 2018 1:24 PM
>> To: Limonciello, Mario
>> Cc: kbuild-all@01.org; linux-kernel@vger.kernel.org; Darren Hart
>(VMware)
>> Subject: drivers/platform/x86/dell-smbios-smm.c:99: undefined
>reference to
>> `dcdbas_smi_request'
>> 
>> Hi Mario,
>> 
>> FYI, the error/warning still remains.
>> 
>> tree:  
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>master
>> head:   625e2001e99e82ea3eb5b0370a428a4328b9166b
>> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-
>> smbios: Link all dell-smbios-* modules together
>> date:   8 weeks ago
>> config: x86_64-randconfig-s1-05050043 (attached as .config)
>> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
>> reproduce:
>>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64
>> 
>> All errors (new ones prefixed by >>):
>> 
>>    drivers/platform/x86/dell-smbios-smm.o: In function
>`dell_smbios_smm_call':
>> >> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
>> `dcdbas_smi_request'
>> 
>> vim +99 drivers/platform/x86/dell-smbios-smm.c
>> 
>> 549b4930 Mario Limonciello 2017-11-01   84
>> 549b4930 Mario Limonciello 2017-11-01   85  int
>dell_smbios_smm_call(struct
>> calling_interface_buffer *input)
>> 549b4930 Mario Limonciello 2017-11-01   86  {
>> 549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
>> 549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
>> 549b4930 Mario Limonciello 2017-11-01   89
>> 549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct
>> calling_interface_buffer);
>> 549b4930 Mario Limonciello 2017-11-01   91  	command.magic =
>> SMI_CMD_MAGIC;
>> 549b4930 Mario Limonciello 2017-11-01   92  	command.command_address
>=
>> da_command_address;
>> 549b4930 Mario Limonciello 2017-11-01   93  	command.command_code =
>> da_command_code;
>> 549b4930 Mario Limonciello 2017-11-01   94  	command.ebx =
>> virt_to_phys(buffer);
>> 549b4930 Mario Limonciello 2017-11-01   95  	command.ecx =
>0x42534931;
>> 549b4930 Mario Limonciello 2017-11-01   96
>> 549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
>> 549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input,
>size);
>> 549b4930 Mario Limonciello 2017-11-01  @99 
>	dcdbas_smi_request(&command);
>> 549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer,
>size);
>> 549b4930 Mario Limonciello 2017-11-01  101 
>	mutex_unlock(&smm_mutex);
>> 549b4930 Mario Limonciello 2017-11-01  102  	return 0;
>> 549b4930 Mario Limonciello 2017-11-01  103  }
>> 549b4930 Mario Limonciello 2017-11-01  104
>> 
>> :::::: The code at line 99 was first introduced by commit
>> :::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86:
>dell-smbios:
>> Introduce dispatcher for SMM calls
>> 
>> :::::: TO: Mario Limonciello <mario.limonciello@dell.com>
>> :::::: CC: Darren Hart (VMware) <dvhart@infradead.org>
>> 
>> ---
>> 0-DAY kernel test infrastructure                Open Source
>Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel
>Corporation

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-04 18:27 ` Mario.Limonciello
  2018-05-04 20:08   ` dvhart
@ 2018-05-04 20:15   ` Darren Hart
  2018-05-06 22:29   ` Darren Hart
  2 siblings, 0 replies; 15+ messages in thread
From: Darren Hart @ 2018-05-04 20:15 UTC (permalink / raw)
  To: Mario.Limonciello; +Cc: lkp, kbuild-all, linux-kernel

On Fri, May 04, 2018 at 06:27:00PM +0000, Mario.Limonciello@dell.com wrote:
> Darren,
> 
> Is this with that fix of mine merged?  

No, your patch is in for-next. I can now move it to fixes and on to Linus this
weekend. Sorry for the delay, in part due to travel this week.

--
Darren

> 
> > -----Original Message-----
> > From: kbuild test robot [mailto:lkp@intel.com]
> > Sent: Friday, May 4, 2018 1:24 PM
> > To: Limonciello, Mario
> > Cc: kbuild-all@01.org; linux-kernel@vger.kernel.org; Darren Hart (VMware)
> > Subject: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> > `dcdbas_smi_request'
> > 
> > Hi Mario,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   625e2001e99e82ea3eb5b0370a428a4328b9166b
> > commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-
> > smbios: Link all dell-smbios-* modules together
> > date:   8 weeks ago
> > config: x86_64-randconfig-s1-05050043 (attached as .config)
> > compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
> > reproduce:
> >         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
> > >> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> > `dcdbas_smi_request'
> > 
> > vim +99 drivers/platform/x86/dell-smbios-smm.c
> > 
> > 549b4930 Mario Limonciello 2017-11-01   84
> > 549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct
> > calling_interface_buffer *input)
> > 549b4930 Mario Limonciello 2017-11-01   86  {
> > 549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
> > 549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
> > 549b4930 Mario Limonciello 2017-11-01   89
> > 549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct
> > calling_interface_buffer);
> > 549b4930 Mario Limonciello 2017-11-01   91  	command.magic =
> > SMI_CMD_MAGIC;
> > 549b4930 Mario Limonciello 2017-11-01   92  	command.command_address =
> > da_command_address;
> > 549b4930 Mario Limonciello 2017-11-01   93  	command.command_code =
> > da_command_code;
> > 549b4930 Mario Limonciello 2017-11-01   94  	command.ebx =
> > virt_to_phys(buffer);
> > 549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
> > 549b4930 Mario Limonciello 2017-11-01   96
> > 549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
> > 549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
> > 549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
> > 549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
> > 549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
> > 549b4930 Mario Limonciello 2017-11-01  102  	return 0;
> > 549b4930 Mario Limonciello 2017-11-01  103  }
> > 549b4930 Mario Limonciello 2017-11-01  104
> > 
> > :::::: The code at line 99 was first introduced by commit
> > :::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios:
> > Introduce dispatcher for SMM calls
> > 
> > :::::: TO: Mario Limonciello <mario.limonciello@dell.com>
> > :::::: CC: Darren Hart (VMware) <dvhart@infradead.org>
> > 
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-05-04 18:27 ` Mario.Limonciello
  2018-05-04 20:08   ` dvhart
  2018-05-04 20:15   ` Darren Hart
@ 2018-05-06 22:29   ` Darren Hart
  2 siblings, 0 replies; 15+ messages in thread
From: Darren Hart @ 2018-05-06 22:29 UTC (permalink / raw)
  To: Mario.Limonciello; +Cc: lkp, kbuild-all, linux-kernel

On Fri, May 04, 2018 at 06:27:00PM +0000, Mario.Limonciello@dell.com wrote:
> Darren,
> 
> Is this with that fix of mine merged?  

FYI: This fix has now been merged to linus/master.

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 15+ messages in thread

* drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
@ 2018-04-26 12:13 kbuild test robot
  2018-04-26 12:58 ` Mario.Limonciello
  0 siblings, 1 reply; 15+ messages in thread
From: kbuild test robot @ 2018-04-26 12:13 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: kbuild-all, linux-kernel, Darren Hart (VMware)

[-- Attachment #1: Type: text/plain, Size: 2697 bytes --]

Hi Mario,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   69bfd470f4623d2d57ad62cb33791cded0c662f4
commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
date:   7 weeks ago
config: x86_64-randconfig-v0-04261635 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
>> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

vim +99 drivers/platform/x86/dell-smbios-smm.c

549b4930 Mario Limonciello 2017-11-01   84  
549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct calling_interface_buffer *input)
549b4930 Mario Limonciello 2017-11-01   86  {
549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
549b4930 Mario Limonciello 2017-11-01   89  
549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct calling_interface_buffer);
549b4930 Mario Limonciello 2017-11-01   91  	command.magic = SMI_CMD_MAGIC;
549b4930 Mario Limonciello 2017-11-01   92  	command.command_address = da_command_address;
549b4930 Mario Limonciello 2017-11-01   93  	command.command_code = da_command_code;
549b4930 Mario Limonciello 2017-11-01   94  	command.ebx = virt_to_phys(buffer);
549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
549b4930 Mario Limonciello 2017-11-01   96  
549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01  102  	return 0;
549b4930 Mario Limonciello 2017-11-01  103  }
549b4930 Mario Limonciello 2017-11-01  104  

:::::: The code at line 99 was first introduced by commit
:::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls

:::::: TO: Mario Limonciello <mario.limonciello@dell.com>
:::::: CC: Darren Hart (VMware) <dvhart@infradead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26802 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
  2018-04-26 12:13 kbuild test robot
@ 2018-04-26 12:58 ` Mario.Limonciello
  0 siblings, 0 replies; 15+ messages in thread
From: Mario.Limonciello @ 2018-04-26 12:58 UTC (permalink / raw)
  To: lkp; +Cc: kbuild-all, linux-kernel, dvhart

This looks like the failure that was just fixed.

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: Thursday, April 26, 2018 7:14 AM
> To: Limonciello, Mario
> Cc: kbuild-all@01.org; linux-kernel@vger.kernel.org; Darren Hart (VMware)
> Subject: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> `dcdbas_smi_request'
> 
> Hi Mario,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   69bfd470f4623d2d57ad62cb33791cded0c662f4
> commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios:
> Link all dell-smbios-* modules together
> date:   7 weeks ago
> config: x86_64-randconfig-v0-04261635 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
> >> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to
> `dcdbas_smi_request'
> 
> vim +99 drivers/platform/x86/dell-smbios-smm.c
> 
> 549b4930 Mario Limonciello 2017-11-01   84
> 549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct
> calling_interface_buffer *input)
> 549b4930 Mario Limonciello 2017-11-01   86  {
> 549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
> 549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
> 549b4930 Mario Limonciello 2017-11-01   89
> 549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct
> calling_interface_buffer);
> 549b4930 Mario Limonciello 2017-11-01   91  	command.magic =
> SMI_CMD_MAGIC;
> 549b4930 Mario Limonciello 2017-11-01   92  	command.command_address =
> da_command_address;
> 549b4930 Mario Limonciello 2017-11-01   93  	command.command_code =
> da_command_code;
> 549b4930 Mario Limonciello 2017-11-01   94  	command.ebx =
> virt_to_phys(buffer);
> 549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
> 549b4930 Mario Limonciello 2017-11-01   96
> 549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
> 549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
> 549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
> 549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
> 549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
> 549b4930 Mario Limonciello 2017-11-01  102  	return 0;
> 549b4930 Mario Limonciello 2017-11-01  103  }
> 549b4930 Mario Limonciello 2017-11-01  104
> 
> :::::: The code at line 99 was first introduced by commit
> :::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios:
> Introduce dispatcher for SMM calls
> 
> :::::: TO: Mario Limonciello <mario.limonciello@dell.com>
> :::::: CC: Darren Hart (VMware) <dvhart@infradead.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 15+ messages in thread

* drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'
@ 2018-03-14  3:56 kbuild test robot
  0 siblings, 0 replies; 15+ messages in thread
From: kbuild test robot @ 2018-03-14  3:56 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: kbuild-all, linux-kernel, Darren Hart (VMware)

[-- Attachment #1: Type: text/plain, Size: 2645 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fc6eabbbf8ef99efed778dd5afabc83c21dba585
commit: 25d47027e1003546bfd8964b4423cb39bc2d53e9 platform/x86: dell-smbios: Link all dell-smbios-* modules together
date:   4 days ago
config: x86_64-randconfig-s4-03140942 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 25d47027e1003546bfd8964b4423cb39bc2d53e9
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/platform/x86/dell-smbios-smm.o: In function `dell_smbios_smm_call':
>> drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

vim +99 drivers/platform/x86/dell-smbios-smm.c

549b4930 Mario Limonciello 2017-11-01   84  
549b4930 Mario Limonciello 2017-11-01   85  int dell_smbios_smm_call(struct calling_interface_buffer *input)
549b4930 Mario Limonciello 2017-11-01   86  {
549b4930 Mario Limonciello 2017-11-01   87  	struct smi_cmd command;
549b4930 Mario Limonciello 2017-11-01   88  	size_t size;
549b4930 Mario Limonciello 2017-11-01   89  
549b4930 Mario Limonciello 2017-11-01   90  	size = sizeof(struct calling_interface_buffer);
549b4930 Mario Limonciello 2017-11-01   91  	command.magic = SMI_CMD_MAGIC;
549b4930 Mario Limonciello 2017-11-01   92  	command.command_address = da_command_address;
549b4930 Mario Limonciello 2017-11-01   93  	command.command_code = da_command_code;
549b4930 Mario Limonciello 2017-11-01   94  	command.ebx = virt_to_phys(buffer);
549b4930 Mario Limonciello 2017-11-01   95  	command.ecx = 0x42534931;
549b4930 Mario Limonciello 2017-11-01   96  
549b4930 Mario Limonciello 2017-11-01   97  	mutex_lock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01   98  	memcpy(buffer, input, size);
549b4930 Mario Limonciello 2017-11-01  @99  	dcdbas_smi_request(&command);
549b4930 Mario Limonciello 2017-11-01  100  	memcpy(input, buffer, size);
549b4930 Mario Limonciello 2017-11-01  101  	mutex_unlock(&smm_mutex);
549b4930 Mario Limonciello 2017-11-01  102  	return 0;
549b4930 Mario Limonciello 2017-11-01  103  }
549b4930 Mario Limonciello 2017-11-01  104  

:::::: The code at line 99 was first introduced by commit
:::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls

:::::: TO: Mario Limonciello <mario.limonciello@dell.com>
:::::: CC: Darren Hart (VMware) <dvhart@infradead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30428 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-05-12 20:04 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20  4:47 drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request' kbuild test robot
2018-03-20 23:24 ` Darren Hart
  -- strict thread matches above, loose matches on Subject: below --
2018-05-12  9:28 kbuild test robot
2018-05-12 18:32 ` Darren Hart
2018-05-12 18:51   ` Randy Dunlap
2018-05-12 19:15     ` Darren Hart
2018-05-12 20:04       ` Randy Dunlap
2018-05-04 18:24 kbuild test robot
2018-05-04 18:27 ` Mario.Limonciello
2018-05-04 20:08   ` dvhart
2018-05-04 20:15   ` Darren Hart
2018-05-06 22:29   ` Darren Hart
2018-04-26 12:13 kbuild test robot
2018-04-26 12:58 ` Mario.Limonciello
2018-03-14  3:56 kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).