* [PATCH] mt7601u: phy: mark expected switch fall-through
@ 2018-03-30 21:12 Gustavo A. R. Silva
2018-03-31 6:17 ` Jakub Kicinski
2018-04-24 17:28 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-30 21:12 UTC (permalink / raw)
To: Jakub Kicinski, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/wireless/mediatek/mt7601u/phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c
index ca09a5d..9a90f1f 100644
--- a/drivers/net/wireless/mediatek/mt7601u/phy.c
+++ b/drivers/net/wireless/mediatek/mt7601u/phy.c
@@ -795,6 +795,7 @@ mt7601u_phy_rf_pa_mode_val(struct mt7601u_dev *dev, int phy_mode, int tx_rate)
switch (phy_mode) {
case MT_PHY_TYPE_OFDM:
tx_rate += 4;
+ /* fall through */
case MT_PHY_TYPE_CCK:
reg = dev->rf_pa_mode[0];
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: phy: mark expected switch fall-through
2018-03-30 21:12 [PATCH] mt7601u: phy: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-03-31 6:17 ` Jakub Kicinski
2018-04-24 17:28 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2018-03-31 6:17 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel
On Fri, 30 Mar 2018 16:12:23 -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mt7601u: phy: mark expected switch fall-through
2018-03-30 21:12 [PATCH] mt7601u: phy: mark expected switch fall-through Gustavo A. R. Silva
2018-03-31 6:17 ` Jakub Kicinski
@ 2018-04-24 17:28 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-04-24 17:28 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jakub Kicinski, linux-wireless, netdev, linux-kernel,
Gustavo A. R. Silva
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
5156b054bcda mt7601u: phy: mark expected switch fall-through
--
https://patchwork.kernel.org/patch/10318419/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 21:12 [PATCH] mt7601u: phy: mark expected switch fall-through Gustavo A. R. Silva
2018-03-31 6:17 ` Jakub Kicinski
2018-04-24 17:28 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).