linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sky2: Increase D3 delay to sky2 stops working after suspend
@ 2018-03-31 15:42 Kai-Heng Feng
  2018-04-02  0:56 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2018-03-31 15:42 UTC (permalink / raw)
  To: mlindner, stephen; +Cc: netdev, linux-kernel, Kai-Heng Feng, Stable

The sky2 ethernet stops working after system resume from suspend:
[ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3

The current 150ms delay is not enough, change it to 200ms can solve the
issue.

BugLink: https://bugs.launchpad.net/bugs/1758507
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 9fe85300e7b6..5754116a6a4d 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	INIT_WORK(&hw->restart_work, sky2_restart);
 
 	pci_set_drvdata(pdev, hw);
-	pdev->d3_delay = 150;
+	pdev->d3_delay = 200;
 
 	return 0;
 
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sky2: Increase D3 delay to sky2 stops working after suspend
  2018-03-31 15:42 [PATCH] sky2: Increase D3 delay to sky2 stops working after suspend Kai-Heng Feng
@ 2018-04-02  0:56 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-04-02  0:56 UTC (permalink / raw)
  To: kai.heng.feng; +Cc: mlindner, stephen, netdev, linux-kernel, stable

From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Sat, 31 Mar 2018 23:42:03 +0800

> The sky2 ethernet stops working after system resume from suspend:
> [ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3
> 
> The current 150ms delay is not enough, change it to 200ms can solve the
> issue.
> 
> BugLink: https://bugs.launchpad.net/bugs/1758507
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-02  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-31 15:42 [PATCH] sky2: Increase D3 delay to sky2 stops working after suspend Kai-Heng Feng
2018-04-02  0:56 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).