From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>, 刘炜 <liuwei@actions-semi.com>,
mp-cs@actions-semi.com, 96boards@ucrobotics.com,
devicetree <devicetree@vger.kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
amit.kucheria@linaro.org,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
hzhang@ucrobotics.com, bdong@ucrobotics.com,
"Mani Sadhasivam" <manivannanece23@gmail.com>
Subject: Re: [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver
Date: Tue, 3 Apr 2018 22:44:01 +0530 [thread overview]
Message-ID: <20180403171401.etcvqe4xrkcl7sbh@linaro.org> (raw)
In-Reply-To: <d86b21a7-e269-6c27-c0e7-d46bee8e5c1d@suse.de>
On Tue, Apr 03, 2018 at 07:03:46PM +0200, Andreas Färber wrote:
> Hi Mani,
>
> Am 03.04.2018 um 19:00 schrieb Manivannan Sadhasivam:
> > On Sat, Mar 31, 2018 at 12:16:49AM +0300, Andy Shevchenko wrote:
> >> On Wed, Mar 28, 2018 at 8:46 PM, Manivannan Sadhasivam
> >> <manivannan.sadhasivam@linaro.org> wrote:
> >>> +static const struct pinconf_ops owl_pinconf_ops = {
> >>> + .is_generic = true,
> >>> + .pin_config_get = owl_pin_config_get,
> >>> + .pin_config_set = owl_pin_config_set,
> >>> + .pin_config_group_get = owl_group_config_get,
> >>> + .pin_config_group_set = owl_group_config_set
> >>
> >> It's still good idea to leave comma here...
> >>
> >
> > I'm confused. What is the criteria for removing/keeping comma for last member
> > of struct? I followed your gpio driver suggestion.
>
> No comma for list terminator ("{}") because nothing goes after it; comma
> whenever it allows adding a new line without touching the old one, i.e.
> keeping future diff small.
>
Thanks for the clarification Andreas! Keeping the future diff small is the
key, understood.
Thanks,
Mani
> Cheers,
> Andreas
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-04-03 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 17:46 [PATCH v6 0/9] Add Actions Semi S900 pinctrl and gpio support Manivannan Sadhasivam
2018-03-28 17:46 ` [PATCH v6 1/9] arm64: dts: actions: Add pinctrl node for S900 Manivannan Sadhasivam
2018-03-28 17:46 ` [PATCH v6 2/9] arm64: actions: Enable PINCTRL in platforms Kconfig Manivannan Sadhasivam
2018-03-28 17:46 ` [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver Manivannan Sadhasivam
2018-03-30 21:16 ` Andy Shevchenko
2018-04-03 17:00 ` Manivannan Sadhasivam
2018-04-03 17:03 ` Andreas Färber
2018-04-03 17:14 ` Manivannan Sadhasivam [this message]
2018-04-06 14:01 ` Andy Shevchenko
2018-03-28 17:46 ` [PATCH v6 4/9] dt-bindings: gpio: Add gpio nodes for Actions S900 SoC Manivannan Sadhasivam
2018-04-12 8:54 ` Linus Walleij
2018-03-28 17:46 ` [PATCH v6 5/9] arm64: dts: actions: Add S900 gpio nodes Manivannan Sadhasivam
2018-03-28 17:47 ` [PATCH v6 6/9] arm64: dts: actions: Add gpio line names to Bubblegum-96 board Manivannan Sadhasivam
2018-03-28 17:47 ` [PATCH v6 7/9] gpio: Add gpio driver for Actions OWL S900 SoC Manivannan Sadhasivam
2018-03-30 21:04 ` Andy Shevchenko
2018-03-28 17:47 ` [PATCH v6 8/9] MAINTAINERS: Add reviewer for ACTIONS platforms Manivannan Sadhasivam
2018-03-28 17:47 ` [PATCH v6 9/9] MAINTAINERS: Add Actions Semi S900 pinctrl and gpio entries Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403171401.etcvqe4xrkcl7sbh@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=96boards@ucrobotics.com \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=bdong@ucrobotics.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hzhang@ucrobotics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannanece23@gmail.com \
--cc=mp-cs@actions-semi.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).