* [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
@ 2018-04-06 1:43 Wenhua Shi
2018-04-08 16:51 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Wenhua Shi @ 2018-04-06 1:43 UTC (permalink / raw)
Cc: David S. Miller, netdev, linux-kernel
Signed-off-by: Wenhua Shi <march511@gmail.com>
---
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index cf44503e..1f26cbcf 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4187,7 +4187,7 @@ static inline bool net_gso_ok(netdev_features_t features, int gso_type)
BUILD_BUG_ON(SKB_GSO_ESP != (NETIF_F_GSO_ESP >> NETIF_F_GSO_SHIFT));
BUILD_BUG_ON(SKB_GSO_UDP != (NETIF_F_GSO_UDP >> NETIF_F_GSO_SHIFT));
- return (features & feature) == feature;
+ return feature && (features & feature) == feature;
}
static inline bool skb_gso_ok(struct sk_buff *skb, netdev_features_t features)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
2018-04-06 1:43 [PATCH] make net_gso_ok return false when gso_type is zero(invalid) Wenhua Shi
@ 2018-04-08 16:51 ` David Miller
2018-04-08 18:41 ` Wenhua Shi
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2018-04-08 16:51 UTC (permalink / raw)
To: march511; +Cc: netdev, linux-kernel
From: Wenhua Shi <march511@gmail.com>
Date: Fri, 6 Apr 2018 03:43:39 +0200
> Signed-off-by: Wenhua Shi <march511@gmail.com>
This precondition should be made impossible instead of having to do
an extra check everywhere that this helper is invoked, many of which
are in fast paths.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
2018-04-08 16:51 ` David Miller
@ 2018-04-08 18:41 ` Wenhua Shi
2018-04-10 16:32 ` Marcelo Ricardo Leitner
0 siblings, 1 reply; 6+ messages in thread
From: Wenhua Shi @ 2018-04-08 18:41 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
2018-04-08 18:51 GMT+02:00 David Miller <davem@davemloft.net>:
>
> From: Wenhua Shi <march511@gmail.com>
> Date: Fri, 6 Apr 2018 03:43:39 +0200
>
> > Signed-off-by: Wenhua Shi <march511@gmail.com>
>
> This precondition should be made impossible instead of having to do
> an extra check everywhere that this helper is invoked, many of which
> are in fast paths.
I believe the precondition you said is quite true. In my situation, I
have to disable GSO for some packet and I notice that it leads to a
worse performance (slower than 1Mbps, was almost 800Mbps).
Here's the hook I use on debian 9.4, kernel version 4.9:
#include <linux/init.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/netfilter.h>
#include <linux/netfilter_ipv4.h>
#include <linux/netfilter_ipv6.h>
#include <linux/skbuff.h>
#include <linux/tcp.h>
#include <linux/ip.h>
unsigned int hook_outgoing (
void * priv,
struct sk_buff * skb,
const struct nf_hook_state * state)
{
/* for some reason I have to disable GSO */
skb_gso_reset(skb);
/* After I force sk_can_gso to return false here, the
performance comes back normal. */
// skb->sk->sk_gso_type = ~0;
return NF_ACCEPT;
}
static struct nf_hook_ops hook =
{
.hook = hook_outgoing,
.pf = PF_INET,
.hooknum = NF_INET_POST_ROUTING,
.priority = NF_IP_PRI_LAST,
};
static int __init init_testing(void)
{
nf_register_hook(&hook);
return 0;
}
static void __exit exit_testing(void)
{
nf_unregister_hook(&hook);
}
module_init(init_testing);
module_exit(exit_testing);
Here are the performance measurements.
Without the previous hook:
root@debian-s-1vcpu-1gb-sfo1-01:~/test# iperf -c myanothernormaldebian -d
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 85.3 KByte (default)
------------------------------------------------------------
------------------------------------------------------------
Client connecting to myanothernormaldebian, TCP port 5001
TCP window size: 255 KByte (default)
------------------------------------------------------------
[ 3] local 192.241.204.XXX port 60528 connected with
104.131.148.XXX port 5001
[ 5] local 192.241.204.XXX port 5001 connected with
104.131.148.XXX port 58576
[ ID] Interval Transfer Bandwidth
[ 3] 0.0-10.0 sec 922 MBytes 773 Mbits/sec
[ 5] 0.0-10.1 sec 1.00 GBytes 849 Mbits/sec
And with the previous hook:
root@debian-s-1vcpu-1gb-sfo1-01:~/test# iperf -c myanothernormaldebian -d
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 85.3 KByte (default)
------------------------------------------------------------
------------------------------------------------------------
Client connecting to myanothernormaldebian, TCP port 5001
TCP window size: 85.0 KByte (default)
------------------------------------------------------------
[ 3] local 192.241.204.XXX port 60530 connected with
104.131.148.XXX port 5001
[ 5] local 192.241.204.XXX port 5001 connected with
104.131.148.XXX port 58578
[ ID] Interval Transfer Bandwidth
[ 5] 0.0-10.2 sec 1.02 GBytes 864 Mbits/sec
[ 3] 0.0-13.5 sec 170 KBytes 103 Kbits/sec
Or it's just because of that I'm disabling the GSO in a wrong way?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
2018-04-08 18:41 ` Wenhua Shi
@ 2018-04-10 16:32 ` Marcelo Ricardo Leitner
2018-04-11 0:51 ` Wenhua Shi
0 siblings, 1 reply; 6+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-04-10 16:32 UTC (permalink / raw)
To: Wenhua Shi; +Cc: David Miller, netdev, linux-kernel
On Sun, Apr 08, 2018 at 08:41:21PM +0200, Wenhua Shi wrote:
> 2018-04-08 18:51 GMT+02:00 David Miller <davem@davemloft.net>:
> >
> > From: Wenhua Shi <march511@gmail.com>
> > Date: Fri, 6 Apr 2018 03:43:39 +0200
> >
> > > Signed-off-by: Wenhua Shi <march511@gmail.com>
> >
> > This precondition should be made impossible instead of having to do
> > an extra check everywhere that this helper is invoked, many of which
> > are in fast paths.
>
> I believe the precondition you said is quite true. In my situation, I
> have to disable GSO for some packet and I notice that it leads to a
> worse performance (slower than 1Mbps, was almost 800Mbps).
>
> Here's the hook I use on debian 9.4, kernel version 4.9:
There is quite a distance between 4.9 and net/net-next. Did you test
on a more recent kernel too?
Note that TCP stack now works with GSO being always on.
0a6b2a1dc2a2 ("tcp: switch to GSO being always on")
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
2018-04-10 16:32 ` Marcelo Ricardo Leitner
@ 2018-04-11 0:51 ` Wenhua Shi
2018-04-11 13:59 ` Wenhua Shi
0 siblings, 1 reply; 6+ messages in thread
From: Wenhua Shi @ 2018-04-11 0:51 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: David Miller, netdev, linux-kernel
2018-04-10 18:32 GMT+02:00 Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>:
> On Sun, Apr 08, 2018 at 08:41:21PM +0200, Wenhua Shi wrote:
>> 2018-04-08 18:51 GMT+02:00 David Miller <davem@davemloft.net>:
>> >
>> > From: Wenhua Shi <march511@gmail.com>
>> > Date: Fri, 6 Apr 2018 03:43:39 +0200
>> >
>> > > Signed-off-by: Wenhua Shi <march511@gmail.com>
>> >
>> > This precondition should be made impossible instead of having to do
>> > an extra check everywhere that this helper is invoked, many of which
>> > are in fast paths.
>>
>> I believe the precondition you said is quite true. In my situation, I
>> have to disable GSO for some packet and I notice that it leads to a
>> worse performance (slower than 1Mbps, was almost 800Mbps).
>>
>> Here's the hook I use on debian 9.4, kernel version 4.9:
>
> There is quite a distance between 4.9 and net/net-next. Did you test
> on a more recent kernel too?
>
> Note that TCP stack now works with GSO being always on.
> 0a6b2a1dc2a2 ("tcp: switch to GSO being always on")
>
I've tried testing on the Fedora rawhide channel. The kernel version
is 4.17.0. Detail information is attached.
Without the hook
[root@fedora-s-1vcpu-1gb-sfo1-01 testing]# iperf -c
myanothernormalmachine -d
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 85.3 KByte (default)
------------------------------------------------------------
------------------------------------------------------------
Client connecting to myanothernormalmachine, TCP port 5001
TCP window size: 85.0 KByte (default)
------------------------------------------------------------
[ 3] local 107.170.240.XXX port 44692 connected with
104.131.148.XXX port 5001
[ 5] local 107.170.240.XXX port 5001 connected with
104.131.148.XXX port 53978
[ ID] Interval Transfer Bandwidth
[ 3] 0.0-10.0 sec 1.04 GBytes 892 Mbits/sec
[ 5] 0.0-10.0 sec 757 MBytes 638 Mbits/sec
With the hook
[root@fedora-s-1vcpu-1gb-sfo1-01 testing]# iperf -c
myanothernormalmachine -d
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 85.3 KByte (default)
------------------------------------------------------------
------------------------------------------------------------
Client connecting to myanothernormalmachine, TCP port 5001
TCP window size: 85.0 KByte (default)
------------------------------------------------------------
[ 3] local 107.170.240.XXX port 44694 connected with
104.131.148.XXX port 5001
[ 5] local 107.170.240.XXX port 5001 connected with
104.131.148.XXX port 53980
[ ID] Interval Transfer Bandwidth
[ 5] 0.0-10.0 sec 1.04 GBytes 894 Mbits/sec
[ 3] 0.0-13.5 sec 170 KBytes 103 Kbits/sec
Kernel
[root@fedora-s-1vcpu-1gb-sfo1-01 testing]# uname -a
Linux fedora-s-1vcpu-1gb-sfo1-01.localdomain
4.17.0-0.rc0.git5.2.fc29.x86_64 #1 SMP Mon Apr 9 17:16:30 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux
Hook Source Code
[root@fedora-s-1vcpu-1gb-sfo1-01 testing]# cat testing.c
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/netfilter.h>
#include <linux/netfilter_ipv4.h>
#include <linux/netfilter_ipv6.h>
#include <linux/skbuff.h>
#include <linux/tcp.h>
#include <linux/ip.h>
unsigned int hook_outgoing(
void * priv,
struct sk_buff * skb,
const struct nf_hook_state * state)
{
printk(KERN_INFO "Hook working...\n");
/* for some reason I have to disable GSO */
skb_gso_reset(skb);
/* The following won't work any more. */
// skb->sk->sk_gso_type = ~0;
return NF_ACCEPT;
}
static struct nf_hook_ops hook =
{
.hook = hook_outgoing,
.pf = PF_INET,
.hooknum = NF_INET_POST_ROUTING,
.priority = NF_IP_PRI_LAST,
};
static int __init init_testing(void)
{
nf_register_net_hook(&init_net, &hook);
return 0;
}
static void __exit exit_testing(void)
{
nf_unregister_net_hook(&init_net, &hook);
}
MODULE_LICENSE("GPL");
module_init(init_testing);
module_exit(exit_testing);
It turns out the problem exists and my previous bypassing trick is not
working any more. I'm now testing whether the patch is working for the
latest net-next branch.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)
2018-04-11 0:51 ` Wenhua Shi
@ 2018-04-11 13:59 ` Wenhua Shi
0 siblings, 0 replies; 6+ messages in thread
From: Wenhua Shi @ 2018-04-11 13:59 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: David Miller, netdev, linux-kernel
> Note that TCP stack now works with GSO being always on.
> 0a6b2a1dc2a2 ("tcp: switch to GSO being always on")
I've tested on the latest net-next branch
17dec0a949153d9ac00760ba2f5b78cb583e995f. The problem still exists. My
patch won't work. Reverting commit 0a6b2a1dc2a2 won't help.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-11 14:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-06 1:43 [PATCH] make net_gso_ok return false when gso_type is zero(invalid) Wenhua Shi
2018-04-08 16:51 ` David Miller
2018-04-08 18:41 ` Wenhua Shi
2018-04-10 16:32 ` Marcelo Ricardo Leitner
2018-04-11 0:51 ` Wenhua Shi
2018-04-11 13:59 ` Wenhua Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).