* [PATCH] media: vcodec: fix ptr_ret.cocci warnings
2018-04-11 21:14 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
@ 2018-04-11 21:14 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-04-11 21:14 UTC (permalink / raw)
To: Ryder Lee
Cc: kbuild-all, linux-kernel, Mauro Carvalho Chehab, linux-media,
Matthias Brugger, Hans Verkuil, Rick Chang, Bin Liu,
linux-arm-kernel, linux-mediatek
From: Fengguang Wu <fengguang.wu@intel.com>
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 648a9576932a ("media: vcodec: fix error return value from mtk_jpeg_clk_init()")
CC: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
mtk_jpeg_core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1084,10 +1084,7 @@ static int mtk_jpeg_clk_init(struct mtk_
return PTR_ERR(jpeg->clk_jdec);
jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
- if (IS_ERR(jpeg->clk_jdec_smi))
- return PTR_ERR(jpeg->clk_jdec_smi);
-
- return 0;
+ return PTR_ERR_OR_ZERO(jpeg->clk_jdec_smi);
}
static int mtk_jpeg_probe(struct platform_device *pdev)
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used
@ 2018-04-11 21:14 kbuild test robot
2018-04-11 21:14 ` [PATCH] media: vcodec: fix ptr_ret.cocci warnings kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-04-11 21:14 UTC (permalink / raw)
To: Ryder Lee
Cc: kbuild-all, linux-kernel, Mauro Carvalho Chehab, linux-media,
Matthias Brugger, Hans Verkuil
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8837c70d531a1788f975c366c254a5cb973a5291
commit: 648a9576932a26e1c6a157b4c9345204de975957 media: vcodec: fix error return value from mtk_jpeg_clk_init()
date: 7 days ago
coccinelle warnings: (new ones prefixed by >>)
>> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-11 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 21:14 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
2018-04-11 21:14 ` [PATCH] media: vcodec: fix ptr_ret.cocci warnings kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).