linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf tests: Disable breakpoint accounting test for powerpc
@ 2018-04-12 16:21 Sandipan Das
  2018-04-12 17:20 ` Arnaldo Carvalho de Melo
  2018-04-16  6:47 ` [tip:perf/urgent] " tip-bot for Sandipan Das
  0 siblings, 2 replies; 3+ messages in thread
From: Sandipan Das @ 2018-04-12 16:21 UTC (permalink / raw)
  To: acme, jolsa; +Cc: linux-kernel, naveen.n.rao, ravi.bangoria

We disable this test as instruction breakpoints (HW_BREAKPOINT_X)
are not available for powerpc.

Before applying patch:

21: Breakpoint accounting                                 :
--- start ---
test child forked, pid 3635
failed opening event 0
failed opening event 0
watchpoints count 1, breakpoints count 0, has_ioctl 1, share 0
test child finished with -2
---- end ----
Breakpoint accounting: Skip

After applying patch:

21: Breakpoint accounting                                 : Disabled

Signed-off-by: Sandipan Das <sandipan@linux.vnet.ibm.com>
---
 tools/perf/tests/builtin-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 625f5a6772af..cac8f8889bc3 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -118,6 +118,7 @@ static struct test generic_tests[] = {
 	{
 		.desc = "Breakpoint accounting",
 		.func = test__bp_accounting,
+		.is_supported = test__bp_signal_is_supported,
 	},
 	{
 		.desc = "Number of exit events of a simple workload",
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tests: Disable breakpoint accounting test for powerpc
  2018-04-12 16:21 [PATCH] perf tests: Disable breakpoint accounting test for powerpc Sandipan Das
@ 2018-04-12 17:20 ` Arnaldo Carvalho de Melo
  2018-04-16  6:47 ` [tip:perf/urgent] " tip-bot for Sandipan Das
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-04-12 17:20 UTC (permalink / raw)
  To: Sandipan Das; +Cc: jolsa, linux-kernel, naveen.n.rao, ravi.bangoria

Em Thu, Apr 12, 2018 at 09:51:40PM +0530, Sandipan Das escreveu:
> We disable this test as instruction breakpoints (HW_BREAKPOINT_X)
> are not available for powerpc.

Thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/urgent] perf tests: Disable breakpoint accounting test for powerpc
  2018-04-12 16:21 [PATCH] perf tests: Disable breakpoint accounting test for powerpc Sandipan Das
  2018-04-12 17:20 ` Arnaldo Carvalho de Melo
@ 2018-04-16  6:47 ` tip-bot for Sandipan Das
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Sandipan Das @ 2018-04-16  6:47 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, naveen.n.rao, ravi.bangoria, mingo, jolsa, linux-kernel,
	tglx, hpa, sandipan

Commit-ID:  4b163ca343b45855b03114ef2ab47c454989d55c
Gitweb:     https://git.kernel.org/tip/4b163ca343b45855b03114ef2ab47c454989d55c
Author:     Sandipan Das <sandipan@linux.vnet.ibm.com>
AuthorDate: Thu, 12 Apr 2018 21:51:40 +0530
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 12 Apr 2018 14:20:21 -0300

perf tests: Disable breakpoint accounting test for powerpc

We disable this test as instruction breakpoints (HW_BREAKPOINT_X) are
not available for powerpc.

Before applying patch:

  21: Breakpoint accounting                                 :
  --- start ---
  test child forked, pid 3635
  failed opening event 0
  failed opening event 0
  watchpoints count 1, breakpoints count 0, has_ioctl 1, share 0
  test child finished with -2
  ---- end ----
  Breakpoint accounting: Skip

After applying patch:

  21: Breakpoint accounting                                 : Disabled

Signed-off-by: Sandipan Das <sandipan@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20180412162140.2992-1-sandipan@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/builtin-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 625f5a6772af..cac8f8889bc3 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -118,6 +118,7 @@ static struct test generic_tests[] = {
 	{
 		.desc = "Breakpoint accounting",
 		.func = test__bp_accounting,
+		.is_supported = test__bp_signal_is_supported,
 	},
 	{
 		.desc = "Number of exit events of a simple workload",

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-16  6:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 16:21 [PATCH] perf tests: Disable breakpoint accounting test for powerpc Sandipan Das
2018-04-12 17:20 ` Arnaldo Carvalho de Melo
2018-04-16  6:47 ` [tip:perf/urgent] " tip-bot for Sandipan Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).