Re: [PATCH] proc: fixup (c) sign

Re: [PATCH] proc: fixup (c) sign

[Linus Torvalds]

On Wed, Apr 11, 2018 at 1:19 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Andrew's scripts butchered it :-(

Oh, it's not just Andrew.

Git will fix up commit messages etc, but the actual *patch* will be
considered just "data". So if you send me Latin1 (like you did), I get
a patch with Latin1.

Please just fix your broken mail environment, and move to the current
century. Use a real utf-8 locale.

You seem to be using Mutt. Afaik, that should automatically honor your
locale, and use utf-8,

But maybe you have it trying to send in Latin1 by default if that
works. Just do something like

    set file_charset="utf-8:iso-8859-1"

to make utf-8 the preferred format.

              Linus

Re: [PATCH] proc: fixup (c) sign

[Alexey Dobriyan]

On Thu, Apr 12, 2018 at 10:14:35AM -0700, Linus Torvalds wrote:
> On Wed, Apr 11, 2018 at 1:19 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > Andrew's scripts butchered it :-(
> 
> Oh, it's not just Andrew.
> 
> Git will fix up commit messages etc, but the actual *patch* will be
> considered just "data". So if you send me Latin1 (like you did), I get
> a patch with Latin1.
> 
> Please just fix your broken mail environment, and move to the current
> century. Use a real utf-8 locale.
> 
> You seem to be using Mutt. Afaik, that should automatically honor your
> locale, and use utf-8,
> 
> But maybe you have it trying to send in Latin1 by default if that
> works. Just do something like
> 
>     set file_charset="utf-8:iso-8859-1"
> 
> to make utf-8 the preferred format.

I've checked earlier mails, mutt has been "guessing" outgoing encoding
by default. Let's try again.

[PATCH v3] proc: fixup copyright sign

[Alexey Dobriyan]

Add copyright in two files before they get autorubberstamped.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 tools/testing/selftests/proc/proc-loadavg-001.c        |    2 +-
 tools/testing/selftests/proc/proc-self-map-files-001.c |    2 +-
 tools/testing/selftests/proc/proc-self-map-files-002.c |    2 +-
 tools/testing/selftests/proc/proc-self-syscall.c       |   15 +++++++++++++++
 tools/testing/selftests/proc/proc-self-wchan.c         |   15 +++++++++++++++
 tools/testing/selftests/proc/proc-uptime-001.c         |    2 +-
 tools/testing/selftests/proc/proc-uptime-002.c         |    2 +-
 tools/testing/selftests/proc/proc-uptime.h             |    2 +-
 tools/testing/selftests/proc/read.c                    |    2 +-
 9 files changed, 37 insertions(+), 7 deletions(-)

--- a/tools/testing/selftests/proc/proc-loadavg-001.c
+++ b/tools/testing/selftests/proc/proc-loadavg-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-map-files-001.c
+++ b/tools/testing/selftests/proc/proc-self-map-files-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-map-files-002.c
+++ b/tools/testing/selftests/proc/proc-self-map-files-002.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-syscall.c
+++ b/tools/testing/selftests/proc/proc-self-syscall.c
@@ -1,3 +1,18 @@
+/*
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
 #define _GNU_SOURCE
 #include <unistd.h>
 #include <sys/syscall.h>
--- a/tools/testing/selftests/proc/proc-self-wchan.c
+++ b/tools/testing/selftests/proc/proc-self-wchan.c
@@ -1,3 +1,18 @@
+/*
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
--- a/tools/testing/selftests/proc/proc-uptime-001.c
+++ b/tools/testing/selftests/proc/proc-uptime-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-uptime-002.c
+++ b/tools/testing/selftests/proc/proc-uptime-002.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-uptime.h
+++ b/tools/testing/selftests/proc/proc-uptime.h
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/read.c
+++ b/tools/testing/selftests/proc/read.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above

Re: [PATCH] proc: fixup (c) sign

[Linus Torvalds]

On Thu, Apr 12, 2018 at 12:50 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> I've checked earlier mails, mutt has been "guessing" outgoing encoding
> by default. Let's try again.

I think it still does. This email came with

    Content-Type: text/plain; charset=us-ascii

which is what I'd expect if Mutt has a "use the least complex charset
that can fit the message".

If you look at my emails, you should see

    Content-Type: text/plain; charset="UTF-8"

even for an email like this, that only has 7-bit ascii.

I'm not a Mutt user, so I don't know what the magic is for "just force
utf-8 when sending".

For alpine, it's

    posting-character-set=UTF-8

in the .pinerc file.

For gmail there used to be an "outgoing message encoding" setting, but
it seems to have been removed (and now utf-8 is always on).

             Linus

[PATCH v4] proc: fixup copyright sign

[Alexey Dobriyan]

Add copyright in two files before they get autorubberstamped.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 tools/testing/selftests/proc/proc-loadavg-001.c        |    2 +-
 tools/testing/selftests/proc/proc-self-map-files-001.c |    2 +-
 tools/testing/selftests/proc/proc-self-map-files-002.c |    2 +-
 tools/testing/selftests/proc/proc-self-syscall.c       |   15 +++++++++++++++
 tools/testing/selftests/proc/proc-self-wchan.c         |   15 +++++++++++++++
 tools/testing/selftests/proc/proc-uptime-001.c         |    2 +-
 tools/testing/selftests/proc/proc-uptime-002.c         |    2 +-
 tools/testing/selftests/proc/proc-uptime.h             |    2 +-
 tools/testing/selftests/proc/read.c                    |    2 +-
 9 files changed, 37 insertions(+), 7 deletions(-)

--- a/tools/testing/selftests/proc/proc-loadavg-001.c
+++ b/tools/testing/selftests/proc/proc-loadavg-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-map-files-001.c
+++ b/tools/testing/selftests/proc/proc-self-map-files-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-map-files-002.c
+++ b/tools/testing/selftests/proc/proc-self-map-files-002.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-self-syscall.c
+++ b/tools/testing/selftests/proc/proc-self-syscall.c
@@ -1,3 +1,18 @@
+/*
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
 #define _GNU_SOURCE
 #include <unistd.h>
 #include <sys/syscall.h>
--- a/tools/testing/selftests/proc/proc-self-wchan.c
+++ b/tools/testing/selftests/proc/proc-self-wchan.c
@@ -1,3 +1,18 @@
+/*
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
--- a/tools/testing/selftests/proc/proc-uptime-001.c
+++ b/tools/testing/selftests/proc/proc-uptime-001.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-uptime-002.c
+++ b/tools/testing/selftests/proc/proc-uptime-002.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/proc-uptime.h
+++ b/tools/testing/selftests/proc/proc-uptime.h
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
--- a/tools/testing/selftests/proc/read.c
+++ b/tools/testing/selftests/proc/read.c
@@ -1,5 +1,5 @@
 /*
- * Copyright _ 2018 Alexey Dobriyan <adobriyan@gmail.com>
+ * Copyright © 2018 Alexey Dobriyan <adobriyan@gmail.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above

Re: [PATCH v4] proc: fixup copyright sign

[Linus Torvalds]

Yup, this came through correctly:

  Content-Type: text/plain; charset=utf-8

and the patch looks fine too.

             Linus

Re: [PATCH] proc: fixup (c) sign

[Al Viro]

On Wed, Apr 11, 2018 at 03:41:26PM -0700, Linus Torvalds wrote:
> On Wed, Apr 11, 2018 at 1:24 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > It got sent from here as iso8859-1.
> 
> It's probably a good idea to just move away from Latin1 entirely, and
> encourage people to just use utf-8.
> 
> But yes, Andrew's scripts clearly do a horrible job at looking at
> email encoding, and that really should be fixed.
> 
> I worry less about silly copyright signs than about peoples actual
> _names_, but we've certainly seen problems there too.

FWIW, excluding the stuff obviously not in UTF8 (logo.gif and 
tools/power/cpupower/po/{de,fr}.po) we have

lib/fonts/font_7x14.c
lib/fonts/font_8x16.c
lib/fonts/font_8x8.c
lib/fonts/font_pearl_8x8.c
arch/s390/kernel/ebcdic.c
	crap in comments
arch/m68k/hp300/hp300map.map
drivers/tty/vt/defkeymap.map
	non-UTF8 - literals for compose statements
arch/arm/crypto/sha256_glue.c
arch/arm/crypto/sha256_neon_glue.c
kernel/events/callchain.c
	Latin1 copyright symbol (0xa9)
drivers/staging/rtl8188eu/include/odm.h
	Latin1 inverted ! (0xa1)
Documentation/devicetree/bindings/net/nfc/pn544.txt
	Latin1 superscript 2 (0xb2), in I²C
arch/arm/boot/dts/sun4i-a10-inet97fv2.dts
	Latin1 o-umlaut (0xf6) in David Lanzendörfer
drivers/crypto/vmx/ghashp8-ppc.pl
	a bunch of Latin1 middle dots (0xb7), in comments inside string constant
used to produce asm output, no less
drivers/gpu/drm/amd/include/atombios.h
	several U+FFFD in there - buggered conversion to UTF8?
drivers/gpu/drm/r128/r128_drv.h
	ditto, but here it's possible to figure out what got buggered -
Michel D�zer <daenzerm@student.ethz.ch> that presumably should've been "Dänzer"
drivers/iio/dac/ltc2632.c
	Latin1 e-acute in Maxime Roussin-Bélanger
drivers/power/reset/ltc2952-poweroff.c
	ditto in René Moll
drivers/spi/spi-omap-100k.c
	a couple of U+FFFD in Juha Yrjölä <juha.yrjola@nokia.com> - o- and a-umlaut
In this case the actual spelling is trivially googled.
drivers/spi/spi-omap2-mcspi.c
	ditto
drivers/usb/misc/iowarrior.c
	U+FFFD in Stéphane Doyon <s.doyon@videotron.ca> - e-acute
drivers/visorbus/visorbus_main.c
	U+FFFD in place of copyright symbol

Re: [PATCH] proc: fixup (c) sign

[Andrew Morton]

On Wed, 11 Apr 2018 15:41:26 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, Apr 11, 2018 at 1:24 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > It got sent from here as iso8859-1.
> 
> It's probably a good idea to just move away from Latin1 entirely, and
> encourage people to just use utf-8.

I had "set ttycharset=utf8" in .mailrc and when presented with Alexey's
patch heirloom-mailx said "Failed to create encoded message: Invalid or
incomplete multibyte or wide character".

After removing that line from .mailrc, hairloom-mailx did the offending
corruption.

Adding "set ttycharset=iso8859-1" to .mailrc permits Alexey's patch to
go through as-is.  But I assume it has broken something else :(

> But yes, Andrew's scripts clearly do a horrible job at looking at
> email encoding, and that really should be fixed.
> 
> I worry less about silly copyright signs than about peoples actual
> _names_, but we've certainly seen problems there too.

That's all fixed, afaik.

Re: [PATCH] proc: fixup (c) sign

[Linus Torvalds]

On Wed, Apr 11, 2018 at 1:24 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> It got sent from here as iso8859-1.

It's probably a good idea to just move away from Latin1 entirely, and
encourage people to just use utf-8.

But yes, Andrew's scripts clearly do a horrible job at looking at
email encoding, and that really should be fixed.

I worry less about silly copyright signs than about peoples actual
_names_, but we've certainly seen problems there too.

                 Linus