linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7d-sdb: add gpio key support
@ 2018-03-16  8:54 Anson Huang
  2018-03-16 10:28 ` A.s. Dong
  2018-04-16 13:54 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Anson Huang @ 2018-03-16  8:54 UTC (permalink / raw)
  To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland, linux
  Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel

Add support for imx7d-sdb board's gpio keys:

S1(FUNC1): KEY_VOLUMEUP
S3(FUNC2): KEY_VOLUMEDOWN

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx7d-sdb.dts | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index 7f241af..e47b5b2 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -52,6 +52,24 @@
 		reg = <0x80000000 0x80000000>;
 	};
 
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_keys>;
+
+		volume-up {
+			label = "Volume Up";
+			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+		};
+
+		volume-down {
+			label = "Volume Down";
+			gpios = <&gpio5 10 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEDOWN>;
+		};
+	};
+
 	spi4 {
 		compatible = "spi-gpio";
 		pinctrl-names = "default";
@@ -519,6 +537,12 @@
 			>;
 		};
 
+		pinctrl_gpio_keys: gpio_keysgrp {
+			fsl,pins = <
+				MX7D_PAD_SD2_RESET_B__GPIO5_IO11	0x59
+				MX7D_PAD_SD2_WP__GPIO5_IO10		0x59
+			>;
+		};
 
 		pinctrl_hog: hoggrp {
 			fsl,pins = <
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
  2018-03-16  8:54 [PATCH] ARM: dts: imx7d-sdb: add gpio key support Anson Huang
@ 2018-03-16 10:28 ` A.s. Dong
  2018-04-16  8:25   ` Anson Huang
  2018-04-16 13:54 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: A.s. Dong @ 2018-03-16 10:28 UTC (permalink / raw)
  To: Anson Huang, shawnguo, kernel, Fabio Estevam, robh+dt,
	mark.rutland, linux
  Cc: dl-linux-imx, linux-arm-kernel, devicetree, linux-kernel

> -----Original Message-----
> From: Anson Huang [mailto:Anson.Huang@nxp.com]
> Sent: Friday, March 16, 2018 4:55 PM
> To: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam
> <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
> linux@armlinux.org.uk
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
> 
> Add support for imx7d-sdb board's gpio keys:
> 
> S1(FUNC1): KEY_VOLUMEUP
> S3(FUNC2): KEY_VOLUMEDOWN
> 

Acked-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Dong Aisheng

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm/boot/dts/imx7d-sdb.dts | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-
> sdb.dts index 7f241af..e47b5b2 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -52,6 +52,24 @@
>  		reg = <0x80000000 0x80000000>;
>  	};
> 
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_keys>;
> +
> +		volume-up {
> +			label = "Volume Up";
> +			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +		};
> +
> +		volume-down {
> +			label = "Volume Down";
> +			gpios = <&gpio5 10 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEDOWN>;
> +		};
> +	};
> +
>  	spi4 {
>  		compatible = "spi-gpio";
>  		pinctrl-names = "default";
> @@ -519,6 +537,12 @@
>  			>;
>  		};
> 
> +		pinctrl_gpio_keys: gpio_keysgrp {
> +			fsl,pins = <
> +				MX7D_PAD_SD2_RESET_B__GPIO5_IO11
> 	0x59
> +				MX7D_PAD_SD2_WP__GPIO5_IO10
> 	0x59
> +			>;
> +		};
> 
>  		pinctrl_hog: hoggrp {
>  			fsl,pins = <
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
  2018-03-16 10:28 ` A.s. Dong
@ 2018-04-16  8:25   ` Anson Huang
  0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2018-04-16  8:25 UTC (permalink / raw)
  To: A.s. Dong, shawnguo, kernel, Fabio Estevam, robh+dt, mark.rutland, linux
  Cc: dl-linux-imx, linux-arm-kernel, devicetree, linux-kernel

Ping...

Anson Huang
Best Regards!


> -----Original Message-----
> From: A.s. Dong
> Sent: Friday, March 16, 2018 6:28 PM
> To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org;
> kernel@pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>;
> robh+dt@kernel.org; mark.rutland@arm.com; linux@armlinux.org.uk
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
> 
> > -----Original Message-----
> > From: Anson Huang [mailto:Anson.Huang@nxp.com]
> > Sent: Friday, March 16, 2018 4:55 PM
> > To: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam
> > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
> > linux@armlinux.org.uk
> > Cc: dl-linux-imx <linux-imx@nxp.com>;
> > linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
> >
> > Add support for imx7d-sdb board's gpio keys:
> >
> > S1(FUNC1): KEY_VOLUMEUP
> > S3(FUNC2): KEY_VOLUMEDOWN
> >
> 
> Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> Regards
> Dong Aisheng
> 
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm/boot/dts/imx7d-sdb.dts | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7d-sdb.dts
> > b/arch/arm/boot/dts/imx7d- sdb.dts index 7f241af..e47b5b2 100644
> > --- a/arch/arm/boot/dts/imx7d-sdb.dts
> > +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> > @@ -52,6 +52,24 @@
> >  		reg = <0x80000000 0x80000000>;
> >  	};
> >
> > +	gpio-keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_gpio_keys>;
> > +
> > +		volume-up {
> > +			label = "Volume Up";
> > +			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEUP>;
> > +		};
> > +
> > +		volume-down {
> > +			label = "Volume Down";
> > +			gpios = <&gpio5 10 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEDOWN>;
> > +		};
> > +	};
> > +
> >  	spi4 {
> >  		compatible = "spi-gpio";
> >  		pinctrl-names = "default";
> > @@ -519,6 +537,12 @@
> >  			>;
> >  		};
> >
> > +		pinctrl_gpio_keys: gpio_keysgrp {
> > +			fsl,pins = <
> > +				MX7D_PAD_SD2_RESET_B__GPIO5_IO11
> > 	0x59
> > +				MX7D_PAD_SD2_WP__GPIO5_IO10
> > 	0x59
> > +			>;
> > +		};
> >
> >  		pinctrl_hog: hoggrp {
> >  			fsl,pins = <
> > --
> > 2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: imx7d-sdb: add gpio key support
  2018-03-16  8:54 [PATCH] ARM: dts: imx7d-sdb: add gpio key support Anson Huang
  2018-03-16 10:28 ` A.s. Dong
@ 2018-04-16 13:54 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-04-16 13:54 UTC (permalink / raw)
  To: Anson Huang
  Cc: kernel, fabio.estevam, robh+dt, mark.rutland, linux, Linux-imx,
	linux-arm-kernel, devicetree, linux-kernel

On Fri, Mar 16, 2018 at 04:54:31PM +0800, Anson Huang wrote:
> Add support for imx7d-sdb board's gpio keys:
> 
> S1(FUNC1): KEY_VOLUMEUP
> S3(FUNC2): KEY_VOLUMEDOWN
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-16 13:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16  8:54 [PATCH] ARM: dts: imx7d-sdb: add gpio key support Anson Huang
2018-03-16 10:28 ` A.s. Dong
2018-04-16  8:25   ` Anson Huang
2018-04-16 13:54 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).