From: "Pali Rohár" <pali.rohar@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, andy@infradead.org,
mario.limonciello@dell.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
Date: Fri, 20 Apr 2018 09:28:54 +0200 [thread overview]
Message-ID: <20180420072854.bprouoj5poim5rxv@pali> (raw)
In-Reply-To: <20180420072648.5426-1-kai.heng.feng@canonical.com>
On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote:
> There are two new events generated by dell-wmi, rfkill and fn-lock, from
> Dell Systems.
>
> When Fn-lock hotkey gets pressed to switch to function mode:
> [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
> pressed
>
> When Fn-lock hotkey gets pressed to switch to multimedia mode:
> [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
> pressed
>
> When radio hotkey gets pressed:
> [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
> pressed
>
> These events are for notification purpose, so we can ignore them.
>
> This patch is tested on XPS 9370.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> v2: Reorder alphabetically.
> More detailed changelog.
>
> drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8d102195a392..ba8e6725d7ac 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
> * override them.
> */
> static const struct key_entry dell_wmi_keymap_type_0010[] = {
> + /* Fn-lock switched to function keys */
> + { KE_IGNORE, 0x0, { KEY_RESERVED } },
> +
> + /* Fn-lock switched to multimedia keys */
> + { KE_IGNORE, 0x1, { KEY_RESERVED } },
> +
> /* Mic mute */
> { KE_KEY, 0x150, { KEY_MICMUTE } },
>
> @@ -296,6 +302,14 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> { KE_KEY, 0x851, { KEY_PROG2 } },
> { KE_KEY, 0x852, { KEY_PROG3 } },
>
> + /*
> + * Radio disable (notify only -- there is no model for which the
> + * WMI event is supposed to trigger an action).
> + */
> + { KE_IGNORE, 0xe008, { KEY_RFKILL } },
> +
> + /* Fn-lock */
> + { KE_IGNORE, 0xe035, { KEY_RESERVED } },
> };
>
> /*
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2018-04-20 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 7:26 [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Kai-Heng Feng
2018-04-20 7:28 ` Pali Rohár [this message]
2018-04-20 14:30 ` Mario.Limonciello
2018-05-24 7:07 ` Kai Heng Feng
2018-05-31 10:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420072854.bprouoj5poim5rxv@pali \
--to=pali.rohar@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).