* [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
@ 2018-04-20 7:26 Kai-Heng Feng
2018-04-20 7:28 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Kai-Heng Feng @ 2018-04-20 7:26 UTC (permalink / raw)
To: mjg59, pali.rohar, dvhart, andy, mario.limonciello
Cc: platform-driver-x86, linux-kernel, Kai-Heng Feng
There are two new events generated by dell-wmi, rfkill and fn-lock, from
Dell Systems.
When Fn-lock hotkey gets pressed to switch to function mode:
[85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
pressed
[85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
pressed
When Fn-lock hotkey gets pressed to switch to multimedia mode:
[85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
pressed
[85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
pressed
When radio hotkey gets pressed:
[85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
pressed
These events are for notification purpose, so we can ignore them.
This patch is tested on XPS 9370.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2: Reorder alphabetically.
More detailed changelog.
drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 8d102195a392..ba8e6725d7ac 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
* override them.
*/
static const struct key_entry dell_wmi_keymap_type_0010[] = {
+ /* Fn-lock switched to function keys */
+ { KE_IGNORE, 0x0, { KEY_RESERVED } },
+
+ /* Fn-lock switched to multimedia keys */
+ { KE_IGNORE, 0x1, { KEY_RESERVED } },
+
/* Mic mute */
{ KE_KEY, 0x150, { KEY_MICMUTE } },
@@ -296,6 +302,14 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
{ KE_KEY, 0x851, { KEY_PROG2 } },
{ KE_KEY, 0x852, { KEY_PROG3 } },
+ /*
+ * Radio disable (notify only -- there is no model for which the
+ * WMI event is supposed to trigger an action).
+ */
+ { KE_IGNORE, 0xe008, { KEY_RFKILL } },
+
+ /* Fn-lock */
+ { KE_IGNORE, 0xe035, { KEY_RESERVED } },
};
/*
--
2.17.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
2018-04-20 7:26 [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Kai-Heng Feng
@ 2018-04-20 7:28 ` Pali Rohár
2018-04-20 14:30 ` Mario.Limonciello
0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2018-04-20 7:28 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: mjg59, dvhart, andy, mario.limonciello, platform-driver-x86,
linux-kernel
On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote:
> There are two new events generated by dell-wmi, rfkill and fn-lock, from
> Dell Systems.
>
> When Fn-lock hotkey gets pressed to switch to function mode:
> [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
> pressed
>
> When Fn-lock hotkey gets pressed to switch to multimedia mode:
> [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
> pressed
>
> When radio hotkey gets pressed:
> [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
> pressed
>
> These events are for notification purpose, so we can ignore them.
>
> This patch is tested on XPS 9370.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> v2: Reorder alphabetically.
> More detailed changelog.
>
> drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8d102195a392..ba8e6725d7ac 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
> * override them.
> */
> static const struct key_entry dell_wmi_keymap_type_0010[] = {
> + /* Fn-lock switched to function keys */
> + { KE_IGNORE, 0x0, { KEY_RESERVED } },
> +
> + /* Fn-lock switched to multimedia keys */
> + { KE_IGNORE, 0x1, { KEY_RESERVED } },
> +
> /* Mic mute */
> { KE_KEY, 0x150, { KEY_MICMUTE } },
>
> @@ -296,6 +302,14 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> { KE_KEY, 0x851, { KEY_PROG2 } },
> { KE_KEY, 0x852, { KEY_PROG3 } },
>
> + /*
> + * Radio disable (notify only -- there is no model for which the
> + * WMI event is supposed to trigger an action).
> + */
> + { KE_IGNORE, 0xe008, { KEY_RFKILL } },
> +
> + /* Fn-lock */
> + { KE_IGNORE, 0xe035, { KEY_RESERVED } },
> };
>
> /*
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
2018-04-20 7:28 ` Pali Rohár
@ 2018-04-20 14:30 ` Mario.Limonciello
2018-05-24 7:07 ` Kai Heng Feng
0 siblings, 1 reply; 5+ messages in thread
From: Mario.Limonciello @ 2018-04-20 14:30 UTC (permalink / raw)
To: pali.rohar, kai.heng.feng
Cc: mjg59, dvhart, andy, platform-driver-x86, linux-kernel
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Friday, April 20, 2018 2:29 AM
> To: Kai-Heng Feng
> Cc: mjg59@srcf.ucam.org; dvhart@infradead.org; andy@infradead.org;
> Limonciello, Mario; platform-driver-x86@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock
> events
>
> On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote:
> > There are two new events generated by dell-wmi, rfkill and fn-lock, from
> > Dell Systems.
> >
> > When Fn-lock hotkey gets pressed to switch to function mode:
> > [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> > pressed
> > [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
> > pressed
> >
> > When Fn-lock hotkey gets pressed to switch to multimedia mode:
> > [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> > pressed
> > [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
> > pressed
> >
> > When radio hotkey gets pressed:
> > [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
> > pressed
> >
> > These events are for notification purpose, so we can ignore them.
> >
> > This patch is tested on XPS 9370.
> >
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
>
> > ---
> > v2: Reorder alphabetically.
> > More detailed changelog.
> >
> > drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> > index 8d102195a392..ba8e6725d7ac 100644
> > --- a/drivers/platform/x86/dell-wmi.c
> > +++ b/drivers/platform/x86/dell-wmi.c
> > @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
> > * override them.
> > */
> > static const struct key_entry dell_wmi_keymap_type_0010[] = {
> > + /* Fn-lock switched to function keys */
> > + { KE_IGNORE, 0x0, { KEY_RESERVED } },
> > +
> > + /* Fn-lock switched to multimedia keys */
> > + { KE_IGNORE, 0x1, { KEY_RESERVED } },
> > +
> > /* Mic mute */
> > { KE_KEY, 0x150, { KEY_MICMUTE } },
> >
> > @@ -296,6 +302,14 @@ static const struct key_entry
> dell_wmi_keymap_type_0010[] = {
> > { KE_KEY, 0x851, { KEY_PROG2 } },
> > { KE_KEY, 0x852, { KEY_PROG3 } },
> >
> > + /*
> > + * Radio disable (notify only -- there is no model for which the
> > + * WMI event is supposed to trigger an action).
> > + */
> > + { KE_IGNORE, 0xe008, { KEY_RFKILL } },
> > +
> > + /* Fn-lock */
> > + { KE_IGNORE, 0xe035, { KEY_RESERVED } },
> > };
> >
> > /*
>
> --
> Pali Rohár
> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
2018-04-20 14:30 ` Mario.Limonciello
@ 2018-05-24 7:07 ` Kai Heng Feng
2018-05-31 10:44 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Kai Heng Feng @ 2018-05-24 7:07 UTC (permalink / raw)
To: Mario.Limonciello
Cc: Pali Rohár, mjg59, dvhart, andy, platform-driver-x86, linux-kernel
at 10:30 PM, Mario.Limonciello@dell.com wrote:
>
>
>> -----Original Message-----
>> From: Pali Rohár [mailto:pali.rohar@gmail.com]
>> Sent: Friday, April 20, 2018 2:29 AM
>> To: Kai-Heng Feng
>> Cc: mjg59@srcf.ucam.org; dvhart@infradead.org; andy@infradead.org;
>> Limonciello, Mario; platform-driver-x86@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and
>> fn-lock
>> events
>>
>> On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote:
>>> There are two new events generated by dell-wmi, rfkill and fn-lock, from
>>> Dell Systems.
>>>
>>> When Fn-lock hotkey gets pressed to switch to function mode:
>>> [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
>>> pressed
>>> [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
>>> pressed
>>>
>>> When Fn-lock hotkey gets pressed to switch to multimedia mode:
>>> [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
>>> pressed
>>> [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
>>> pressed
>>>
>>> When radio hotkey gets pressed:
>>> [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
>>> pressed
>>>
>>> These events are for notification purpose, so we can ignore them.
>>>
>>> This patch is tested on XPS 9370.
>>>
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>
>> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Looks like this patch does not get included yet.
Kai-Heng
>
>>> ---
>>> v2: Reorder alphabetically.
>>> More detailed changelog.
>>>
>>> drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/dell-wmi.c
>>> b/drivers/platform/x86/dell-wmi.c
>>> index 8d102195a392..ba8e6725d7ac 100644
>>> --- a/drivers/platform/x86/dell-wmi.c
>>> +++ b/drivers/platform/x86/dell-wmi.c
>>> @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
>>> * override them.
>>> */
>>> static const struct key_entry dell_wmi_keymap_type_0010[] = {
>>> + /* Fn-lock switched to function keys */
>>> + { KE_IGNORE, 0x0, { KEY_RESERVED } },
>>> +
>>> + /* Fn-lock switched to multimedia keys */
>>> + { KE_IGNORE, 0x1, { KEY_RESERVED } },
>>> +
>>> /* Mic mute */
>>> { KE_KEY, 0x150, { KEY_MICMUTE } },
>>>
>>> @@ -296,6 +302,14 @@ static const struct key_entry
>> dell_wmi_keymap_type_0010[] = {
>>> { KE_KEY, 0x851, { KEY_PROG2 } },
>>> { KE_KEY, 0x852, { KEY_PROG3 } },
>>>
>>> + /*
>>> + * Radio disable (notify only -- there is no model for which the
>>> + * WMI event is supposed to trigger an action).
>>> + */
>>> + { KE_IGNORE, 0xe008, { KEY_RFKILL } },
>>> +
>>> + /* Fn-lock */
>>> + { KE_IGNORE, 0xe035, { KEY_RESERVED } },
>>> };
>>>
>>> /*
>>
>> --
>> Pali Rohár
>> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events
2018-05-24 7:07 ` Kai Heng Feng
@ 2018-05-31 10:44 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-05-31 10:44 UTC (permalink / raw)
To: Kai Heng Feng
Cc: Mario Limonciello, Pali Rohár, Matthew Garrett, Darren Hart,
Andy Shevchenko, Platform Driver, Linux Kernel Mailing List
On Thu, May 24, 2018 at 10:07 AM, Kai Heng Feng
<kai.heng.feng@canonical.com> wrote:
> at 10:30 PM, Mario.Limonciello@dell.com wrote:
>>> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
> Looks like this patch does not get included yet.
Yep. It also is missed in our patchwork or I mistakenly mark it with
some irrelevant state. Sorry for that.
Please, resend with all tags applied.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-31 10:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20 7:26 [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Kai-Heng Feng
2018-04-20 7:28 ` Pali Rohár
2018-04-20 14:30 ` Mario.Limonciello
2018-05-24 7:07 ` Kai Heng Feng
2018-05-31 10:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).