* [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays
@ 2018-04-20 10:21 Pascal Roeleven
2018-04-23 7:14 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Pascal Roeleven @ 2018-04-20 10:21 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai,
devicetree, linux-arm-kernel, linux-kernel
Cc: linux-sunxi, Pascal Roeleven
Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.
Change the duplicate clocks to the probably intended ones.
Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
---
arch/arm/boot/dts/sun4i-a10.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 77e8436b..3a1c6b45 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -76,7 +76,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_HDMI>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
@@ -88,7 +88,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_DE_BE0>,
<&ccu CLK_AHB_DE_FE0>, <&ccu CLK_DE_BE0>,
- <&ccu CLK_AHB_DE_FE0>, <&ccu CLK_TCON0_CH0>,
+ <&ccu CLK_DE_FE0>, <&ccu CLK_TCON0_CH0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
};
@@ -99,7 +99,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
clocks = <&ccu CLK_AHB_TVE0>, <&ccu CLK_AHB_LCD0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_TVE0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays
2018-04-20 10:21 [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays Pascal Roeleven
@ 2018-04-23 7:14 ` Maxime Ripard
2018-04-23 11:01 ` [linux-sunxi] " Pascal Roeleven
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2018-04-23 7:14 UTC (permalink / raw)
To: Pascal Roeleven
Cc: Rob Herring, Mark Rutland, Chen-Yu Tsai, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
> Some displays on SUN4i devices wouldn't properly stay on unless
> 'clk_ignore_unused' is used.
>
> Change the duplicate clocks to the probably intended ones.
>
> Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
What was the difference with the first patch you sent?
Anyway, I've applied it, thanks
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays
2018-04-23 7:14 ` Maxime Ripard
@ 2018-04-23 11:01 ` Pascal Roeleven
2018-04-23 12:24 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Pascal Roeleven @ 2018-04-23 11:01 UTC (permalink / raw)
To: maxime.ripard
Cc: Rob Herring, Mark Rutland, Chen-Yu Tsai, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
On 2018-04-23 09:14, Maxime Ripard wrote:
> On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
>> Some displays on SUN4i devices wouldn't properly stay on unless
>> 'clk_ignore_unused' is used.
>>
>> Change the duplicate clocks to the probably intended ones.
>>
>> Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
>
> What was the difference with the first patch you sent?
>
> Anyway, I've applied it, thanks
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
I'm sorry there isn't any.
It's the first patch I have ever send so had some git-send-email issues
and
didn't know the correct procedure to resend a patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays
2018-04-23 11:01 ` [linux-sunxi] " Pascal Roeleven
@ 2018-04-23 12:24 ` Maxime Ripard
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2018-04-23 12:24 UTC (permalink / raw)
To: Pascal Roeleven
Cc: Rob Herring, Mark Rutland, Chen-Yu Tsai, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On Mon, Apr 23, 2018 at 01:01:03PM +0200, Pascal Roeleven wrote:
> On 2018-04-23 09:14, Maxime Ripard wrote:
> > On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
> > > Some displays on SUN4i devices wouldn't properly stay on unless
> > > 'clk_ignore_unused' is used.
> > >
> > > Change the duplicate clocks to the probably intended ones.
> > >
> > > Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
> >
> > What was the difference with the first patch you sent?
> >
> > Anyway, I've applied it, thanks
> >
> > Maxime
> >
> > --
> > Maxime Ripard, Bootlin (formerly Free Electrons)
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
> I'm sorry there isn't any.
> It's the first patch I have ever send so had some git-send-email issues and
> didn't know the correct procedure to resend a patch.
Just set RESEND in the subject prefix (using --subject-prefix="PATCH
RESEND"), and say why you resent it in the patch / cover letter after
the --- and before the diffstat.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays
@ 2018-04-20 9:18 Pascal Roeleven
0 siblings, 0 replies; 5+ messages in thread
From: Pascal Roeleven @ 2018-04-20 9:18 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai,
devicetree, linux-arm-kernel, linux-kernel
Cc: linux-sunxi, Pascal Roeleven
Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.
Change the duplicate clocks to the probably intended ones.
Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
---
arch/arm/boot/dts/sun4i-a10.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 77e8436b..3a1c6b45 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -76,7 +76,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_HDMI>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
@@ -88,7 +88,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_DE_BE0>,
<&ccu CLK_AHB_DE_FE0>, <&ccu CLK_DE_BE0>,
- <&ccu CLK_AHB_DE_FE0>, <&ccu CLK_TCON0_CH0>,
+ <&ccu CLK_DE_FE0>, <&ccu CLK_TCON0_CH0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
};
@@ -99,7 +99,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
clocks = <&ccu CLK_AHB_TVE0>, <&ccu CLK_AHB_LCD0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_TVE0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-23 12:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20 10:21 [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays Pascal Roeleven
2018-04-23 7:14 ` Maxime Ripard
2018-04-23 11:01 ` [linux-sunxi] " Pascal Roeleven
2018-04-23 12:24 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2018-04-20 9:18 Pascal Roeleven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).