* [PATCH] media: mxl5xx: fix get_algo()'s return type
@ 2018-04-24 13:19 Luc Van Oostenryck
2018-04-24 17:21 ` Daniel Scheller
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:19 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Daniel Scheller, Mauro Carvalho Chehab, linux-media
The method dvb_frontend_ops::get_frontend_algo() is defined as
returning an 'enum dvbfe_algo', but the implementation in this
driver returns an 'int'.
Fix this by returning 'enum dvbfe_algo' in this driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/media/dvb-frontends/mxl5xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/mxl5xx.c b/drivers/media/dvb-frontends/mxl5xx.c
index 483ee7d61..274d8fca0 100644
--- a/drivers/media/dvb-frontends/mxl5xx.c
+++ b/drivers/media/dvb-frontends/mxl5xx.c
@@ -375,7 +375,7 @@ static void release(struct dvb_frontend *fe)
kfree(state);
}
-static int get_algo(struct dvb_frontend *fe)
+static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
{
return DVBFE_ALGO_HW;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: mxl5xx: fix get_algo()'s return type
2018-04-24 13:19 [PATCH] media: mxl5xx: fix get_algo()'s return type Luc Van Oostenryck
@ 2018-04-24 17:21 ` Daniel Scheller
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Scheller @ 2018-04-24 17:21 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: linux-kernel, Mauro Carvalho Chehab, linux-media
Am Tue, 24 Apr 2018 15:19:31 +0200
schrieb Luc Van Oostenryck <luc.vanoostenryck@gmail.com>:
> The method dvb_frontend_ops::get_frontend_algo() is defined as
> returning an 'enum dvbfe_algo', but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'enum dvbfe_algo' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/media/dvb-frontends/mxl5xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/mxl5xx.c b/drivers/media/dvb-frontends/mxl5xx.c
> index 483ee7d61..274d8fca0 100644
> --- a/drivers/media/dvb-frontends/mxl5xx.c
> +++ b/drivers/media/dvb-frontends/mxl5xx.c
> @@ -375,7 +375,7 @@ static void release(struct dvb_frontend *fe)
> kfree(state);
> }
>
> -static int get_algo(struct dvb_frontend *fe)
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }
Acked-by: Daniel Scheller <d.scheller@gmx.net>
Best regards,
Daniel Scheller
--
https://github.com/herrnst
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-24 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:19 [PATCH] media: mxl5xx: fix get_algo()'s return type Luc Van Oostenryck
2018-04-24 17:21 ` Daniel Scheller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).