* [PATCH v2] x86/PCI: Make pci=earlydump output neat
@ 2018-04-25 10:15 Andy Shevchenko
2018-04-27 11:58 ` Ingo Molnar
2018-04-27 21:57 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-04-25 10:15 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, Thomas Gleixner, H . Peter Anvin,
Ingo Molnar, x86, Mika Westerberg, linux-kernel
Cc: Andy Shevchenko
Currently the early dump of PCI configuration space looks quite unhelpful, e.g.
[ 0.000000] 60:
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000] 00
[ 0.000000]
which makes really hard to get anything out of this. Convert the function to
use print_hex_dump() to make output neat.
In the result we will have
[ 0.000000] 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
which is much, much better.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
- add Mika's tag
- address style issue
arch/x86/pci/early.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/arch/x86/pci/early.c b/arch/x86/pci/early.c
index f0114007e915..e5f753cbb1c3 100644
--- a/arch/x86/pci/early.c
+++ b/arch/x86/pci/early.c
@@ -59,24 +59,15 @@ int early_pci_allowed(void)
void early_dump_pci_device(u8 bus, u8 slot, u8 func)
{
+ u32 value[256 / 4];
int i;
- int j;
- u32 val;
- printk(KERN_INFO "pci 0000:%02x:%02x.%d config space:",
- bus, slot, func);
+ pr_info("pci 0000:%02x:%02x.%d config space:\n", bus, slot, func);
- for (i = 0; i < 256; i += 4) {
- if (!(i & 0x0f))
- printk("\n %02x:",i);
+ for (i = 0; i < 256; i += 4)
+ value[i / 4] = read_pci_config(bus, slot, func, i);
- val = read_pci_config(bus, slot, func, i);
- for (j = 0; j < 4; j++) {
- printk(" %02x", val & 0xff);
- val >>= 8;
- }
- }
- printk("\n");
+ print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, 256, false);
}
void early_dump_pci_devices(void)
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] x86/PCI: Make pci=earlydump output neat
2018-04-25 10:15 [PATCH v2] x86/PCI: Make pci=earlydump output neat Andy Shevchenko
@ 2018-04-27 11:58 ` Ingo Molnar
2018-04-27 21:57 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2018-04-27 11:58 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bjorn Helgaas, linux-pci, Thomas Gleixner, H . Peter Anvin,
Ingo Molnar, x86, Mika Westerberg, linux-kernel
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Currently the early dump of PCI configuration space looks quite unhelpful, e.g.
>
> [ 0.000000] 60:
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000]
>
> which makes really hard to get anything out of this. Convert the function to
> use print_hex_dump() to make output neat.
>
> In the result we will have
>
> [ 0.000000] 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>
> which is much, much better.
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] x86/PCI: Make pci=earlydump output neat
2018-04-25 10:15 [PATCH v2] x86/PCI: Make pci=earlydump output neat Andy Shevchenko
2018-04-27 11:58 ` Ingo Molnar
@ 2018-04-27 21:57 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2018-04-27 21:57 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bjorn Helgaas, linux-pci, Thomas Gleixner, H . Peter Anvin,
Ingo Molnar, x86, Mika Westerberg, linux-kernel
On Wed, Apr 25, 2018 at 01:15:07PM +0300, Andy Shevchenko wrote:
> Currently the early dump of PCI configuration space looks quite unhelpful, e.g.
>
> [ 0.000000] 60:
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000] 00
> [ 0.000000]
>
> which makes really hard to get anything out of this. Convert the function to
> use print_hex_dump() to make output neat.
>
> In the result we will have
>
> [ 0.000000] 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>
> which is much, much better.
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied with Ingo's ack to pci/enumeration for v4.18, thanks!
> ---
> - add Mika's tag
> - address style issue
> arch/x86/pci/early.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/arch/x86/pci/early.c b/arch/x86/pci/early.c
> index f0114007e915..e5f753cbb1c3 100644
> --- a/arch/x86/pci/early.c
> +++ b/arch/x86/pci/early.c
> @@ -59,24 +59,15 @@ int early_pci_allowed(void)
>
> void early_dump_pci_device(u8 bus, u8 slot, u8 func)
> {
> + u32 value[256 / 4];
> int i;
> - int j;
> - u32 val;
>
> - printk(KERN_INFO "pci 0000:%02x:%02x.%d config space:",
> - bus, slot, func);
> + pr_info("pci 0000:%02x:%02x.%d config space:\n", bus, slot, func);
>
> - for (i = 0; i < 256; i += 4) {
> - if (!(i & 0x0f))
> - printk("\n %02x:",i);
> + for (i = 0; i < 256; i += 4)
> + value[i / 4] = read_pci_config(bus, slot, func, i);
>
> - val = read_pci_config(bus, slot, func, i);
> - for (j = 0; j < 4; j++) {
> - printk(" %02x", val & 0xff);
> - val >>= 8;
> - }
> - }
> - printk("\n");
> + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, 256, false);
> }
>
> void early_dump_pci_devices(void)
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-27 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25 10:15 [PATCH v2] x86/PCI: Make pci=earlydump output neat Andy Shevchenko
2018-04-27 11:58 ` Ingo Molnar
2018-04-27 21:57 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).