From: Mark Rutland <mark.rutland@arm.com>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
jnair@caviumnetworks.com, Robert.Richter@cavium.com,
Vadim.Lomovtsev@cavium.com, Jan.Glauber@cavium.com,
gklkml16@gmail.com
Subject: Re: [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver
Date: Fri, 27 Apr 2018 10:30:27 +0100 [thread overview]
Message-ID: <20180427093027.ngtuoezyh6mtz26p@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180426170624.bfcba885431d57d0de2a3ddd@arm.com>
Hi Kim,
On Thu, Apr 26, 2018 at 05:06:24PM -0500, Kim Phillips wrote:
> On Wed, 25 Apr 2018 14:30:47 +0530
> Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com> wrote:
>
> > +static int thunderx2_uncore_event_init(struct perf_event *event)
> This PMU driver can be made more user-friendly by not just silently
> returning an error code such as -EINVAL, but by emitting a useful
> message describing the specific error via dmesg.
As has previously been discussed on several occasions, patches which log
to dmesg in a pmu::event_init() path at any level above pr_debug() are
not acceptable -- dmesg is not intended as a mechanism to inform users
of driver-specific constraints.
I would appreciate if in future you could qualify your suggestion with
the requirement that pr_debug() is used.
Thanks,
Mark.
next prev parent reply other threads:[~2018-04-27 9:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 9:00 [PATCH v4 0/2] Add ThunderX2 SoC Performance Monitoring Unit driver Ganapatrao Kulkarni
2018-04-25 9:00 ` [PATCH v4 1/2] perf: uncore: Adding documentation for ThunderX2 pmu uncore driver Ganapatrao Kulkarni
2018-04-26 20:55 ` Randy Dunlap
2018-04-27 4:49 ` Ganapatrao Kulkarni
2018-04-25 9:00 ` [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver Ganapatrao Kulkarni
2018-04-26 10:59 ` Mark Rutland
2018-05-04 18:46 ` Ganapatrao Kulkarni
2018-05-15 10:33 ` Ganapatrao Kulkarni
2018-05-21 10:37 ` Mark Rutland
2018-05-21 10:40 ` Mark Rutland
2018-05-21 12:42 ` Ganapatrao Kulkarni
2018-05-21 10:55 ` Mark Rutland
2018-05-21 12:34 ` Ganapatrao Kulkarni
2018-04-26 22:06 ` Kim Phillips
2018-04-27 9:30 ` Mark Rutland [this message]
2018-04-27 13:15 ` Kim Phillips
2018-04-27 14:37 ` Will Deacon
2018-04-27 15:46 ` Kim Phillips
2018-04-27 16:09 ` Will Deacon
2018-04-27 16:56 ` Kim Phillips
2018-05-01 11:54 ` Will Deacon
2018-05-04 0:30 ` Kim Phillips
2018-05-04 17:10 ` Robin Murphy
2018-05-10 1:09 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427093027.ngtuoezyh6mtz26p@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Jan.Glauber@cavium.com \
--cc=Robert.Richter@cavium.com \
--cc=Vadim.Lomovtsev@cavium.com \
--cc=Will.Deacon@arm.com \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=gklkml16@gmail.com \
--cc=jnair@caviumnetworks.com \
--cc=kim.phillips@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).