linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] inode: debugfs_create_dir uses mode permission from parent
@ 2018-04-27  8:07 Thomas Richter
  2018-04-27  8:27 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Richter @ 2018-04-27  8:07 UTC (permalink / raw)
  To: gregkh
  Cc: brueckner, schwidefsky, heiko.carstens, linux-kernel, Thomas Richter

Currently function debugfs_create_dir() creates a new
directory in the debugfs (usually mounted /sys/kernel/debug)
with permission rwxr-xr-x. This is hard coded.

Change this to use the parent directory permission.

Fixes: edac65eaf8d5c ("debugfs: take mode-dependent parts of debugfs_get_inode() into callers")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/debugfs/inode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 13b01351dd1c..80618330d86a 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -512,7 +512,10 @@ struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
 	if (unlikely(!inode))
 		return failed_creating(dentry);
 
-	inode->i_mode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO;
+	if(!parent)
+		parent = debugfs_mount->mnt_root;
+	inode->i_mode = S_IFDIR | (d_inode(parent)->i_mode
+				   & (S_IRWXU | S_IRWXG));
 	inode->i_op = &simple_dir_inode_operations;
 	inode->i_fop = &simple_dir_operations;
 
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-04-27 11:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27  8:07 [PATCH] inode: debugfs_create_dir uses mode permission from parent Thomas Richter
2018-04-27  8:27 ` Greg KH
2018-04-27  9:14   ` Thomas-Mich Richter
2018-04-27 10:06     ` Greg KH
2018-04-27 11:30       ` Thomas-Mich Richter
2018-04-27 11:47         ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).