stable 4.16.5 hmm build error

stable 4.16.5 hmm build error

[Randy Dunlap]

https://bugzilla.kernel.org/show_bug.cgi?id=199515

kernel/fork.o: In function `__mmdrop':
/kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference to `hmm_mm_destroy'

"It is also reproduced in linux-4.16.5"


There have been a few attempts to fix this build error.  The kernel mainline
repo seems to have it fixed, but it looks to me like Arnd's latest patch
(9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
was mis-merged to 4.16.5 stable.

Please take a look.  Do you already have a fixup for this?

thanks,
-- 
~Randy

Re: stable 4.16.5 hmm build error

[Михаил Носов]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Oh. Yes. Tag v4.16.5 without commit
9d8a463a7016e9e5578a561588a18acef139919c.
It's in v4.17-rc1/2.
Thank you.

2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@infradead.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=199515
>
> kernel/fork.o: In function `__mmdrop':
> /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
> to `hmm_mm_destroy'
>
> "It is also reproduced in linux-4.16.5"
>
>
> There have been a few attempts to fix this build error.  The kernel
> mainline
> repo seems to have it fixed, but it looks to me like Arnd's latest patch
> (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
> was mis-merged to 4.16.5 stable.
>
> Please take a look.  Do you already have a fixup for this?
>
> thanks,
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 1334 bytes --]

Re: stable 4.16.5 hmm build error

[Greg Kroah-Hartman]

On Fri, Apr 27, 2018 at 02:19:24AM +0300, Михаил Носов wrote:
> Oh. Yes. Tag v4.16.5 without commit
> 9d8a463a7016e9e5578a561588a18acef139919c.
> It's in v4.17-rc1/2.
> Thank you.

That patch does not apply to the stable trees.  I'm also confused by the
lack of "real" git commit ids that are being referred to here, that
commit refers to one that is not valid.

> 2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@infradead.org>:
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=199515
> >
> > kernel/fork.o: In function `__mmdrop':
> > /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
> > to `hmm_mm_destroy'

What .config is creating this?  I have not seen any kbuild reports of
this in the past.

> >
> > "It is also reproduced in linux-4.16.5"
> >
> >
> > There have been a few attempts to fix this build error.  The kernel
> > mainline
> > repo seems to have it fixed, but it looks to me like Arnd's latest patch
> > (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
> > was mis-merged to 4.16.5 stable.
> >
> > Please take a look.  Do you already have a fixup for this?

thanks,

greg k-h

Re: stable 4.16.5 hmm build error

[Arnd Bergmann]

On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Apr 27, 2018 at 02:19:24AM +0300, Михаил Носов wrote:
>> Oh. Yes. Tag v4.16.5 without commit
>> 9d8a463a7016e9e5578a561588a18acef139919c.
>> It's in v4.17-rc1/2.
>> Thank you.
>
> That patch does not apply to the stable trees.  I'm also confused by the
> lack of "real" git commit ids that are being referred to here, that
> commit refers to one that is not valid.
>
>> 2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@infradead.org>:
>>
>> > https://bugzilla.kernel.org/show_bug.cgi?id=199515
>> >
>> > kernel/fork.o: In function `__mmdrop':
>> > /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
>> > to `hmm_mm_destroy'
>
> What .config is creating this?  I have not seen any kbuild reports of
> this in the past.

I only got this through randconfig builds on mainline.

>> >
>> > "It is also reproduced in linux-4.16.5"
>> >
>> >
>> > There have been a few attempts to fix this build error.  The kernel
>> > mainline
>> > repo seems to have it fixed, but it looks to me like Arnd's latest patch
>> > (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
>> > was mis-merged to 4.16.5 stable.
>> >
>> > Please take a look.  Do you already have a fixup for this?

Jérôme initially created

6b368cd4a44c ("mm/hmm: avoid bloating arch that do not make use of HMM")

which is part of v4.16. He noticed a build error that he fixed up with commit

b28b08de436a ("mm/hmm: fix header file if/else/endif maze")

which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
After that originally landed in mainline, I found another build error that
I fixed with commit

9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")

This fixes the issue that Randy is reporting now, please add that into
v4.16.5.

      Arnd

Re: stable 4.16.5 hmm build error

[Greg Kroah-Hartman]

On Fri, Apr 27, 2018 at 10:17:42AM +0200, Arnd Bergmann wrote:
> On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Apr 27, 2018 at 02:19:24AM +0300, Михаил Носов wrote:
> >> Oh. Yes. Tag v4.16.5 without commit
> >> 9d8a463a7016e9e5578a561588a18acef139919c.
> >> It's in v4.17-rc1/2.
> >> Thank you.
> >
> > That patch does not apply to the stable trees.  I'm also confused by the
> > lack of "real" git commit ids that are being referred to here, that
> > commit refers to one that is not valid.
> >
> >> 2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@infradead.org>:
> >>
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=199515
> >> >
> >> > kernel/fork.o: In function `__mmdrop':
> >> > /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
> >> > to `hmm_mm_destroy'
> >
> > What .config is creating this?  I have not seen any kbuild reports of
> > this in the past.
> 
> I only got this through randconfig builds on mainline.
> 
> >> >
> >> > "It is also reproduced in linux-4.16.5"
> >> >
> >> >
> >> > There have been a few attempts to fix this build error.  The kernel
> >> > mainline
> >> > repo seems to have it fixed, but it looks to me like Arnd's latest patch
> >> > (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
> >> > was mis-merged to 4.16.5 stable.
> >> >
> >> > Please take a look.  Do you already have a fixup for this?
> 
> Jérôme initially created
> 
> 6b368cd4a44c ("mm/hmm: avoid bloating arch that do not make use of HMM")
> 
> which is part of v4.16. He noticed a build error that he fixed up with commit
> 
> b28b08de436a ("mm/hmm: fix header file if/else/endif maze")
> 
> which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
> After that originally landed in mainline, I found another build error that
> I fixed with commit
> 
> 9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")

Why does that commit reference:
    Fixes: 8900d06a277a ("mm/hmm: fix header file if/else/endif maze")

when there is no such commit in the tree?

> This fixes the issue that Randy is reporting now, please add that into
> v4.16.5.

I tried, but it does not apply cleanly:
	$ p1 < ../mm-hmm-fix-header-file-if-else-endif-maze-again.patch
	checking file include/linux/hmm.h
	Hunk #1 FAILED at 376.
	Hunk #2 succeeded at 498 (offset -52 lines).
	1 out of 2 hunks FAILED

Am I missing some other commit that went in inbetween the above patches?

thanks,

greg k-h

Re: stable 4.16.5 hmm build error

[Arnd Bergmann]

On Fri, Apr 27, 2018 at 10:30 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Apr 27, 2018 at 10:17:42AM +0200, Arnd Bergmann wrote:
>> On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
>>
>> which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
>> After that originally landed in mainline, I found another build error that
>> I fixed with commit
>>
>> 9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")
>
> Why does that commit reference:
>     Fixes: 8900d06a277a ("mm/hmm: fix header file if/else/endif maze")
>
> when there is no such commit in the tree?

This must have happened when the commit that introduced it came through
the -mm tree and got a new commit ID between the time I sent the fix
and Linus picking up the patch from Andrew. I try to hand-edit the
'Fixes' line when I know it's a patch in -mm to say 'Fixes: mmotm ("...")'
but I missed that his time.

>> This fixes the issue that Randy is reporting now, please add that into
>> v4.16.5.
>
> I tried, but it does not apply cleanly:
>         $ p1 < ../mm-hmm-fix-header-file-if-else-endif-maze-again.patch
>         checking file include/linux/hmm.h
>         Hunk #1 FAILED at 376.
>         Hunk #2 succeeded at 498 (offset -52 lines).
>         1 out of 2 hunks FAILED
>
> Am I missing some other commit that went in inbetween the above patches?

There were several other commits from Jérôme inbetween. I don't
immediately see where the conflict came from, but as my patch is
basically a revert of Jérôme's, and it was working in v4.16.4, maybe
it's best if you drop the backport of b28b08de436a for now, let him
comment on whether we still need it. I had not seen the build error
he referred to in his commit and we know that it does cause a
new one.

      Arnd

Re: stable 4.16.5 hmm build error

[Михаил Носов]

>What .config is creating this?  I have not seen any kbuild reports of
this in the past.

.config - https://bugzilla.kernel.org/attachment.cgi?id=275579
src - https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.16.5.tar.xz

2018-04-27 10:30 GMT+03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Fri, Apr 27, 2018 at 02:19:24AM +0300, Михаил Носов wrote:
>> Oh. Yes. Tag v4.16.5 without commit
>> 9d8a463a7016e9e5578a561588a18acef139919c.
>> It's in v4.17-rc1/2.
>> Thank you.
>
> That patch does not apply to the stable trees.  I'm also confused by the
> lack of "real" git commit ids that are being referred to here, that
> commit refers to one that is not valid.
>
>> 2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@infradead.org>:
>>
>> > https://bugzilla.kernel.org/show_bug.cgi?id=199515
>> >
>> > kernel/fork.o: In function `__mmdrop':
>> > /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
>> > to `hmm_mm_destroy'
>
> What .config is creating this?  I have not seen any kbuild reports of
> this in the past.
>
>> >
>> > "It is also reproduced in linux-4.16.5"
>> >
>> >
>> > There have been a few attempts to fix this build error.  The kernel
>> > mainline
>> > repo seems to have it fixed, but it looks to me like Arnd's latest patch
>> > (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
>> > was mis-merged to 4.16.5 stable.
>> >
>> > Please take a look.  Do you already have a fixup for this?
>
> thanks,
>
> greg k-h

Re: stable 4.16.5 hmm build error

[Greg Kroah-Hartman]

On Fri, Apr 27, 2018 at 10:44:58AM +0200, Arnd Bergmann wrote:
> On Fri, Apr 27, 2018 at 10:30 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Apr 27, 2018 at 10:17:42AM +0200, Arnd Bergmann wrote:
> >> On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
> >>
> >> which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
> >> After that originally landed in mainline, I found another build error that
> >> I fixed with commit
> >>
> >> 9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")
> >
> > Why does that commit reference:
> >     Fixes: 8900d06a277a ("mm/hmm: fix header file if/else/endif maze")
> >
> > when there is no such commit in the tree?
> 
> This must have happened when the commit that introduced it came through
> the -mm tree and got a new commit ID between the time I sent the fix
> and Linus picking up the patch from Andrew. I try to hand-edit the
> 'Fixes' line when I know it's a patch in -mm to say 'Fixes: mmotm ("...")'
> but I missed that his time.
> 
> >> This fixes the issue that Randy is reporting now, please add that into
> >> v4.16.5.
> >
> > I tried, but it does not apply cleanly:
> >         $ p1 < ../mm-hmm-fix-header-file-if-else-endif-maze-again.patch
> >         checking file include/linux/hmm.h
> >         Hunk #1 FAILED at 376.
> >         Hunk #2 succeeded at 498 (offset -52 lines).
> >         1 out of 2 hunks FAILED
> >
> > Am I missing some other commit that went in inbetween the above patches?
> 
> There were several other commits from Jérôme inbetween. I don't
> immediately see where the conflict came from, but as my patch is
> basically a revert of Jérôme's, and it was working in v4.16.4, maybe
> it's best if you drop the backport of b28b08de436a for now, let him
> comment on whether we still need it. I had not seen the build error
> he referred to in his commit and we know that it does cause a
> new one.

That's a good idea, now reverted, thanks.

greg k-h

Re: stable 4.16.5 hmm build error

[Jerome Glisse]

On Fri, Apr 27, 2018 at 01:51:47PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 27, 2018 at 10:44:58AM +0200, Arnd Bergmann wrote:
> > On Fri, Apr 27, 2018 at 10:30 AM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > On Fri, Apr 27, 2018 at 10:17:42AM +0200, Arnd Bergmann wrote:
> > >> On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
> > >>
> > >> which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
> > >> After that originally landed in mainline, I found another build error that
> > >> I fixed with commit
> > >>
> > >> 9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")
> > >
> > > Why does that commit reference:
> > >     Fixes: 8900d06a277a ("mm/hmm: fix header file if/else/endif maze")
> > >
> > > when there is no such commit in the tree?
> > 
> > This must have happened when the commit that introduced it came through
> > the -mm tree and got a new commit ID between the time I sent the fix
> > and Linus picking up the patch from Andrew. I try to hand-edit the
> > 'Fixes' line when I know it's a patch in -mm to say 'Fixes: mmotm ("...")'
> > but I missed that his time.
> > 
> > >> This fixes the issue that Randy is reporting now, please add that into
> > >> v4.16.5.
> > >
> > > I tried, but it does not apply cleanly:
> > >         $ p1 < ../mm-hmm-fix-header-file-if-else-endif-maze-again.patch
> > >         checking file include/linux/hmm.h
> > >         Hunk #1 FAILED at 376.
> > >         Hunk #2 succeeded at 498 (offset -52 lines).
> > >         1 out of 2 hunks FAILED
> > >
> > > Am I missing some other commit that went in inbetween the above patches?
> > 
> > There were several other commits from Jérôme inbetween. I don't
> > immediately see where the conflict came from, but as my patch is
> > basically a revert of Jérôme's, and it was working in v4.16.4, maybe
> > it's best if you drop the backport of b28b08de436a for now, let him
> > comment on whether we still need it. I had not seen the build error
> > he referred to in his commit and we know that it does cause a
> > new one.
> 
> That's a good idea, now reverted, thanks.
> 

Sorry for the delay, i was at LSF and then on PTO, now i am traveling
again :) I will look into that latter in May and post proper backport
of all HMM related patches (i need to do that for much earlier kernel
before HMM was upstream).

Will test for this build error.

Thanks
Jérôme