* [RFT][PATCH] arm64: dts: exynos: Remove unneeded address space mapping for soc node
@ 2018-04-24 17:36 ` Krzysztof Kozlowski
2018-04-25 5:52 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-04-24 17:36 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim, Krzysztof Kozlowski, Chanwoo Choi, Marek Szyprowski,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Alim Akhtar, Pankaj Dubey
Remove the address space mapping between root and soc nodes to fix
DTC warnings in Exynos5433 and Exynos7 like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested.
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
arch/arm64/boot/dts/exynos/exynos7.dtsi | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 828996a06610..ba8157ceaa56 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -18,8 +18,8 @@
/ {
compatible = "samsung,exynos5433";
- #address-cells = <2>;
- #size-cells = <2>;
+ #address-cells = <1>;
+ #size-cells = <1>;
interrupt-parent = <&gic>;
@@ -235,7 +235,7 @@
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x0 0x0 0x0 0x18000000>;
+ ranges;
arm_a53_pmu {
compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3";
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 0b98d2334cad..93a84338938a 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -12,8 +12,8 @@
/ {
compatible = "samsung,exynos7";
interrupt-parent = <&gic>;
- #address-cells = <2>;
- #size-cells = <2>;
+ #address-cells = <1>;
+ #size-cells = <1>;
aliases {
pinctrl0 = &pinctrl_alive;
@@ -70,7 +70,7 @@
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0 0 0 0x18000000>;
+ ranges;
chipid@10000000 {
compatible = "samsung,exynos4210-chipid";
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFT][PATCH] arm64: dts: exynos: Remove unneeded address space mapping for soc node
2018-04-24 17:36 ` [RFT][PATCH] arm64: dts: exynos: Remove unneeded address space mapping for soc node Krzysztof Kozlowski
@ 2018-04-25 5:52 ` Marek Szyprowski
2018-04-29 17:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2018-04-25 5:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Mark Rutland, Catalin Marinas,
Will Deacon, Kukjin Kim, Chanwoo Choi, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Alim Akhtar, Pankaj Dubey
Hi Krzysztof,
On 2018-04-24 19:36, Krzysztof Kozlowski wrote:
> Remove the address space mapping between root and soc nodes to fix
> DTC warnings in Exynos5433 and Exynos7 like:
>
> arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
> Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Works fine on Samsung Exynos5433-based TM2e board.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> Not tested.
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 828996a06610..ba8157ceaa56 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -18,8 +18,8 @@
>
> / {
> compatible = "samsung,exynos5433";
> - #address-cells = <2>;
> - #size-cells = <2>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> interrupt-parent = <&gic>;
>
> @@ -235,7 +235,7 @@
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0x0 0x0 0x18000000>;
> + ranges;
>
> arm_a53_pmu {
> compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3";
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 0b98d2334cad..93a84338938a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -12,8 +12,8 @@
> / {
> compatible = "samsung,exynos7";
> interrupt-parent = <&gic>;
> - #address-cells = <2>;
> - #size-cells = <2>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> aliases {
> pinctrl0 = &pinctrl_alive;
> @@ -70,7 +70,7 @@
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0 0 0 0x18000000>;
> + ranges;
>
> chipid@10000000 {
> compatible = "samsung,exynos4210-chipid";
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFT][PATCH] arm64: dts: exynos: Remove unneeded address space mapping for soc node
2018-04-25 5:52 ` Marek Szyprowski
@ 2018-04-29 17:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-04-29 17:26 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim, Chanwoo Choi, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Alim Akhtar, Pankaj Dubey
On Wed, Apr 25, 2018 at 07:52:45AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 2018-04-24 19:36, Krzysztof Kozlowski wrote:
> > Remove the address space mapping between root and soc nodes to fix
> > DTC warnings in Exynos5433 and Exynos7 like:
> >
> > arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
> > Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Works fine on Samsung Exynos5433-based TM2e board.
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks for testing! Applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-29 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180424173731epcas2p15cddb6a4ea379f6d1736a93961a9c913@epcas2p1.samsung.com>
2018-04-24 17:36 ` [RFT][PATCH] arm64: dts: exynos: Remove unneeded address space mapping for soc node Krzysztof Kozlowski
2018-04-25 5:52 ` Marek Szyprowski
2018-04-29 17:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).