* [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
@ 2018-05-02 7:53 Ganesh Mahendran
2018-05-02 12:23 ` Will Deacon
0 siblings, 1 reply; 7+ messages in thread
From: Ganesh Mahendran @ 2018-05-02 7:53 UTC (permalink / raw)
To: ldufour, catalin.marinas, will.deacon
Cc: linux-arm-kernel, linux-kernel, linux-mm, Ganesh Mahendran
Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
enables Speculative Page Fault handler.
Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
This patch is on top of Laurent's v10 spf
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index eb2cf49..cd583a9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -144,6 +144,7 @@ config ARM64
select SPARSE_IRQ
select SYSCTL_EXCEPTION_TRACE
select THREAD_INFO_IN_TASK
+ select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
help
ARM 64-bit (AArch64) Linux support.
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
2018-05-02 7:53 [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT Ganesh Mahendran
@ 2018-05-02 12:23 ` Will Deacon
2018-05-04 6:05 ` Ganesh Mahendran
0 siblings, 1 reply; 7+ messages in thread
From: Will Deacon @ 2018-05-02 12:23 UTC (permalink / raw)
To: Ganesh Mahendran
Cc: ldufour, catalin.marinas, linux-arm-kernel, linux-kernel, linux-mm
On Wed, May 02, 2018 at 03:53:21PM +0800, Ganesh Mahendran wrote:
> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
> enables Speculative Page Fault handler.
Are there are tests for this? I'm really nervous about enabling it...
Will
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> This patch is on top of Laurent's v10 spf
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index eb2cf49..cd583a9 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -144,6 +144,7 @@ config ARM64
> select SPARSE_IRQ
> select SYSCTL_EXCEPTION_TRACE
> select THREAD_INFO_IN_TASK
> + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
> help
> ARM 64-bit (AArch64) Linux support.
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
2018-05-02 12:23 ` Will Deacon
@ 2018-05-04 6:05 ` Ganesh Mahendran
0 siblings, 0 replies; 7+ messages in thread
From: Ganesh Mahendran @ 2018-05-04 6:05 UTC (permalink / raw)
To: Will Deacon
Cc: Laurent Dufour, Catalin Marinas, linux-arm-kernel, linux-kernel,
Linux-MM
2018-05-02 20:23 GMT+08:00 Will Deacon <will.deacon@arm.com>:
> On Wed, May 02, 2018 at 03:53:21PM +0800, Ganesh Mahendran wrote:
>> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
>> enables Speculative Page Fault handler.
>
> Are there are tests for this? I'm really nervous about enabling it...
Hi, Will
I test the arm64 spf on Qcom SDM845 cpu with kernel 4.9.
It looks good for performance, and have not found stability issue yet.
Thanks.
>
> Will
>
>>
>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>> ---
>> This patch is on top of Laurent's v10 spf
>> ---
>> arch/arm64/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index eb2cf49..cd583a9 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -144,6 +144,7 @@ config ARM64
>> select SPARSE_IRQ
>> select SYSCTL_EXCEPTION_TRACE
>> select THREAD_INFO_IN_TASK
>> + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
>> help
>> ARM 64-bit (AArch64) Linux support.
>>
>> --
>> 1.9.1
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
2018-05-02 7:54 Ganesh Mahendran
2018-05-02 9:00 ` Laurent Dufour
@ 2018-05-03 8:48 ` Chintan Pandya
1 sibling, 0 replies; 7+ messages in thread
From: Chintan Pandya @ 2018-05-03 8:48 UTC (permalink / raw)
To: Ganesh Mahendran, ldufour, catalin.marinas, will.deacon
Cc: linux-mm, linux-kernel, linux-arm-kernel
On 5/2/2018 1:24 PM, Ganesh Mahendran wrote:
> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
> enables Speculative Page Fault handler.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> This patch is on top of Laurent's v10 spf
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index eb2cf49..cd583a9 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -144,6 +144,7 @@ config ARM64
> select SPARSE_IRQ
> select SYSCTL_EXCEPTION_TRACE
> select THREAD_INFO_IN_TASK
> + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
> help
> ARM 64-bit (AArch64) Linux support.
>
>
You may also consider re-ordering of patches in next version. Generally,
config enablement assumes effectiveness of that config.
Chintan
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
2018-05-02 9:00 ` Laurent Dufour
@ 2018-05-02 11:05 ` Mark Rutland
0 siblings, 0 replies; 7+ messages in thread
From: Mark Rutland @ 2018-05-02 11:05 UTC (permalink / raw)
To: Laurent Dufour
Cc: Ganesh Mahendran, catalin.marinas, will.deacon, linux-arm-kernel,
linux-kernel, linux-mm
On Wed, May 02, 2018 at 11:00:55AM +0200, Laurent Dufour wrote:
> On 02/05/2018 09:54, Ganesh Mahendran wrote:
> > Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
> > enables Speculative Page Fault handler.
> >
> > Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> > ---
> > This patch is on top of Laurent's v10 spf
> > ---
> > arch/arm64/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index eb2cf49..cd583a9 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -144,6 +144,7 @@ config ARM64
> > select SPARSE_IRQ
> > select SYSCTL_EXCEPTION_TRACE
> > select THREAD_INFO_IN_TASK
> > + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
>
> There is no need to depend on SMP here as the upper
> CONFIG_SPECULATIVE_PAGE_FAULT is depending on SMP.
Additionally, since commit:
4b3dc9679cf77933 ("arm64: force CONFIG_SMP=y and remove redundant #ifdefs")
... arm64 is always SMP.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
2018-05-02 7:54 Ganesh Mahendran
@ 2018-05-02 9:00 ` Laurent Dufour
2018-05-02 11:05 ` Mark Rutland
2018-05-03 8:48 ` Chintan Pandya
1 sibling, 1 reply; 7+ messages in thread
From: Laurent Dufour @ 2018-05-02 9:00 UTC (permalink / raw)
To: Ganesh Mahendran, catalin.marinas, will.deacon
Cc: linux-arm-kernel, linux-kernel, linux-mm
On 02/05/2018 09:54, Ganesh Mahendran wrote:
> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
> enables Speculative Page Fault handler.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
> This patch is on top of Laurent's v10 spf
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index eb2cf49..cd583a9 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -144,6 +144,7 @@ config ARM64
> select SPARSE_IRQ
> select SYSCTL_EXCEPTION_TRACE
> select THREAD_INFO_IN_TASK
> + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
There is no need to depend on SMP here as the upper
CONFIG_SPECULATIVE_PAGE_FAULT is depending on SMP.
> help
> ARM 64-bit (AArch64) Linux support.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
@ 2018-05-02 7:54 Ganesh Mahendran
2018-05-02 9:00 ` Laurent Dufour
2018-05-03 8:48 ` Chintan Pandya
0 siblings, 2 replies; 7+ messages in thread
From: Ganesh Mahendran @ 2018-05-02 7:54 UTC (permalink / raw)
To: ldufour, catalin.marinas, will.deacon
Cc: linux-arm-kernel, linux-kernel, linux-mm, Ganesh Mahendran
Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This
enables Speculative Page Fault handler.
Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
This patch is on top of Laurent's v10 spf
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index eb2cf49..cd583a9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -144,6 +144,7 @@ config ARM64
select SPARSE_IRQ
select SYSCTL_EXCEPTION_TRACE
select THREAD_INFO_IN_TASK
+ select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT if SMP
help
ARM 64-bit (AArch64) Linux support.
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-04 6:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 7:53 [PATCH 1/2] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT Ganesh Mahendran
2018-05-02 12:23 ` Will Deacon
2018-05-04 6:05 ` Ganesh Mahendran
2018-05-02 7:54 Ganesh Mahendran
2018-05-02 9:00 ` Laurent Dufour
2018-05-02 11:05 ` Mark Rutland
2018-05-03 8:48 ` Chintan Pandya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).