* [PATCH 01/21] i2c: algo: bit: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 02/21] i2c: algo: pca: " Peter Rosin
` (20 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/algos/i2c-algo-bit.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index 3df0efd69ae3..4a34f311e1ff 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -519,9 +519,7 @@ static int bit_doAddress(struct i2c_adapter *i2c_adap, struct i2c_msg *msg)
}
}
} else { /* normal 7bit address */
- addr = msg->addr << 1;
- if (flags & I2C_M_RD)
- addr |= 1;
+ addr = i2c_8bit_addr_from_msg(msg);
if (flags & I2C_M_REV_DIR_ADDR)
addr ^= 1;
ret = try_address(i2c_adap, addr, retries);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 02/21] i2c: algo: pca: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
2018-05-14 14:53 ` [PATCH 01/21] i2c: algo: bit: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 03/21] i2c: algo: pcf: " Peter Rosin
` (19 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/algos/i2c-algo-pca.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
index e370804ec8bc..883a290f6a4d 100644
--- a/drivers/i2c/algos/i2c-algo-pca.c
+++ b/drivers/i2c/algos/i2c-algo-pca.c
@@ -112,11 +112,8 @@ static int pca_address(struct i2c_algo_pca_data *adap,
struct i2c_msg *msg)
{
int sta = pca_get_con(adap);
- int addr;
+ int addr = i2c_8bit_addr_from_msg(msg);
- addr = ((0x7f & msg->addr) << 1);
- if (msg->flags & I2C_M_RD)
- addr |= 1;
DEB2("=== SLAVE ADDRESS %#04x+%c=%#04x\n",
msg->addr, msg->flags & I2C_M_RD ? 'R' : 'W', addr);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 03/21] i2c: algo: pcf: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
2018-05-14 14:53 ` [PATCH 01/21] i2c: algo: bit: " Peter Rosin
2018-05-14 14:53 ` [PATCH 02/21] i2c: algo: pca: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 16:59 ` Andy Shevchenko
2018-05-14 14:53 ` [PATCH 04/21] i2c: aspeed: " Peter Rosin
` (18 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/algos/i2c-algo-pcf.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c
index 270d84bfc2c6..bb60c1bd1f2d 100644
--- a/drivers/i2c/algos/i2c-algo-pcf.c
+++ b/drivers/i2c/algos/i2c-algo-pcf.c
@@ -292,11 +292,8 @@ static int pcf_doAddress(struct i2c_algo_pcf_data *adap,
struct i2c_msg *msg)
{
unsigned short flags = msg->flags;
- unsigned char addr;
+ unsigned char addr = i2c_8bit_addr_from_msg(msg);
- addr = msg->addr << 1;
- if (flags & I2C_M_RD)
- addr |= 1;
if (flags & I2C_M_REV_DIR_ADDR)
addr ^= 1;
i2c_outb(adap, addr);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 03/21] i2c: algo: pcf: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 ` [PATCH 03/21] i2c: algo: pcf: " Peter Rosin
@ 2018-05-14 16:59 ` Andy Shevchenko
2018-05-14 17:03 ` Peter Rosin
0 siblings, 1 reply; 30+ messages in thread
From: Andy Shevchenko @ 2018-05-14 16:59 UTC (permalink / raw)
To: Peter Rosin; +Cc: Linux Kernel Mailing List, linux-i2c, Wolfram Sang
On Mon, May 14, 2018 at 5:53 PM, Peter Rosin <peda@axentia.se> wrote:
> Because it looks neater.
> drivers/i2c/algos/i2c-algo-pcf.c | 5 +----
I guess for such trivial no functional change patches you may do them
one per folder, and not one-per driver.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 03/21] i2c: algo: pcf: make use of i2c_8bit_addr_from_msg
2018-05-14 16:59 ` Andy Shevchenko
@ 2018-05-14 17:03 ` Peter Rosin
0 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 17:03 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linux Kernel Mailing List, linux-i2c, Wolfram Sang
On 2018-05-14 18:59, Andy Shevchenko wrote:
> On Mon, May 14, 2018 at 5:53 PM, Peter Rosin <peda@axentia.se> wrote:
>> Because it looks neater.
>
>> drivers/i2c/algos/i2c-algo-pcf.c | 5 +----
>
> I guess for such trivial no functional change patches you may do them
> one per folder, and not one-per driver.
Right, will do for v2, if I don't hear anything else...
Cheers,
Peter
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 04/21] i2c: aspeed: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (2 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 03/21] i2c: algo: pcf: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 05/21] i2c: axxia: " Peter Rosin
` (17 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Rosin, Brendan Higgins, Benjamin Herrenschmidt,
Joel Stanley, Andrew Jeffery, linux-i2c, openbmc,
linux-arm-kernel, linux-aspeed, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 7d4aeb4465b3..60e4d0e939a3 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -335,13 +335,12 @@ static void aspeed_i2c_do_start(struct aspeed_i2c_bus *bus)
{
u32 command = ASPEED_I2CD_M_START_CMD | ASPEED_I2CD_M_TX_CMD;
struct i2c_msg *msg = &bus->msgs[bus->msgs_index];
- u8 slave_addr = msg->addr << 1;
+ u8 slave_addr = i2c_8bit_addr_from_msg(msg);
bus->master_state = ASPEED_I2C_MASTER_START;
bus->buf_index = 0;
if (msg->flags & I2C_M_RD) {
- slave_addr |= 1;
command |= ASPEED_I2CD_M_RX_CMD;
/* Need to let the hardware know to NACK after RX. */
if (msg->len == 1 && !(msg->flags & I2C_M_RECV_LEN))
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 05/21] i2c: axxia: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (3 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 04/21] i2c: aspeed: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 06/21] i2c: diolan: " Peter Rosin
` (16 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-axxia.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-axxia.c b/drivers/i2c/busses/i2c-axxia.c
index 13f07482ec68..f70b097fd567 100644
--- a/drivers/i2c/busses/i2c-axxia.c
+++ b/drivers/i2c/busses/i2c-axxia.c
@@ -351,13 +351,15 @@ static int axxia_i2c_xfer_msg(struct axxia_i2c_dev *idev, struct i2c_msg *msg)
* addr_2: addr[7:0]
*/
addr_1 = 0xF0 | ((msg->addr >> 7) & 0x06);
+ if (i2c_m_rd(msg))
+ addr_1 |= 1; /* Set the R/nW bit of the address */
addr_2 = msg->addr & 0xFF;
} else {
/* 7-bit address
* addr_1: addr[6:0] | (R/nW)
* addr_2: dont care
*/
- addr_1 = (msg->addr << 1) & 0xFF;
+ addr_1 = i2c_8bit_addr_from_msg(msg);
addr_2 = 0;
}
@@ -365,7 +367,6 @@ static int axxia_i2c_xfer_msg(struct axxia_i2c_dev *idev, struct i2c_msg *msg)
/* I2C read transfer */
rx_xfer = i2c_m_recv_len(msg) ? I2C_SMBUS_BLOCK_MAX : msg->len;
tx_xfer = 0;
- addr_1 |= 1; /* Set the R/nW bit of the address */
} else {
/* I2C write transfer */
rx_xfer = 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 06/21] i2c: diolan: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (4 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 05/21] i2c: axxia: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 15:50 ` Guenter Roeck
2018-05-14 14:53 ` [PATCH 07/21] i2c: efm32: " Peter Rosin
` (15 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, Guenter Roeck, linux-i2c, Wolfram Sang
Because it looks neater and allows factoring out some code
that is now common between if and else.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-diolan-u2c.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-diolan-u2c.c b/drivers/i2c/busses/i2c-diolan-u2c.c
index f718ee4e3332..3f28317cde39 100644
--- a/drivers/i2c/busses/i2c-diolan-u2c.c
+++ b/drivers/i2c/busses/i2c-diolan-u2c.c
@@ -360,11 +360,11 @@ static int diolan_usb_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
if (ret < 0)
goto abort;
}
+ ret = diolan_i2c_put_byte_ack(dev,
+ i2c_8bit_addr_from_msg(pmsg));
+ if (ret < 0)
+ goto abort;
if (pmsg->flags & I2C_M_RD) {
- ret =
- diolan_i2c_put_byte_ack(dev, (pmsg->addr << 1) | 1);
- if (ret < 0)
- goto abort;
for (j = 0; j < pmsg->len; j++) {
u8 byte;
bool ack = j < pmsg->len - 1;
@@ -393,9 +393,6 @@ static int diolan_usb_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
pmsg->buf[j] = byte;
}
} else {
- ret = diolan_i2c_put_byte_ack(dev, pmsg->addr << 1);
- if (ret < 0)
- goto abort;
for (j = 0; j < pmsg->len; j++) {
ret = diolan_i2c_put_byte_ack(dev,
pmsg->buf[j]);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 06/21] i2c: diolan: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 ` [PATCH 06/21] i2c: diolan: " Peter Rosin
@ 2018-05-14 15:50 ` Guenter Roeck
0 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2018-05-14 15:50 UTC (permalink / raw)
To: Peter Rosin; +Cc: linux-kernel, linux-i2c, Wolfram Sang
On Mon, May 14, 2018 at 04:53:15PM +0200, Peter Rosin wrote:
> Because it looks neater and allows factoring out some code
> that is now common between if and else.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/i2c/busses/i2c-diolan-u2c.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-diolan-u2c.c b/drivers/i2c/busses/i2c-diolan-u2c.c
> index f718ee4e3332..3f28317cde39 100644
> --- a/drivers/i2c/busses/i2c-diolan-u2c.c
> +++ b/drivers/i2c/busses/i2c-diolan-u2c.c
> @@ -360,11 +360,11 @@ static int diolan_usb_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
> if (ret < 0)
> goto abort;
> }
> + ret = diolan_i2c_put_byte_ack(dev,
> + i2c_8bit_addr_from_msg(pmsg));
> + if (ret < 0)
> + goto abort;
> if (pmsg->flags & I2C_M_RD) {
> - ret =
> - diolan_i2c_put_byte_ack(dev, (pmsg->addr << 1) | 1);
> - if (ret < 0)
> - goto abort;
> for (j = 0; j < pmsg->len; j++) {
> u8 byte;
> bool ack = j < pmsg->len - 1;
> @@ -393,9 +393,6 @@ static int diolan_usb_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
> pmsg->buf[j] = byte;
> }
> } else {
> - ret = diolan_i2c_put_byte_ack(dev, pmsg->addr << 1);
> - if (ret < 0)
> - goto abort;
> for (j = 0; j < pmsg->len; j++) {
> ret = diolan_i2c_put_byte_ack(dev,
> pmsg->buf[j]);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 07/21] i2c: efm32: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (5 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 06/21] i2c: diolan: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 18:27 ` Uwe Kleine-König
2018-05-14 14:53 ` [PATCH 08/21] i2c: eg20t: " Peter Rosin
` (14 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Rosin, Uwe Kleine-König, Pengutronix Kernel Team,
linux-i2c, linux-arm-kernel, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-efm32.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
index aa336ba89aa3..5f2bab878b2c 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -144,8 +144,7 @@ static void efm32_i2c_send_next_msg(struct efm32_i2c_ddata *ddata)
struct i2c_msg *cur_msg = &ddata->msgs[ddata->current_msg];
efm32_i2c_write32(ddata, REG_CMD, REG_CMD_START);
- efm32_i2c_write32(ddata, REG_TXDATA, cur_msg->addr << 1 |
- (cur_msg->flags & I2C_M_RD ? 1 : 0));
+ efm32_i2c_write32(ddata, REG_TXDATA, i2c_8bit_addr_from_msg(cur_msg));
}
static void efm32_i2c_send_next_byte(struct efm32_i2c_ddata *ddata)
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 07/21] i2c: efm32: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 ` [PATCH 07/21] i2c: efm32: " Peter Rosin
@ 2018-05-14 18:27 ` Uwe Kleine-König
0 siblings, 0 replies; 30+ messages in thread
From: Uwe Kleine-König @ 2018-05-14 18:27 UTC (permalink / raw)
To: Peter Rosin
Cc: linux-kernel, Wolfram Sang, linux-i2c, Pengutronix Kernel Team,
linux-arm-kernel
Hello Peter,
On Mon, May 14, 2018 at 04:53:16PM +0200, Peter Rosin wrote:
> Because it looks neater.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/i2c/busses/i2c-efm32.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
> index aa336ba89aa3..5f2bab878b2c 100644
> --- a/drivers/i2c/busses/i2c-efm32.c
> +++ b/drivers/i2c/busses/i2c-efm32.c
> @@ -144,8 +144,7 @@ static void efm32_i2c_send_next_msg(struct efm32_i2c_ddata *ddata)
> struct i2c_msg *cur_msg = &ddata->msgs[ddata->current_msg];
>
> efm32_i2c_write32(ddata, REG_CMD, REG_CMD_START);
> - efm32_i2c_write32(ddata, REG_TXDATA, cur_msg->addr << 1 |
> - (cur_msg->flags & I2C_M_RD ? 1 : 0));
> + efm32_i2c_write32(ddata, REG_TXDATA, i2c_8bit_addr_from_msg(cur_msg));
Nice,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards and thanks,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 08/21] i2c: eg20t: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (6 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 07/21] i2c: efm32: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 09/21] i2c: emev2: " Peter Rosin
` (13 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
pch_i2c_writebytes is always called with a write in msgs->flags,
and pch_i2c_readbytes with a read.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-eg20t.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index bdeab0174fec..835d54ac2971 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -414,7 +414,7 @@ static s32 pch_i2c_writebytes(struct i2c_adapter *i2c_adap,
iowrite32(addr_8_lsb, p + PCH_I2CDR);
} else {
/* set 7 bit slave address and R/W bit as 0 */
- iowrite32(addr << 1, p + PCH_I2CDR);
+ iowrite32(i2c_8bit_addr_from_msg(msgs), p + PCH_I2CDR);
if (first)
pch_i2c_start(adap);
}
@@ -538,8 +538,7 @@ static s32 pch_i2c_readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
iowrite32(addr_2_msb | TEN_BIT_ADDR_MASK, p + PCH_I2CDR);
} else {
/* 7 address bits + R/W bit */
- addr = (((addr) << 1) | (I2C_RD));
- iowrite32(addr, p + PCH_I2CDR);
+ iowrite32(i2c_8bit_addr_from_msg(msgs), p + PCH_I2CDR);
}
/* check if it is the first message */
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 09/21] i2c: emev2: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (7 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 08/21] i2c: eg20t: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 10/21] i2c: hix5hd2: " Peter Rosin
` (12 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, Wolfram Sang, linux-i2c
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-emev2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c
index d2e84480fbe9..ba9b6ea48a31 100644
--- a/drivers/i2c/busses/i2c-emev2.c
+++ b/drivers/i2c/busses/i2c-emev2.c
@@ -149,7 +149,7 @@ static int __em_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msg,
em_clear_set_bit(priv, 0, I2C_BIT_STT0, I2C_OFS_IICC0);
/* Send slave address and R/W type */
- writeb((msg->addr << 1) | read, priv->base + I2C_OFS_IIC0);
+ writeb(i2c_8bit_addr_from_msg(msg), priv->base + I2C_OFS_IIC0);
/* Wait for transaction */
status = em_i2c_wait_for_event(priv);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 10/21] i2c: hix5hd2: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (8 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 09/21] i2c: emev2: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 11/21] i2c: imx-lpi2c: " Peter Rosin
` (11 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-hix5hd2.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
index bb68957d3da5..399b64c4c620 100644
--- a/drivers/i2c/busses/i2c-hix5hd2.c
+++ b/drivers/i2c/busses/i2c-hix5hd2.c
@@ -73,7 +73,6 @@
#define I2C_OVER_INTR BIT(0)
#define HIX5I2C_MAX_FREQ 400000 /* 400k */
-#define HIX5I2C_READ_OPERATION 0x01
enum hix5hd2_i2c_state {
HIX5I2C_STAT_RW_ERR = -1,
@@ -311,12 +310,8 @@ static void hix5hd2_i2c_message_start(struct hix5hd2_i2c_priv *priv, int stop)
hix5hd2_i2c_clr_all_irq(priv);
hix5hd2_i2c_enable_irq(priv);
- if (priv->msg->flags & I2C_M_RD)
- writel_relaxed((priv->msg->addr << 1) | HIX5I2C_READ_OPERATION,
- priv->regs + HIX5I2C_TXR);
- else
- writel_relaxed(priv->msg->addr << 1,
- priv->regs + HIX5I2C_TXR);
+ writel_relaxed(i2c_8bit_addr_from_msg(priv->msg),
+ priv->regs + HIX5I2C_TXR);
writel_relaxed(I2C_WRITE | I2C_START, priv->regs + HIX5I2C_COM);
spin_unlock_irqrestore(&priv->lock, flags);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 11/21] i2c: imx-lpi2c: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (9 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 10/21] i2c: hix5hd2: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 12/21] i2c: imx: " Peter Rosin
` (10 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index e6da2c7a9a3e..159d23211600 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -180,15 +180,13 @@ static int lpi2c_imx_start(struct lpi2c_imx_struct *lpi2c_imx,
struct i2c_msg *msgs)
{
unsigned int temp;
- u8 read;
temp = readl(lpi2c_imx->base + LPI2C_MCR);
temp |= MCR_RRF | MCR_RTF;
writel(temp, lpi2c_imx->base + LPI2C_MCR);
writel(0x7f00, lpi2c_imx->base + LPI2C_MSR);
- read = msgs->flags & I2C_M_RD;
- temp = (msgs->addr << 1 | read) | (GEN_START << 8);
+ temp = i2c_8bit_addr_from_msg(msgs) | (GEN_START << 8);
writel(temp, lpi2c_imx->base + LPI2C_MTDR);
return lpi2c_imx_bus_busy(lpi2c_imx);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 12/21] i2c: imx: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (10 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 11/21] i2c: imx-lpi2c: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 18:32 ` Uwe Kleine-König
2018-05-14 14:53 ` [PATCH 13/21] i2c: kempld: " Peter Rosin
` (9 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
i2c_imx_dma_write and i2c_imx_write are always called with a
write in msgs->flags, and i2c_imx_read with a read.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-imx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index d7267dd9c7bf..bcb41fc75043 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -630,7 +630,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
* Write slave address.
* The first byte must be transmitted by the CPU.
*/
- imx_i2c_write_reg(msgs->addr << 1, i2c_imx, IMX_I2C_I2DR);
+ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR);
reinit_completion(&i2c_imx->dma->cmd_complete);
time_left = wait_for_completion_timeout(
&i2c_imx->dma->cmd_complete,
@@ -760,10 +760,10 @@ static int i2c_imx_write(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs)
int i, result;
dev_dbg(&i2c_imx->adapter.dev, "<%s> write slave address: addr=0x%x\n",
- __func__, msgs->addr << 1);
+ __func__, i2c_8bit_addr_from_msg(msgs));
/* write slave address */
- imx_i2c_write_reg(msgs->addr << 1, i2c_imx, IMX_I2C_I2DR);
+ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR);
result = i2c_imx_trx_complete(i2c_imx);
if (result)
return result;
@@ -796,10 +796,10 @@ static int i2c_imx_read(struct imx_i2c_struct *i2c_imx, struct i2c_msg *msgs, bo
dev_dbg(&i2c_imx->adapter.dev,
"<%s> write slave address: addr=0x%x\n",
- __func__, (msgs->addr << 1) | 0x01);
+ __func__, i2c_8bit_addr_from_msg(msgs));
/* write slave address */
- imx_i2c_write_reg((msgs->addr << 1) | 0x01, i2c_imx, IMX_I2C_I2DR);
+ imx_i2c_write_reg(i2c_8bit_addr_from_msg(msgs), i2c_imx, IMX_I2C_I2DR);
result = i2c_imx_trx_complete(i2c_imx);
if (result)
return result;
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 12/21] i2c: imx: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 ` [PATCH 12/21] i2c: imx: " Peter Rosin
@ 2018-05-14 18:32 ` Uwe Kleine-König
0 siblings, 0 replies; 30+ messages in thread
From: Uwe Kleine-König @ 2018-05-14 18:32 UTC (permalink / raw)
To: Peter Rosin; +Cc: linux-kernel, linux-i2c, Wolfram Sang
On Mon, May 14, 2018 at 04:53:21PM +0200, Peter Rosin wrote:
> Because it looks neater.
> i2c_imx_dma_write and i2c_imx_write are always called with a
> write in msgs->flags, and i2c_imx_read with a read.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 13/21] i2c: kempld: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (11 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 12/21] i2c: imx: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 14/21] i2c: mxs: " Peter Rosin
` (8 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-kempld.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
index e879190b5d1d..1c874aaa0447 100644
--- a/drivers/i2c/busses/i2c-kempld.c
+++ b/drivers/i2c/busses/i2c-kempld.c
@@ -124,15 +124,14 @@ static int kempld_i2c_process(struct kempld_i2c_data *i2c)
/* 10 bit address? */
if (i2c->msg->flags & I2C_M_TEN) {
addr = 0xf0 | ((i2c->msg->addr >> 7) & 0x6);
+ /* Set read bit if necessary */
+ addr |= (i2c->msg->flags & I2C_M_RD) ? 1 : 0;
i2c->state = STATE_ADDR10;
} else {
- addr = (i2c->msg->addr << 1);
+ addr = i2c_8bit_addr_from_msg(i2c->msg);
i2c->state = STATE_START;
}
- /* Set read bit if necessary */
- addr |= (i2c->msg->flags & I2C_M_RD) ? 1 : 0;
-
kempld_write8(pld, KEMPLD_I2C_DATA, addr);
kempld_write8(pld, KEMPLD_I2C_CMD, I2C_CMD_START);
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 14/21] i2c: mxs: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (12 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 13/21] i2c: kempld: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 15/21] i2c: ocores: " Peter Rosin
` (7 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-mxs.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index e617bd600794..f62ae3d42232 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -180,9 +180,10 @@ static int mxs_i2c_dma_setup_xfer(struct i2c_adapter *adap,
struct dma_async_tx_descriptor *desc;
struct mxs_i2c_dev *i2c = i2c_get_adapdata(adap);
+ i2c->addr_data = i2c_8bit_addr_from_msg(msg);
+
if (msg->flags & I2C_M_RD) {
i2c->dma_read = true;
- i2c->addr_data = (msg->addr << 1) | I2C_SMBUS_READ;
/*
* SELECT command.
@@ -240,7 +241,6 @@ static int mxs_i2c_dma_setup_xfer(struct i2c_adapter *adap,
}
} else {
i2c->dma_read = false;
- i2c->addr_data = (msg->addr << 1) | I2C_SMBUS_WRITE;
/*
* WRITE command.
@@ -371,7 +371,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
struct i2c_msg *msg, uint32_t flags)
{
struct mxs_i2c_dev *i2c = i2c_get_adapdata(adap);
- uint32_t addr_data = msg->addr << 1;
+ uint32_t addr_data = i2c_8bit_addr_from_msg(msg);
uint32_t data = 0;
int i, ret, xlen = 0, xmit = 0;
uint32_t start;
@@ -411,8 +411,6 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
*/
BUG_ON(msg->len > 4);
- addr_data |= I2C_SMBUS_READ;
-
/* SELECT command. */
mxs_i2c_pio_trigger_write_cmd(i2c, MXS_CMD_I2C_SELECT,
addr_data);
@@ -450,7 +448,6 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
* fast enough. It is possible to transfer arbitrary amount
* of data using PIO write.
*/
- addr_data |= I2C_SMBUS_WRITE;
/*
* The LSB of data buffer is the first byte blasted across
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 15/21] i2c: ocores: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (13 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 14/21] i2c: mxs: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 16/21] i2c: pasemi: " Peter Rosin
` (6 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, Peter Korsgaard, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-ocores.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 8c42ca7107b2..a540916689b2 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -222,10 +222,7 @@ static int ocores_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
i2c->nmsgs = num;
i2c->state = STATE_START;
- oc_setreg(i2c, OCI2C_DATA,
- (i2c->msg->addr << 1) |
- ((i2c->msg->flags & I2C_M_RD) ? 1:0));
-
+ oc_setreg(i2c, OCI2C_DATA, i2c_8bit_addr_from_msg(i2c->msg));
oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_START);
if (wait_event_timeout(i2c->wait, (i2c->state == STATE_ERROR) ||
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 16/21] i2c: pasemi: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (14 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 15/21] i2c: ocores: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 17/21] i2c: qup: " Peter Rosin
` (5 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linuxppc-dev, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-pasemi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pasemi.c b/drivers/i2c/busses/i2c-pasemi.c
index df1dbc92a024..55fd5c6f3cca 100644
--- a/drivers/i2c/busses/i2c-pasemi.c
+++ b/drivers/i2c/busses/i2c-pasemi.c
@@ -121,7 +121,7 @@ static int pasemi_i2c_xfer_msg(struct i2c_adapter *adapter,
read = msg->flags & I2C_M_RD ? 1 : 0;
- TXFIFO_WR(smbus, MTXFIFO_START | (msg->addr << 1) | read);
+ TXFIFO_WR(smbus, MTXFIFO_START | i2c_8bit_addr_from_msg(msg));
if (read) {
TXFIFO_WR(smbus, msg->len | MTXFIFO_READ |
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 17/21] i2c: qup: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (15 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 16/21] i2c: pasemi: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 18/21] i2c: rcar: " Peter Rosin
` (4 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Rosin, Andy Gross, David Brown, linux-arm-msm, linux-soc,
linux-i2c, Wolfram Sang
Because it looks neater.
qup_i2c_write_tx_fifo_v1 is always called with a write in
qup->msg->flags.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-qup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 904dfec7ab96..025232207aeb 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -453,7 +453,7 @@ static void qup_i2c_write_tx_fifo_v1(struct qup_i2c_dev *qup)
{
struct qup_i2c_block *blk = &qup->blk;
struct i2c_msg *msg = qup->msg;
- u32 addr = msg->addr << 1;
+ u32 addr = i2c_8bit_addr_from_msg(msg);
u32 qup_tag;
int idx;
u32 val;
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 18/21] i2c: rcar: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (16 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 17/21] i2c: qup: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 19/21] i2c: riic: " Peter Rosin
` (3 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, Wolfram Sang, linux-i2c
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index c6915b835396..17b91ddbe013 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -329,7 +329,7 @@ static void rcar_i2c_prepare_msg(struct rcar_i2c_priv *priv)
if (priv->msgs_left == 1)
priv->flags |= ID_LAST_MSG;
- rcar_i2c_write(priv, ICMAR, (priv->msg->addr << 1) | read);
+ rcar_i2c_write(priv, ICMAR, i2c_8bit_addr_from_msg(priv->msg));
/*
* We don't have a test case but the HW engineers say that the write order
* of ICMSR and ICMCR depends on whether we issue START or REP_START. Since
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 19/21] i2c: riic: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (17 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 18/21] i2c: rcar: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 14:53 ` [PATCH 20/21] i2c: stu300: " Peter Rosin
` (2 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-riic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c
index 95c2f1ce3cad..5f1fca7880b1 100644
--- a/drivers/i2c/busses/i2c-riic.c
+++ b/drivers/i2c/busses/i2c-riic.c
@@ -167,15 +167,14 @@ static irqreturn_t riic_tdre_isr(int irq, void *data)
return IRQ_NONE;
if (riic->bytes_left == RIIC_INIT_MSG) {
- val = !!(riic->msg->flags & I2C_M_RD);
- if (val)
+ if (riic->msg->flags & I2C_M_RD)
/* On read, switch over to receive interrupt */
riic_clear_set_bit(riic, ICIER_TIE, ICIER_RIE, RIIC_ICIER);
else
/* On write, initialize length */
riic->bytes_left = riic->msg->len;
- val |= (riic->msg->addr << 1);
+ val = i2c_8bit_addr_from_msg(riic->msg);
} else {
val = *riic->buf;
riic->buf++;
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 20/21] i2c: stu300: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (18 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 19/21] i2c: riic: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 19:54 ` Linus Walleij
2018-05-14 14:53 ` [PATCH 21/21] i2c: xiic: " Peter Rosin
2018-05-14 16:11 ` [PATCH 00/21] i2c: " Joe Perches
21 siblings, 1 reply; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Rosin, Linus Walleij, linux-arm-kernel, linux-i2c, Wolfram Sang
Because it looks neater.
Also restructure debug output for resends, since that code as a
result is only handling debug output.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-stu300.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c
index dc63236b45b2..e866c481bfc3 100644
--- a/drivers/i2c/busses/i2c-stu300.c
+++ b/drivers/i2c/busses/i2c-stu300.c
@@ -602,20 +602,24 @@ static int stu300_send_address(struct stu300_dev *dev,
u32 val;
int ret;
- if (msg->flags & I2C_M_TEN)
+ if (msg->flags & I2C_M_TEN) {
/* This is probably how 10 bit addresses look */
val = (0xf0 | (((u32) msg->addr & 0x300) >> 7)) &
I2C_DR_D_MASK;
- else
- val = ((msg->addr << 1) & I2C_DR_D_MASK);
+ if (msg->flags & I2C_M_RD)
+ /* This is the direction bit */
+ val |= 0x01;
+ } else {
+ val = i2c_8bit_addr_from_msg(msg);
+ }
- if (msg->flags & I2C_M_RD) {
- /* This is the direction bit */
- val |= 0x01;
- if (resend)
+ if (resend) {
+ if (msg->flags & I2C_M_RD)
dev_dbg(&dev->pdev->dev, "read resend\n");
- } else if (resend)
- dev_dbg(&dev->pdev->dev, "write resend\n");
+ else
+ dev_dbg(&dev->pdev->dev, "write resend\n");
+ }
+
stu300_wr8(val, dev->virtbase + I2C_DR);
/* For 10bit addressing, await 10bit request (EVENT 9) */
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 20/21] i2c: stu300: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 ` [PATCH 20/21] i2c: stu300: " Peter Rosin
@ 2018-05-14 19:54 ` Linus Walleij
0 siblings, 0 replies; 30+ messages in thread
From: Linus Walleij @ 2018-05-14 19:54 UTC (permalink / raw)
To: Peter Rosin; +Cc: linux-kernel, Linux ARM, linux-i2c, Wolfram Sang
On Mon, May 14, 2018 at 4:53 PM, Peter Rosin <peda@axentia.se> wrote:
> Because it looks neater.
>
> Also restructure debug output for resends, since that code as a
> result is only handling debug output.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Looks good to me!
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 21/21] i2c: xiic: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (19 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 20/21] i2c: stu300: " Peter Rosin
@ 2018-05-14 14:53 ` Peter Rosin
2018-05-14 16:11 ` [PATCH 00/21] i2c: " Joe Perches
21 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 14:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Rosin, linux-i2c, Wolfram Sang
Because it looks neater.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/i2c/busses/i2c-xiic.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index c80527816ad0..1818c3b5c8d7 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -143,12 +143,6 @@ struct xiic_i2c {
#define XIIC_TX_RX_INTERRUPTS (XIIC_INTR_RX_FULL_MASK | XIIC_TX_INTERRUPTS)
-/* The following constants are used with the following macros to specify the
- * operation, a read or write operation.
- */
-#define XIIC_READ_OPERATION 1
-#define XIIC_WRITE_OPERATION 0
-
/*
* Tx Fifo upper bit masks.
*/
@@ -556,8 +550,7 @@ static void xiic_start_recv(struct xiic_i2c *i2c)
if (!(msg->flags & I2C_M_NOSTART))
/* write the address */
xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET,
- (msg->addr << 1) | XIIC_READ_OPERATION |
- XIIC_TX_DYN_START_MASK);
+ i2c_8bit_addr_from_msg(msg) | XIIC_TX_DYN_START_MASK);
xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK);
@@ -585,7 +578,7 @@ static void xiic_start_send(struct xiic_i2c *i2c)
if (!(msg->flags & I2C_M_NOSTART)) {
/* write the address */
- u16 data = ((msg->addr << 1) & 0xfe) | XIIC_WRITE_OPERATION |
+ u16 data = i2c_8bit_addr_from_msg(msg) |
XIIC_TX_DYN_START_MASK;
if ((i2c->nmsgs == 1) && msg->len == 0)
/* no data and last message -> add STOP */
--
2.11.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg
2018-05-14 14:53 [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
` (20 preceding siblings ...)
2018-05-14 14:53 ` [PATCH 21/21] i2c: xiic: " Peter Rosin
@ 2018-05-14 16:11 ` Joe Perches
2018-05-14 17:01 ` Peter Rosin
21 siblings, 1 reply; 30+ messages in thread
From: Joe Perches @ 2018-05-14 16:11 UTC (permalink / raw)
To: Peter Rosin, linux-kernel
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Andrew Jeffery, Guenter Roeck, Uwe Kleine-König,
Pengutronix Kernel Team, Wolfram Sang, Peter Korsgaard,
Andy Gross, David Brown, Linus Walleij, linux-i2c, openbmc,
linux-arm-kernel, linux-aspeed, linuxppc-dev, linux-arm-msm,
linux-soc
On Mon, 2018-05-14 at 16:53 +0200, Peter Rosin wrote:
> Hi!
>
> The nice little inline i2c_8bit_addr_from_msg is not getting
> enough use. This series improves the situation and drops a
> bunch of lines in the process.
Perhaps the inline should test for I2C_M_REV_DIR_ADDR
as there is at least one use like
- addr = msg->addr << 1;
- if (flags & I2C_M_RD)
- addr |= 1;
+ addr = i2c_8bit_addr_from_msg(msg);
if (flags & I2C_M_REV_DIR_ADDR)
addr ^= 1;
which look odd
Do any of these changes now no longer need
the temporary flags variable?
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg
2018-05-14 16:11 ` [PATCH 00/21] i2c: " Joe Perches
@ 2018-05-14 17:01 ` Peter Rosin
0 siblings, 0 replies; 30+ messages in thread
From: Peter Rosin @ 2018-05-14 17:01 UTC (permalink / raw)
To: Joe Perches, linux-kernel
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Andrew Jeffery, Guenter Roeck, Uwe Kleine-König,
Pengutronix Kernel Team, Wolfram Sang, Peter Korsgaard,
Andy Gross, David Brown, Linus Walleij, linux-i2c, openbmc,
linux-arm-kernel, linux-aspeed, linuxppc-dev, linux-arm-msm,
linux-soc
On 2018-05-14 18:11, Joe Perches wrote:
> On Mon, 2018-05-14 at 16:53 +0200, Peter Rosin wrote:
>> Hi!
>>
>> The nice little inline i2c_8bit_addr_from_msg is not getting
>> enough use. This series improves the situation and drops a
>> bunch of lines in the process.
>
> Perhaps the inline should test for I2C_M_REV_DIR_ADDR
> as there is at least one use like
>
> - addr = msg->addr << 1;
> - if (flags & I2C_M_RD)
> - addr |= 1;
> + addr = i2c_8bit_addr_from_msg(msg);
> if (flags & I2C_M_REV_DIR_ADDR)
> addr ^= 1;
>
> which look odd
I say no, because the driver has to also indicate support with
I2C_FUNC_PROTOCOL_MANGLING and I don't see a sane way to check
that part of the contract. But what do I know. Seems orthogonal.
> Do any of these changes now no longer need
> the temporary flags variable?
Right, I thought I had made any obvious further simplification made
possible by these changes, but I overlooked that one. The flags
variable is certainly over-engineered in i2c-algo-pcf.c and would
be a good candidate for removal. But that's only patch 3/21.
I'll wait for a bit with an update, and Wolfram can adjust this on
the way in if he feels like it.
Cheers,
Peter
^ permalink raw reply [flat|nested] 30+ messages in thread