* [PATCH] selftest: intel_pstate: More accurate error message and also a debug support message from aperf.c
@ 2018-05-14 22:01 Jeffrin Jose T
2018-05-15 20:22 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Jeffrin Jose T @ 2018-05-14 22:01 UTC (permalink / raw)
To: shuah, kstewart, tglx, pombredanne, gregkh
Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Jeffrin Jose T
Fix for aperf.c to produce the path of the file which is in mention
during error report.CONFIG_X86_MSR=m support requirement is also mentioned.
Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
---
tools/testing/selftests/intel_pstate/aperf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/intel_pstate/aperf.c b/tools/testing/selftests/intel_pstate/aperf.c
index d21edea9c560..da98c1673f08 100644
--- a/tools/testing/selftests/intel_pstate/aperf.c
+++ b/tools/testing/selftests/intel_pstate/aperf.c
@@ -41,7 +41,9 @@ int main(int argc, char **argv) {
fd = open(msr_file_name, O_RDONLY);
if (fd == -1) {
- perror("Failed to open");
+ printf("Failed to open /dev/cpu/%d/msr:", cpu);
+ printf(" No such file or directory:");
+ printf(" Make sure CONFIG_X86_MSR=m support is Enabled\n");
return 1;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftest: intel_pstate: More accurate error message and also a debug support message from aperf.c
2018-05-14 22:01 [PATCH] selftest: intel_pstate: More accurate error message and also a debug support message from aperf.c Jeffrin Jose T
@ 2018-05-15 20:22 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2018-05-15 20:22 UTC (permalink / raw)
To: Jeffrin Jose T, kstewart, tglx, pombredanne, gregkh
Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Shuah Khan
On 05/14/2018 04:01 PM, Jeffrin Jose T wrote:
> Fix for aperf.c to produce the path of the file which is in mention
> during error report.CONFIG_X86_MSR=m support requirement is also mentioned.
>
> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
> ---
> tools/testing/selftests/intel_pstate/aperf.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/intel_pstate/aperf.c b/tools/testing/selftests/intel_pstate/aperf.c
> index d21edea9c560..da98c1673f08 100644
> --- a/tools/testing/selftests/intel_pstate/aperf.c
> +++ b/tools/testing/selftests/intel_pstate/aperf.c
> @@ -41,7 +41,9 @@ int main(int argc, char **argv) {
> fd = open(msr_file_name, O_RDONLY);
>
> if (fd == -1) {
> - perror("Failed to open")> + printf("Failed to open /dev/cpu/%d/msr:", cpu);
Why are you deleting perror() and add a printf() for the error message perror()
printf()?
Why not collapse these messages into one and use strerror() to include the
error string?
> + printf(" No such file or directory:")
Not necessarily. open(0 could fail due to insufficient permissions. That is why
using strerror() or perror() is the correct way so the real error message gets
printed.
> + printf(" Make sure CONFIG_X86_MSR=m support is Enabled\n");
Might not be the real reason why the opeN() failed.
> return 1;
> }
The return should be KSFT_SKIP instead of 1
>
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 22:01 [PATCH] selftest: intel_pstate: More accurate error message and also a debug support message from aperf.c Jeffrin Jose T
2018-05-15 20:22 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).