From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops
Date: Wed, 16 May 2018 12:08:42 +0200 [thread overview]
Message-ID: <20180516100842.xuma7b3e727w7bpz@linutronix.de> (raw)
In-Reply-To: <ca78895ac7ac84ec1c7f2f33024237af329ffd7a.camel@linux.intel.com>
On 2018-05-15 21:37:18 [+0300], Andy Shevchenko wrote:
> On Tue, 2018-05-15 at 21:34 +0300, Andy Shevchenko wrote:
> > Kernel console is sensitive to any kind of complex work needed to
> > print
> > out anything on it. One such case is emergency print during Oops.
> >
> > This series proposes to disable runtime PM and DMA operations on 8250
> > serial console.
> >
> > More detailed explanation why is provided in patch 2.
> >
> > The series has been in our internal trees for years already with no
> > problems observed.
>
> +Cc: Tony.
>
> You might have some thoughts / test means for this.
I haven't look at the patches, just your cover letter. Disabling DMA on
kernel-console should be fine. The output is usually short so there
shouldn't be much benefit from using it.
I remember Tony wanted runtime-pm on the kernel console, too. And he
told me explicit how to test it so that it works. Once the UART goes
into PM (down), the whole IP block can go into power save mode. The
board can be woken up by sending a character via the UART. The first few
(incoming / read) characters are lost until the IP block is up again the
frequency stable. This is known / expected.
In order to achieve the same thing you would have to disable the kernel
console on that UART. I leave this to Tony.
Sebastian
next prev parent reply other threads:[~2018-05-16 10:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 18:34 [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 1/3] console: introduce ->exit() callback Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 2/3] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 3/3] serial: 8250_port: Disable DMA operations " Andy Shevchenko
2018-05-16 10:55 ` Sebastian Andrzej Siewior
2018-05-16 12:58 ` Andy Shevchenko
2018-05-16 18:20 ` Sebastian Andrzej Siewior
2018-05-15 18:37 ` [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-16 10:08 ` Sebastian Andrzej Siewior [this message]
2018-05-16 10:17 ` Andy Shevchenko
2018-05-16 10:47 ` Sebastian Andrzej Siewior
2018-05-16 13:10 ` Andy Shevchenko
2018-05-17 13:56 ` Tony Lindgren
2018-05-17 16:38 ` Andy Shevchenko
2018-05-17 19:30 ` Tony Lindgren
2018-05-22 21:39 ` Andy Shevchenko
2018-05-23 17:58 ` Tony Lindgren
2018-05-23 18:32 ` Tony Lindgren
2018-07-18 15:14 ` Andy Shevchenko
2018-07-19 6:47 ` Tony Lindgren
2018-05-17 17:04 ` Tony Lindgren
2018-05-17 13:48 ` Tony Lindgren
2018-05-17 16:36 ` Andy Shevchenko
2018-05-17 19:48 ` Tony Lindgren
2018-05-22 21:52 ` Andy Shevchenko
2018-05-23 18:00 ` Tony Lindgren
2018-07-18 14:50 ` Andy Shevchenko
2018-07-19 6:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516100842.xuma7b3e727w7bpz@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).